<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux.git/drivers/staging/speakup/kobjects.c, branch v4.1</title>
<subtitle>Linux kernel source tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/'/>
<entry>
<title>Staging: speakup: Remove unused variable</title>
<updated>2015-03-09T12:30:40+00:00</updated>
<author>
<name>Haneen Mohammed</name>
<email>hamohammed.sa@gmail.com</email>
</author>
<published>2015-03-07T21:03:51+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=f7d63547ea7fe7e4a666aa97e095855e5064b70e'/>
<id>f7d63547ea7fe7e4a666aa97e095855e5064b70e</id>
<content type='text'>
This patch removes variable that was used to store only the return value of a function call.

The issue was detected and resolved using the following coccinelle script:

@@
expression ret;
identifier f;
@@

 -ret =
 +return
    f(...);
 -return ret;

Signed-off-by: Haneen Mohammed &lt;hamohammed.sa@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch removes variable that was used to store only the return value of a function call.

The issue was detected and resolved using the following coccinelle script:

@@
expression ret;
identifier f;
@@

 -ret =
 +return
    f(...);
 -return ret;

Signed-off-by: Haneen Mohammed &lt;hamohammed.sa@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: Combine the consecutive string</title>
<updated>2015-01-18T00:14:16+00:00</updated>
<author>
<name>Panir.Nyan</name>
<email>panir.nyan@gmail.com</email>
</author>
<published>2014-12-24T04:07:32+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=25c048680b53c689ec918b3adfcfe62e1f03d4f0'/>
<id>25c048680b53c689ec918b3adfcfe62e1f03d4f0</id>
<content type='text'>
Combine the consecutive string

Signed-off-by: Panir Nyan &lt;Panir.Nyan@gmail.com&gt;
Acked-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Combine the consecutive string

Signed-off-by: Panir Nyan &lt;Panir.Nyan@gmail.com&gt;
Acked-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: Change char * array type as static const</title>
<updated>2014-10-20T02:29:12+00:00</updated>
<author>
<name>Ebru Akagunduz</name>
<email>ebru.akagunduz@gmail.com</email>
</author>
<published>2014-10-04T10:36:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=333c474b828e52bce8731e97fef27c2e950b5728'/>
<id>333c474b828e52bce8731e97fef27c2e950b5728</id>
<content type='text'>
This patch fixes "char * array declaration might be better as static const"
checkpatch.pl warning in kobjects.c

Signed-off-by: Ebru Akagunduz &lt;ebru.akagunduz@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch fixes "char * array declaration might be better as static const"
checkpatch.pl warning in kobjects.c

Signed-off-by: Ebru Akagunduz &lt;ebru.akagunduz@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: Fixed else after return or break warning</title>
<updated>2014-10-20T02:29:12+00:00</updated>
<author>
<name>Yeliz Taneroglu</name>
<email>yeliztaneroglu@gmail.com</email>
</author>
<published>2014-10-03T11:04:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=1f74d5f688faea24107de37893b7fd5a0e56ac49'/>
<id>1f74d5f688faea24107de37893b7fd5a0e56ac49</id>
<content type='text'>
The following patch fixes the checkpatch.pl warning:

drivers/staging/speakup/kobjects.c:812 warning: else is not generally useful after a break or return

Signed-off-by: Yeliz Taneroglu &lt;yeliztaneroglu@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The following patch fixes the checkpatch.pl warning:

drivers/staging/speakup/kobjects.c:812 warning: else is not generally useful after a break or return

Signed-off-by: Yeliz Taneroglu &lt;yeliztaneroglu@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: fix checkpatch warning</title>
<updated>2014-09-20T00:27:28+00:00</updated>
<author>
<name>Roxana Blaj</name>
<email>roxanagabriela10@gmail.com</email>
</author>
<published>2014-09-15T11:58:44+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=225557bf274ed1519362865815da7425533191d1'/>
<id>225557bf274ed1519362865815da7425533191d1</id>
<content type='text'>
This fixes the checkpatch warning:
WARNING: line over 80 characters

Signed-off-by: Roxana Blaj &lt;roxanagabriela10@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This fixes the checkpatch warning:
WARNING: line over 80 characters

Signed-off-by: Roxana Blaj &lt;roxanagabriela10@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: fix missing blank lines after declarations</title>
<updated>2014-09-11T21:54:51+00:00</updated>
<author>
<name>Domagoj Trsan</name>
<email>domagoj.trsan@gmail.com</email>
</author>
<published>2014-09-09T18:04:34+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=8e69a8110686572a4b88d006faa8c3c759c4c261'/>
<id>8e69a8110686572a4b88d006faa8c3c759c4c261</id>
<content type='text'>
Signed-off-by: Domagoj Trsan &lt;domagoj.trsan@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Domagoj Trsan &lt;domagoj.trsan@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>drivers/staging/speakup/: avoid world-writable sysfs files.</title>
<updated>2014-05-23T11:31:22+00:00</updated>
<author>
<name>Rusty Russell</name>
<email>rusty@rustcorp.com.au</email>
</author>
<published>2014-04-24T04:27:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=d901aaa723a7ea4601b0984534dde70adc81a38c'/>
<id>d901aaa723a7ea4601b0984534dde70adc81a38c</id>
<content type='text'>
In line with practice for module parameters, we're adding a build-time
check that sysfs files aren't world-writable.

Cc: Christopher Brannon &lt;chris@the-brannons.com&gt;
Cc: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In line with practice for module parameters, we're adding a build-time
check that sysfs files aren't world-writable.

Cc: Christopher Brannon &lt;chris@the-brannons.com&gt;
Cc: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: speakup: fix typo in kobjects.c</title>
<updated>2014-04-18T22:54:32+00:00</updated>
<author>
<name>Hayato Suzuki</name>
<email>hytszk@gmail.com</email>
</author>
<published>2014-04-16T11:57:14+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=ea143c4f6a84af0866f7be98f6a0b12ecd71b5bb'/>
<id>ea143c4f6a84af0866f7be98f6a0b12ecd71b5bb</id>
<content type='text'>
Correct spelling typo in kobjects.c

Signed-off-by: Hayato Suzuki &lt;hytszk@gmail.com&gt;
Acked-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Correct spelling typo in kobjects.c

Signed-off-by: Hayato Suzuki &lt;hytszk@gmail.com&gt;
Acked-by: Samuel Thibault &lt;samuel.thibault@ens-lyon.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: fix up speakup kobject mode</title>
<updated>2014-04-01T03:50:26+00:00</updated>
<author>
<name>Rusty Russell</name>
<email>rusty@rustcorp.com.au</email>
</author>
<published>2014-04-01T03:00:05+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=22c9bcad859d5c969289b3b37084a96c621f8f2c'/>
<id>22c9bcad859d5c969289b3b37084a96c621f8f2c</id>
<content type='text'>
It uses the unnecessary S_IFREG bit which broke when my
stricter-checking-for-mode patch went in.

Since we're fixing it anyway, the extra level of indirection is
confusing for readers (ROOT_W == rw-r--r-- for example).

Also, many of these are other-writable.  Is that really intended?

I'll-queue-this-patch-up-in-a-bit-by: Greg KH &lt;greg@kroah.com&gt;
Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It uses the unnecessary S_IFREG bit which broke when my
stricter-checking-for-mode patch went in.

Since we're fixing it anyway, the extra level of indirection is
confusing for readers (ROOT_W == rw-r--r-- for example).

Also, many of these are other-writable.  Is that really intended?

I'll-queue-this-patch-up-in-a-bit-by: Greg KH &lt;greg@kroah.com&gt;
Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Staging: speakup: replacing simple_strtoul with kstrtoul</title>
<updated>2013-10-19T21:51:06+00:00</updated>
<author>
<name>Ashvini Varatharaj</name>
<email>ashvinivaratharaj@gmail.com</email>
</author>
<published>2013-10-19T15:28:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=a8eecad5c906707475a2141133fe43710e5f5e85'/>
<id>a8eecad5c906707475a2141133fe43710e5f5e85</id>
<content type='text'>
Fix checkpatch warning: WARNING: simple_strtoul is obsolete, use
kstrtoul instead

Signed-off-by: Ashvini Varatharaj &lt;ashvinivaratharaj@gmail.com&gt;
Reviewed-by: Peter P Waskiewicz Jr &lt;peter.p.waskiewicz.jr@intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix checkpatch warning: WARNING: simple_strtoul is obsolete, use
kstrtoul instead

Signed-off-by: Ashvini Varatharaj &lt;ashvinivaratharaj@gmail.com&gt;
Reviewed-by: Peter P Waskiewicz Jr &lt;peter.p.waskiewicz.jr@intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
