linux.git/drivers/staging/speakup/kobjects.c, branch v3.17

drivers/staging/speakup/: avoid world-writable sysfs files.

2014-05-23T11:31:22+00:00

In line with practice for module parameters, we're adding a build-time
check that sysfs files aren't world-writable.

Cc: Christopher Brannon 
Cc: Samuel Thibault 
Signed-off-by: Rusty Russell 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: fix typo in kobjects.c

2014-04-18T22:54:32+00:00

Correct spelling typo in kobjects.c

Signed-off-by: Hayato Suzuki 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: fix up speakup kobject mode

2014-04-01T03:50:26+00:00

It uses the unnecessary S_IFREG bit which broke when my
stricter-checking-for-mode patch went in.

Since we're fixing it anyway, the extra level of indirection is
confusing for readers (ROOT_W == rw-r--r-- for example).

Also, many of these are other-writable.  Is that really intended?

I'll-queue-this-patch-up-in-a-bit-by: Greg KH 
Signed-off-by: Rusty Russell

Staging: speakup: replacing simple_strtoul with kstrtoul

2013-10-19T21:51:06+00:00

Fix checkpatch warning: WARNING: simple_strtoul is obsolete, use
kstrtoul instead

Signed-off-by: Ashvini Varatharaj 
Reviewed-by: Peter P Waskiewicz Jr 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: kobjects.c: Use correct values when changing voice.

2013-09-17T14:47:46+00:00

When a new voice is selected, we set volume and pitch appropriate for
the voice.  We need to use the numeric index corresponding to the
voice when indexing into the volume and pitch tables, rather than
the raw user input that was used to select the voice.
Note that using the raw input can also lead to an invalid memory read
in the case of invalid or malicious user input.

Signed-off-by: Christopher Brannon 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging/speakup/kobjects.c: Code improvement.

2013-09-17T14:47:45+00:00

Well, there is no need to use strcmp since we can make a test of similar semantic by using the var_id field of param.
I moved the test into the VAR_NUM:VAR_TIME case since VAR_STRING will never be "voice".

spk_xlate isn't used anymore (in line 628), then there is no difference between using cp and buf in VAR_STRING case.
Besides, buf is a const char and those changes remove one uneeded line.

I created the function spk_reset_default_value because it clarifies the code and allows code reusing.

Signed-off-by: Raphael S.Carvalho 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup/kobjects: Use NULL instead of 0

2013-05-22T22:35:39+00:00

Use NULL instead of 0 for pointers.

Signed-off-by: Sachin Kamat 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: kobjects: remove custom locking macros

2013-05-16T23:11:07+00:00

Signed-off-by: William Hubbs 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: remove custom string_unescape_any_inplace

2013-05-01T00:04:03+00:00

There is generic implementation of the function to unescape strings.

Signed-off-by: Andy Shevchenko 
Cc: Samuel Thibault 
Cc: Greg Kroah-Hartman 
Cc: William Hubbs 
Cc: Chris Brannon 
Cc: Kirk Reiser 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

staging: speakup: use native error codes

2013-03-29T15:41:15+00:00

The mapping as follows:
	E_RANGE		-> ERANGE
	E_UNDEF		-> ENODATA
	E_TOOLONG	-> E2BIG
	SET_DEFAULT	-> ERESTART

As a side effect it fixes a bug in spk_var_store() where return code was
mistakenly compared to negative value instead of positive.

Signed-off-by: Andy Shevchenko 
Acked-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman