linux.git/drivers/staging/slicoss, branch v4.9

staging: slicoss: cleaning up codestyle warnings

2016-09-27T11:08:04+00:00

This removes checkpatch.pl warnings:

WARNING: Block comments should align the * on each line

Signed-off-by: Grygorii Maistrenko 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: Move NULL test closer to assignment

2016-09-22T09:54:48+00:00

Move the test to check if a variable is NULL, to right after it is being
assigned, rather than some statements later.

Signed-off-by: Rehas Sachdeva 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: Remove unnecessary braces {}

2016-09-16T07:55:33+00:00

Removes unnecessary braces {} on both arms of an if-else block as they
have a single statement each. Issue detected by checkpatch.

Signed-off-by: Rehas Sachdeva 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: Remove blank lines before & after braces

2016-09-16T07:55:33+00:00

Removes unnecessary blank lines after an opening brace '{' and before a closing
brace '}'. Issue detected by checkpatch.pl.

Signed-off-by: Rehas Sachdeva 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: Remove unnecessary blank line

2016-09-16T07:55:33+00:00

Removes unnecessary blank line detected by checkpatch.

Signed-off-by: Rehas Sachdeva 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: add new line after struct declaration

2016-09-13T13:01:29+00:00

checkpatch generates a warning for no blank line after struct
declaration. Inserted a new line.

Signed-off-by: Gargi Sharma 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: constify ethtool_ops structures

2016-09-01T15:55:43+00:00

Check for ethtool_ops structures that are only stored in the ethtool_ops
field of a net_device structure or passed as the second argument to
netdev_set_default_ethtool_ops.  These contexts are declared const, so
ethtool_ops structures that have these properties can be declared as const
also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// 
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct ethtool_ops i@p = { ... };

@ok1@
identifier r.i;
struct net_device e;
position p;
@@
e.ethtool_ops = &i@p;

@ok2@
identifier r.i;
expression e;
position p;
@@
netdev_set_default_ethtool_ops(e, &i@p)

@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct ethtool_ops i = { ... };
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: simplify struct for statistics

2016-08-21T15:59:45+00:00

Merge several structures for statistics to one structure and remove
unnecessary union nesting.

Signed-off-by: Lino Sanfilippo 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: improve implementation concerning the shared memory

2016-08-21T15:59:45+00:00

Remove the volatile specifiers of struct slic_shmem. Furthermore store the
bus addresses for the isr pointer, link status and statistics separately
and access the upper and lower word of these addresses by means of
[lower|upper]_32_bits(). By doing this take the endianness into account.

Signed-off-by: Lino Sanfilippo 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: dont use a structure but offsets for register accesses

2016-08-21T15:59:45+00:00

Use the new register accessors that use offsets instead of the slic_regs
structure to read/write registers. Since not longer needed remove the
structure completley.

Signed-off-by: Lino Sanfilippo 
Signed-off-by: Greg Kroah-Hartman