linux.git/drivers/staging/slicoss, branch v3.14

staging: slicoss: Remove last reference to compare_ether_addr

2013-12-06T20:57:15+00:00

And use the normal is__ether_addr functions and ETH_ALEN too.

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-03T06:32:35+00:00

Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.

Signed-off-by: Jingoo Han 
Signed-off-by: Greg Kroah-Hartman

Staging: slicoss: Replace seq_printf with seq_puts

2013-10-27T14:03:19+00:00

This patch fixes the following checkpatch.pl warning in slicoss.c:
WARNING: Prefer seq_puts to seq_printf

Signed-off-by: Rashika Kheria 
Reviewed-by: Josh Triplett 
Signed-off-by: Greg Kroah-Hartman

Staging: slicoss: Fix quoted string split across lines

2013-10-19T21:45:08+00:00

This patch fixes the following checkpatch.pl warning in slicoss.c-
WARNING: quoted string split across lines

Signed-off-by: Rashika Kheria 
Reviewed-by: Peter P Waskiewicz Jr 
Signed-off-by: Greg Kroah-Hartman

Staging: slicoss: Refactor code by introducing new function slic_interrupt_card_up()

2013-10-19T21:45:08+00:00

This patch fixes the following checkpatch.pl warning in slicoss.c:
WARNING: Too many leading tabs - consider code refactoring

Signed-off-by: Rashika Kheria 
Reviewed-by: Peter P Waskiewicz Jr 
Signed-off-by: Greg Kroah-Hartman

Staging: slicoss: Replace printk() with pr_debug() or dev_dbg() as required

2013-10-19T21:45:08+00:00

This patch fixes the following checkpatch.pl warning in slicoss.c:
WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then
pr_debug(...  to printk(KERN_DEBUG ...

Signed-off-by: Rashika Kheria 
Reviewed-by: Peter P Waskiewicz Jr 
Signed-off-by: Greg Kroah-Hartman

Staging: slicoss: Removal of if check since debugfs_remove(NULL) is safe

2013-10-19T21:45:08+00:00

This patch fixes the following checkpatch.pl warning in slicoss.c:
WARNING: debugfs_remove(NULL) is safe this check is probably not
required

Signed-off-by: Rashika Kheria 
Reviewed-by: Peter P Waskiewicz Jr 
Signed-off-by: Greg Kroah-Hartman

Staging: Convert uses of compare_ether_addr to ether_addr_equal

2013-09-17T14:47:44+00:00

Preliminary to removing compare_ether_addr altogether:

Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.

Additionally:

Used is_zero_ether_addr, removed now unused variable
Converted uses of &foo[0] to foo

Done via cocci script: (and a little typing)

$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
-	!compare_ether_addr(a, b)
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	compare_ether_addr(a, b)
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) == 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) != 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) == 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) != 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!!ether_addr_equal(a, b)
+	ether_addr_equal(a, b)

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: fix error return code in slic_entry_probe()

2013-05-13T22:02:28+00:00

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: information leak in ETHTOOL_GSET

2013-04-05T21:17:00+00:00

There are some fields in "edata" which have not been cleared.  One
example is edata.cmd.  It leaks uninitialized stack information to the
user.

Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman