linux.git/drivers/staging/silicom, branch v3.15

staging/silicom/bypasslib/bp_ioctl.h Fix do not add new typedefs.

2014-03-18T18:55:31+00:00

Fix checkpatch.pl issues with do not add
new typedefs in bp_ioctl.h

Signed-off-by: Aybuke Ozdemir 
Signed-off-by: Greg Kroah-Hartman

staging: silicom: Fix line over 80 characters.

2014-03-17T03:02:20+00:00

Fix checkpatch.pl issues with line over 80 characters in bp_mod.h

Signed-off-by: Gulsah Kose 
Signed-off-by: Peter P Waskiewicz Jr

staging: silicom: 80 character and tab formatting in libbp_sd.h

2014-03-09T03:48:41+00:00

Fixes 80+ character limit warnings from checkpatch.pl
Changes aesthetics of spaces and tabs where appropriate.

Signed-off-by: Jade Bilkey 
Signed-off-by: Greg Kroah-Hartman

staging: silicom: fix trailing whitespace in libbp_sd.h

2014-03-09T03:48:41+00:00

Fixes checkpatch.pl trailing whitespace errors.

Signed-off-by: Jade Bilkey 
Reviewed-by: Sarah Sharp 
Signed-off-by: Greg Kroah-Hartman

staging: silicom : remove assignment in if condition

2014-03-07T21:23:12+00:00

This patch removes the assignment in if conditions to do away with the
checkpatch warning :'do not use assignment in if condition'.

Signed-off-by: Himangi Saraogi 
Signed-off-by: Greg Kroah-Hartman

drivers:staging:silicom fixed checkpatch coding style error on macros

2014-02-12T17:32:17+00:00

checkpatch displays below errors for bypasslib/bp_ioctl.h file

	 ERROR: Macros with complex values should be enclosed in parenthesis
Hence added parenthesis for macros with complex values.

Signed-off-by: Surendra Patil 
Signed-off-by: Greg Kroah-Hartman

drivers:staging:silicom Fixed extern warnings reported by checkpatch

2014-02-12T17:30:42+00:00

1) Deleted  bp_proc_create() declaration from bp_mod.h,
because it is declared as static in bpctl_mod.c and not used anywhere.

2) checkpatch warns about
     WARNING: externs should be avoided in .c files

because we have function declarations in bptcl_mod.c,These
functions are not used anywhere else so made them static.

Signed-off-by: Surendra Patil 
Signed-off-by: Greg Kroah-Hartman

drivers: staging: Mark functions as static and remove unused function in bpctl_mod.c

2014-02-07T18:15:48+00:00

Mark functions as static in bpctl_mod.c because they are not used
outside this file. Remove unused function from bpctl_mod.c.

This also eliminates the following warnings from bpctl_mod.c:
drivers/staging/silicom/bpctl_mod.c:1507:6: warning: no previous prototype for ‘send_bypass_clear_pulse’ [-Wmissing-prototypes]
drivers/staging/silicom/bpctl_mod.c:1762:5: warning: no previous prototype for ‘cmnd_on’ [-Wmissing-prototypes]
drivers/staging/silicom/bpctl_mod.c:1779:5: warning: no previous prototype for ‘cmnd_off’ [-Wmissing-prototypes]

...

Signed-off-by: Rashika Kheria 
Reviewed-by: Josh Triplett 
Signed-off-by: Greg Kroah-Hartman

Staging: silicom: fix sparse non static symbol warnings

2014-01-09T18:28:15+00:00

Fixes the following sparse warnings:

drivers/staging/silicom/bypasslib/bypass.c:528:12: warning: symbol 'init_lib_module' was not declared. Should it be static?
drivers/staging/silicom/bypasslib/bypass.c:534:13: warning: symbol 'cleanup_lib_module' was not declared. Should it be static?

Signed-off-by: Wei Yongjun 
Signed-off-by: Greg Kroah-Hartman

silicom: remaining checkpatch issues in bypass.c

2013-12-20T17:04:49+00:00

In this patch we fix some "logical" errors in bypass.c of the silicom bypass
driver (in staging).

Checkpatch complains about the following errors:
 - unnecessary forward declarations in a source file
 - assignment in if condition

In addition to that the __init and __exit macros were missing at the init and
cleanup function.

There are still two warnings left for this file related to too many leadingtabs
at nested blocks. I did not touch this issue becasue the code needs really some
refactoring. And since i do not have the appropriate hardware to test the code,
i do not change the functionality in any way.

Signed-off-by: Michael Hoefler 
Signed-off-by: Christoph Kohl 
Signed-off-by: Greg Kroah-Hartman