linux.git/drivers/staging/silicom, branch v3.14

Staging: silicom: fix sparse non static symbol warnings

2014-01-09T18:28:15+00:00

Fixes the following sparse warnings:

drivers/staging/silicom/bypasslib/bypass.c:528:12: warning: symbol 'init_lib_module' was not declared. Should it be static?
drivers/staging/silicom/bypasslib/bypass.c:534:13: warning: symbol 'cleanup_lib_module' was not declared. Should it be static?

Signed-off-by: Wei Yongjun 
Signed-off-by: Greg Kroah-Hartman

silicom: remaining checkpatch issues in bypass.c

2013-12-20T17:04:49+00:00

In this patch we fix some "logical" errors in bypass.c of the silicom bypass
driver (in staging).

Checkpatch complains about the following errors:
 - unnecessary forward declarations in a source file
 - assignment in if condition

In addition to that the __init and __exit macros were missing at the init and
cleanup function.

There are still two warnings left for this file related to too many leadingtabs
at nested blocks. I did not touch this issue becasue the code needs really some
refactoring. And since i do not have the appropriate hardware to test the code,
i do not change the functionality in any way.

Signed-off-by: Michael Hoefler 
Signed-off-by: Christoph Kohl 
Signed-off-by: Greg Kroah-Hartman

silicom: fix coding style issues in bypass.c

2013-12-20T17:04:49+00:00

This patch improves bypass.c (in staging) in terms of coding style. This
includes different issues some of them mentioned by checkpatch:

 - a c++ one line comment
 - parenthesis at return statementes
 - multiple definitions in one line
 - missing braces according to the style guide

Signed-off-by: Michael Hoefler 
Signed-off-by: Christoph Kohl 
Signed-off-by: Greg Kroah-Hartman

silicom: fix whitespace issues in bypass.c

2013-12-20T17:04:49+00:00

This patch addresses several problems in bypass.c found by checkpatch.
Furthermore it removes/adds some empty lines to make the code more readable.

The following problems are fixed:
 - line over 80 characters
 - space after logical operator !
 - spaces instead of tabs
 - missing empty line after local declarations
 - empty line after {

The empty line issues were not discovered by checkpatch but in my opinion these
changes make perfect sense in terms of readability.

Signed-off-by: Michael Hoefler 
Signed-off-by: Christoph Kohl 
Signed-off-by: Greg Kroah-Hartman

staging: silicom: remove dead code

2013-12-03T17:03:20+00:00

bus_info field of struct ethtool_drvinfo is an array thus it always
evaluates to true in a boolean context.  Therefore operation
depending on it being false will never be executed.

Signed-off-by: Michal Nazarewicz 
Signed-off-by: Greg Kroah-Hartman

Staging: silicom: Remove unnecessary variable from get_bypass_info()

2013-11-12T00:34:54+00:00

Remove unnecessary variable ioctl from get_bypass_info().

As a consequence, this patch removes an assignment to ioctl in an if condition,
reported by checkpatch.pl.

Signed-off-by: Rupert Muchembled 
Signed-off-by: Greg Kroah-Hartman

Staging: silicom: Remove unnecessary variable from do_cmd()

2013-11-12T00:34:54+00:00

Remove unnecessary variable ioctl from do_cmd().

As a consequence, this patch removes an assignment to ioctl in an if condition,
reported by checkpatch.pl.

Signed-off-by: Rupert Muchembled 
Signed-off-by: Greg Kroah-Hartman

staging: silicom: fix space prohibited before semicolon

2013-10-02T23:22:01+00:00

Signed-off-by: Tugce Sirin 
Reviewed-by: Josh Triplett 
Signed-off-by: Greg Kroah-Hartman

staging: silicom: introduce bp_dev_get_idx_bsf() and use it

2013-09-17T14:47:46+00:00

There are two places where duplicate code is located. Moreover, there is a
custom implementation of the sscanf() functionality. This patch makes code
quite simplier and cleaner.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Greg Kroah-Hartman

Staging: silicom: Remove useless unneeded semicolons

2013-07-23T21:42:56+00:00

Found using coccinelle tool.
Signed-off-by: Vladimir Cernov 
Signed-off-by: Greg Kroah-Hartman