linux.git/drivers/staging/rtlwifi, branch v5.1

staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc

2019-03-21T07:32:58+00:00

phydm.internal is allocated using kzalloc which is used multiple
times without a check for NULL pointer. This patch avoids such a
scenario by returning 0, consistent with the failure case.

Signed-off-by: Aditya Pakki 
Reviewed-by: Mukesh Ojha 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: rtl8822b: fix to avoid potential NULL pointer dereference

2019-03-21T07:32:57+00:00

skb allocated via dev_alloc_skb can fail and return a NULL pointer.
This patch avoids such a scenario and returns, consistent with other
invocations.

Signed-off-by: Aditya Pakki 
Reviewed-by: Mukesh Ojha 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Use proper enum for return in halmac_parse_psd_data_88xx

2019-02-21T09:58:11+00:00

Clang warns:

drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c:2472:11:
warning: implicit conversion from enumeration type 'enum
halmac_cmd_process_status' to different enumeration type 'enum
halmac_ret_status' [-Wenum-conversion]
                        return HALMAC_CMD_PROCESS_ERROR;
                        ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Fix this by using the proper enum for allocation failures,
HALMAC_RET_MALLOC_FAIL, which is used in the rest of this file.

Fixes: e4b08e16b7d9 ("staging: r8822be: check kzalloc return or bail")
Link: https://github.com/ClangBuiltLinux/linux/issues/375
Signed-off-by: Nathan Chancellor 
Reviewed-by: Nicholas Mc Guire 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Remove set but not used variables 'dataempty, hoffset'

2019-02-19T10:18:00+00:00

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/staging/rtlwifi/efuse.c: In function 'efuse_pg_packet_write':
drivers/staging/rtlwifi/efuse.c:922:24: warning:
 variable 'dataempty' set but not used [-Wunused-but-set-variable]

drivers/staging/rtlwifi/efuse.c: In function 'efuse_get_current_size':
drivers/staging/rtlwifi/efuse.c:1185:5: warning:
 variable 'hoffset' set but not used [-Wunused-but-set-variable]

They're never used and can be removed.

Signed-off-by: YueHaibing 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: fix spelling mistake: "Hightest" -> "Highest"

2019-02-19T10:12:08+00:00

Trivial fix to spelling mistake in ODM_RT_TRACE message text, fix it.

Signed-off-by: Colin Ian King 
Signed-off-by: Greg Kroah-Hartman

staging: r8822be: check kzalloc return or bail

2019-02-19T10:12:08+00:00

The kzalloc() in halmac_parse_psd_data_88xx() can fail and return NULL
so check the psd_set->data after allocation and if allocation failed
return HALMAC_CMD_PROCESS_ERROR.

Signed-off-by: Nicholas Mc Guire 
Fixes: 938a0447f094 ("staging: r8822be: Add code for halmac sub-drive")
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: replace ---help--- with help in Kconfig

2019-01-30T14:38:50+00:00

This patch fixes the checkpatch.pl warning:

WARNING: prefer 'help' over '---help---' for new help texts

Signed-off-by: Cezary Kierzyk 
Signed-off-by: Greg Kroah-Hartman

drivers: staging: rtlwifi: Start statement on a tabstop

2019-01-30T14:38:50+00:00

Fix the following checkpatch.pl warning:
        WARNING: Statements should start on a tabstop
        #208: FILE: pci.h:208:
        +	/*ASPM*/ u8 const_pci_aspm;

Signed-off-by: Felipe Cardoso Resende 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: rtl8822b: fix a missing check of alloc_skb

2019-01-15T15:08:28+00:00

__netdev_alloc_skb() return NULl when it fails. skb_put() further uses
it even when the allocation fails, leading to NULL pointer dereference.
The fix inserts a check for the return value of __netdev_alloc_skb().

Signed-off-by: Kangjie Lu 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: fix spelling mistake "disnabled" -> "disabled"

2018-12-05T08:39:45+00:00

There is a spelling mistake in an ODM_RT_TRACE message, fix it.

Signed-off-by: Colin Ian King 
Signed-off-by: Greg Kroah-Hartman