linux.git/drivers/staging/rtlwifi/halmac, branch v5.1

staging: rtlwifi: Use proper enum for return in halmac_parse_psd_data_88xx

2019-02-21T09:58:11+00:00

Clang warns:

drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c:2472:11:
warning: implicit conversion from enumeration type 'enum
halmac_cmd_process_status' to different enumeration type 'enum
halmac_ret_status' [-Wenum-conversion]
                        return HALMAC_CMD_PROCESS_ERROR;
                        ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Fix this by using the proper enum for allocation failures,
HALMAC_RET_MALLOC_FAIL, which is used in the rest of this file.

Fixes: e4b08e16b7d9 ("staging: r8822be: check kzalloc return or bail")
Link: https://github.com/ClangBuiltLinux/linux/issues/375
Signed-off-by: Nathan Chancellor 
Reviewed-by: Nicholas Mc Guire 
Signed-off-by: Greg Kroah-Hartman

staging: r8822be: check kzalloc return or bail

2019-02-19T10:12:08+00:00

The kzalloc() in halmac_parse_psd_data_88xx() can fail and return NULL
so check the psd_set->data after allocation and if allocation failed
return HALMAC_CMD_PROCESS_ERROR.

Signed-off-by: Nicholas Mc Guire 
Fixes: 938a0447f094 ("staging: r8822be: Add code for halmac sub-drive")
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Return -ENOMEM instead of -1

2018-10-02T22:18:36+00:00

Use the ENOMEM constant instead of -1 for kzalloc failure checks in
rtl_halmac.c

Signed-off-by: Aymen Qader 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Remove empty halmac_pcie_reg.h

2018-07-13T09:37:34+00:00

halmac_pcie_reg.h is empty, so remove it and the only include of it.

Signed-off-by: Bjorn Helgaas 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Fix a possible sleep-in-atomic-context bug in _is_fw_read_cmd_down()

2018-06-28T13:10:51+00:00

The driver may sleep with holding a spinlock.
The function call path (from bottom to top) in Linux-4.16.7 is:

[FUNC] schedule
drivers/staging/rtlwifi/halmac/rtl_halmac.c, 884:
		schedule in _is_fw_read_cmd_down
drivers/staging/rtlwifi/halmac/rtl_halmac.c, 912:
		_is_fw_read_cmd_down in rtl_halmac_send_h2c
drivers/staging/rtlwifi/halmac/rtl_halmac.c, 907:
		_raw_spin_lock_irqsave in rtl_halmac_send_h2c

To fix this bug, schedule() is replaced with mdelay(1).

This bug is found by my static analysis tool (DSAC-2) and checked by
my code review.

Signed-off-by: Jia-Ju Bai 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Replace license boilerplate with SPDX identifiers

2018-05-07T02:01:29+00:00

This satisfies a checkpatch.pl warning and is the preferred method for
notating the license due to its lack of ambiguity.

Signed-off-by: Nathan Chancellor 
Signed-off-by: Greg Kroah-Hartman

staging: r8822be: mark expected switch fall-throughs

2017-10-18T14:21:26+00:00

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: halmac: mark expected switch fall-through

2017-10-18T13:53:50+00:00

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Greg Kroah-Hartman

Merge 4.14-rc4 into staging-next

2017-10-09T07:02:35+00:00

We want the staging/iio fixes in here as well to handle merge issues.

Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: pr_err() strings should end with newlines

2017-10-03T16:36:25+00:00

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav 
Signed-off-by: Greg Kroah-Hartman