linux.git/drivers/staging/rtlwifi/halmac, branch v4.19

staging: rtlwifi: Remove empty halmac_pcie_reg.h

2018-07-13T09:37:34+00:00

halmac_pcie_reg.h is empty, so remove it and the only include of it.

Signed-off-by: Bjorn Helgaas 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Fix a possible sleep-in-atomic-context bug in _is_fw_read_cmd_down()

2018-06-28T13:10:51+00:00

The driver may sleep with holding a spinlock.
The function call path (from bottom to top) in Linux-4.16.7 is:

[FUNC] schedule
drivers/staging/rtlwifi/halmac/rtl_halmac.c, 884:
		schedule in _is_fw_read_cmd_down
drivers/staging/rtlwifi/halmac/rtl_halmac.c, 912:
		_is_fw_read_cmd_down in rtl_halmac_send_h2c
drivers/staging/rtlwifi/halmac/rtl_halmac.c, 907:
		_raw_spin_lock_irqsave in rtl_halmac_send_h2c

To fix this bug, schedule() is replaced with mdelay(1).

This bug is found by my static analysis tool (DSAC-2) and checked by
my code review.

Signed-off-by: Jia-Ju Bai 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: Replace license boilerplate with SPDX identifiers

2018-05-07T02:01:29+00:00

This satisfies a checkpatch.pl warning and is the preferred method for
notating the license due to its lack of ambiguity.

Signed-off-by: Nathan Chancellor 
Signed-off-by: Greg Kroah-Hartman

staging: r8822be: mark expected switch fall-throughs

2017-10-18T14:21:26+00:00

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: halmac: mark expected switch fall-through

2017-10-18T13:53:50+00:00

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Greg Kroah-Hartman

Merge 4.14-rc4 into staging-next

2017-10-09T07:02:35+00:00

We want the staging/iio fixes in here as well to handle merge issues.

Signed-off-by: Greg Kroah-Hartman

staging: rtlwifi: pr_err() strings should end with newlines

2017-10-03T16:36:25+00:00

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav 
Signed-off-by: Greg Kroah-Hartman

Staging: rtlwifi: halmac: Remove unnecessary 'out of memory' messages

2017-09-22T08:53:45+00:00

Remove unnecessary messages because OOM (Out Of Memory Manager)
reports memory allocation fail messages. The return value
is clear regarding the problem, so there is no need for the
'out of memory' comments. Also, delete braces {} for single
if statement blocks to improve the coding style.

Fix issues found by by checkpatch.pl.
WARNING: Possible unnecessary 'out of memory' message.
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Georgiana Chelu 
Signed-off-by: Greg Kroah-Hartman

staging: r8822be: fix null pointer dereferences with a null driver_adapter

2017-09-18T10:25:31+00:00

The call to _rtl_dbg_trace via macro HALMAC_RT_TRACE will trigger a null
pointer deference on a null driver_adapter.  Fix this by assigning
driver_adapter earlier to halmac_adapter->driver_adapter before the tracing
call so that a non-null driver_adapter is passed instead.

I should have spotted these with an earlier patch I sent, but I overlooked
these in the rather large CoverityScan logs.

Detected by CoverityScan, CID#1454550, CID#1454554, CID#1454565,
CID#1454591, CID#1454598 ("Explicit null dereferenced")

Fixes: 938a0447f094 ("staging: r8822be: Add code for halmac sub-driver")
Signed-off-by: Colin Ian King 
Signed-off-by: Greg Kroah-Hartman

staging: r8822be: Simplify deinit_priv()

2017-08-31T16:29:33+00:00

Now that the extraneous debugging code is removed, routine deinit_priv()
clearly contains code that serves no useful purpose.

A null test before a call to kfree() and a spurious cast are also removed.

Signed-off-by: Larry Finger 
Cc: Ping-Ke Shih 
Cc: Yan-Hsuan Chuang 
Cc: Birming Chiu 
Cc: Shaofu 
Cc: Steven Ting 
Signed-off-by: Greg Kroah-Hartman