linux.git/drivers/staging/rtl8723bs, branch v6.5

staging: rtl8723bs: Fix blank line issues

2023-06-20T14:13:30+00:00

Fix the following checkpatch blank line issues:
- CHECK: Please don't use multiple blank lines
- CHECK: Blank lines aren't necessary before a close brace '}'
- CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by: Franziska Naepelt 
Link: https://lore.kernel.org/r/20230619181246.19112-1-franziska.naepelt@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: Fix block comment issue

2023-06-20T14:12:56+00:00

Fix the following checkpatch block comment issue:
- WARNING: Block comments use * on subsequent lines

Signed-off-by: Franziska Naepelt 
Link: https://lore.kernel.org/r/20230619181230.19070-1-franziska.naepelt@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: Fix indentation issues

2023-06-20T14:12:40+00:00

Fix the following checkpatch indentation issues:
- WARNING: suspect code indent for conditional statements (32, 48)
- WARNING: suspect code indent for conditional statements (24, 24)
- ERROR: code indent should use tabs where possible

Signed-off-by: Franziska Naepelt 
Link: https://lore.kernel.org/r/20230619180351.18925-1-franziska.naepelt@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: replace ternary operator with if-else block

2023-05-28T09:11:29+00:00

replace the ternary operator used for assignment of pHalData->ant_path
with an if-else block for better readability

Signed-off-by: Atin Bainada 
Link: https://lore.kernel.org/r/20230513214338.79833-1-hi@atinb.me
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: use tabs for indentation

2023-05-08T14:09:03+00:00

Use tabs for indentation to conform to styleguide.

Signed-off-by: Daniel Watson 
Link: https://lore.kernel.org/r/ZEyAaC0riuuBJO14@trent-reznor
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: indent with tab, align with space

2023-04-05T14:37:10+00:00

Use tabs to indent code and spaces to align in order to make the code
consistent and easier to read.

Signed-off-by: Daniel Watson 
Link: https://lore.kernel.org/r/ZCdmCBIdabBGqm11@trent-reznor
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: conform if's braces to kernel style

2023-03-29T09:22:51+00:00

Move the open brace of if-statements to the same line. This matches the
brace placement style described in the kernel's style guide.

Signed-off-by: Daniel Watson 
Link: https://lore.kernel.org/r/ZCOGhkLvLtBEo92Y@trent-reznor
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: remove hal_btcoex_SetChipType()

2023-03-25T08:53:01+00:00

Remove the function hal_btcoex_SetChipType() as it does nothing and
produces the following gcc warning when compiling with W=1.

drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:30: warning: variable 'pHalData' set but not used [-Wunused-but-set-variable]
 1182 |         struct hal_com_data *pHalData;
      |                              ^~~~~~~~

Signed-off-by: Michael Straube 
Reviewed-by: Hans de Goede 
Link: https://lore.kernel.org/r/20230324084334.12183-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: use inline functions for dvobj_to_dev

2023-03-22T09:18:01+00:00

Convert `dvobj_to_dev` macro into a static inline function.
it is not great to have macro that use `container_of` macro,
because from looking at the definition one cannot tell
what type it applies to.

One can get the same benefit from an efficiency point of view
by making an inline function.

Suggested-by: Julia Lawall 
Signed-off-by: Menna Mahmoud 
Reviewed-by: Hans de Goede 
Link: https://lore.kernel.org/r/20230319201134.253839-1-eng.mennamahmoud.mm@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: rtw_get_raw_rssi_info() is not used

2023-03-16T08:40:09+00:00

The function rtw_get_raw_rssi_info() is not used anywhere, remove it.

Signed-off-by: Michael Straube 
Reviewed-by: Hans de Goede 
Link: https://lore.kernel.org/r/20230310083449.23775-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman