linux.git/drivers/staging/rtl8723bs, branch v4.16

staging: rtl8723bs: remove a couple of redundant initializations

2018-01-26T14:08:43+00:00

The initialization of PwrCfgCmd is redundant as the value is never read
and it is being re-assigned to PwrSeqCmd[AryIdx] inside a loop, hence
it can be removed.  Also, the initialization of ie_ptr is redundant as
the value is never read and it is being re-assigned in either path of
an if statement, hence it can be removed too.

Cleans up clang warnings:
drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c:53:15: warning: Value
stored to 'PwrCfgCmd' during its initialization is never read
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:374:7: warning: Value
stored to 'ie_ptr' during its initialization is never read

Signed-off-by: Colin Ian King 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8723bs: Use !x instead of NULL comparison

2018-01-25T12:34:04+00:00

If "x" is compared to NULL, use "!x" instead of it, so as
to follow the kernel coding style.

Signed-off-by: Shreeya Patel 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8723bs: Remove dead code

2018-01-25T12:34:04+00:00

"oldmem==NULL;"
The above bug under the ifdef code would have caused a GCC
warning if it were ever compiled. Hence, remove the dead ifdefed
code from the file.

Signed-off-by: Shreeya Patel 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8723bs: Change names to conform to the kernel code

2018-01-25T12:14:19+00:00

Change names of some variables and functions to conform
to the kernel coding style. The changes include some removal
of CamelCase warnings and renaming the variable and field names
that encode their type (eg the pointers seem to start with p).

Signed-off-by: Shreeya Patel 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: hal_com_phycfg: Remove unneeded semicolons

2018-01-22T16:04:02+00:00

Trivial fix removes unneeded semicolons after switch blocks.

This issue was detected by using the Coccinelle software.

Signed-off-by: Christopher Díaz Riveros 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: Fix trailing semicolon

2018-01-10T18:14:47+00:00

The trailing semicolon is an empty statement that does nothing.
Removing it since it has no purpose.

Signed-off-by: Luis de Bethencourt 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: Fix trailing semicolon

2018-01-10T18:14:47+00:00

The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.

Signed-off-by: Luis de Bethencourt 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8723bs: Fix trailing semicolon

2018-01-09T18:40:22+00:00

The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.

Signed-off-by: Luis de Bethencourt 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8723bs: Do not check for NOT NULL before kfree()

2017-12-21T17:22:07+00:00

Do not check for NOT NULL before calling kfree because
if the pointer is NULL, no action occurs.
Done using the following semantic patch by coccinelle.

@@
expression ptr;
@@

- if (ptr != NULL)
  kfree(ptr);

Signed-off-by: Shreeya Patel 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8723bs: Replace true with x and false with !x

2017-12-19T14:28:12+00:00

Replace true and false keywords with "x" and "!x"
respectively to follow the kernel coding style.

Signed-off-by: Shreeya Patel 
Signed-off-by: Greg Kroah-Hartman