<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux.git/drivers/staging/rtl8723bs/hal, branch v6.6</title>
<subtitle>Linux kernel source tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/'/>
<entry>
<title>staging: rtl8723bs: Use helpers to check broadcast and multicast Ether addresses</title>
<updated>2023-08-22T13:47:17+00:00</updated>
<author>
<name>Ruan Jinjie</name>
<email>ruanjinjie@huawei.com</email>
</author>
<published>2023-08-14T10:56:22+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=be6cded374cc8afa364a362f05d427d3729c9d43'/>
<id>be6cded374cc8afa364a362f05d427d3729c9d43</id>
<content type='text'>
Use is_multicast_ether_addr() and is_broadcast_ether_addr()
instead of custom macro IS_MCAST() and MacAddr_isBcst(), the buffer
is properly aligned.

Signed-off-by: Ruan Jinjie &lt;ruanjinjie@huawei.com&gt;
Link: https://lore.kernel.org/r/20230814105623.292541-1-ruanjinjie@huawei.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use is_multicast_ether_addr() and is_broadcast_ether_addr()
instead of custom macro IS_MCAST() and MacAddr_isBcst(), the buffer
is properly aligned.

Signed-off-by: Ruan Jinjie &lt;ruanjinjie@huawei.com&gt;
Link: https://lore.kernel.org/r/20230814105623.292541-1-ruanjinjie@huawei.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: rtl8723bs: replace ternary operator with if-else block</title>
<updated>2023-05-28T09:11:29+00:00</updated>
<author>
<name>Atin Bainada</name>
<email>hi@atinb.me</email>
</author>
<published>2023-05-13T21:44:31+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=dffef6de4db2ddbf1d456e618d06b128b9d0018b'/>
<id>dffef6de4db2ddbf1d456e618d06b128b9d0018b</id>
<content type='text'>
replace the ternary operator used for assignment of pHalData-&gt;ant_path
with an if-else block for better readability

Signed-off-by: Atin Bainada &lt;hi@atinb.me&gt;
Link: https://lore.kernel.org/r/20230513214338.79833-1-hi@atinb.me
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
replace the ternary operator used for assignment of pHalData-&gt;ant_path
with an if-else block for better readability

Signed-off-by: Atin Bainada &lt;hi@atinb.me&gt;
Link: https://lore.kernel.org/r/20230513214338.79833-1-hi@atinb.me
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: rtl8723bs: remove hal_btcoex_SetChipType()</title>
<updated>2023-03-25T08:53:01+00:00</updated>
<author>
<name>Michael Straube</name>
<email>straube.linux@gmail.com</email>
</author>
<published>2023-03-24T08:43:34+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=016227800e3b085d90638312bf79d40add8da1e4'/>
<id>016227800e3b085d90638312bf79d40add8da1e4</id>
<content type='text'>
Remove the function hal_btcoex_SetChipType() as it does nothing and
produces the following gcc warning when compiling with W=1.

drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:30: warning: variable 'pHalData' set but not used [-Wunused-but-set-variable]
 1182 |         struct hal_com_data *pHalData;
      |                              ^~~~~~~~

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230324084334.12183-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove the function hal_btcoex_SetChipType() as it does nothing and
produces the following gcc warning when compiling with W=1.

drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:30: warning: variable 'pHalData' set but not used [-Wunused-but-set-variable]
 1182 |         struct hal_com_data *pHalData;
      |                              ^~~~~~~~

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230324084334.12183-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: rtl8723bs: rtw_get_raw_rssi_info() is not used</title>
<updated>2023-03-16T08:40:09+00:00</updated>
<author>
<name>Michael Straube</name>
<email>straube.linux@gmail.com</email>
</author>
<published>2023-03-10T08:34:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=26269cbc7f2debf4cad98c74f14d0113672bb780'/>
<id>26269cbc7f2debf4cad98c74f14d0113672bb780</id>
<content type='text'>
The function rtw_get_raw_rssi_info() is not used anywhere, remove it.

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230310083449.23775-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The function rtw_get_raw_rssi_info() is not used anywhere, remove it.

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230310083449.23775-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: rtl8723bs: linked_info_dump() is not used</title>
<updated>2023-03-16T08:40:09+00:00</updated>
<author>
<name>Michael Straube</name>
<email>straube.linux@gmail.com</email>
</author>
<published>2023-03-10T08:34:48+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=1558280ca955c26bf0e13f7f17750a89c201d25b'/>
<id>1558280ca955c26bf0e13f7f17750a89c201d25b</id>
<content type='text'>
The function linked_info_dump() is not used anywhere, remove it.

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230310083449.23775-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The function linked_info_dump() is not used anywhere, remove it.

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230310083449.23775-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: rtl8723bs: isAllSpaceOrTab() is not used</title>
<updated>2023-03-16T08:40:09+00:00</updated>
<author>
<name>Michael Straube</name>
<email>straube.linux@gmail.com</email>
</author>
<published>2023-03-10T08:34:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=f89a163f1f66a9bea1222b0e61c3171b6bd0a080'/>
<id>f89a163f1f66a9bea1222b0e61c3171b6bd0a080</id>
<content type='text'>
The function isAllSpaceOrTab() is not used anywhere, remove it.

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230310083449.23775-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The function isAllSpaceOrTab() is not used anywhere, remove it.

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230310083449.23775-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: rtl8723bs: ParseQualifiedString() is not used</title>
<updated>2023-03-16T08:40:09+00:00</updated>
<author>
<name>Michael Straube</name>
<email>straube.linux@gmail.com</email>
</author>
<published>2023-03-10T08:34:46+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=e65df7f096d50200e7b6e0b545aeada510cbba63'/>
<id>e65df7f096d50200e7b6e0b545aeada510cbba63</id>
<content type='text'>
The function ParseQualifiedString() is not used anywhere, remove it.

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230310083449.23775-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The function ParseQualifiedString() is not used anywhere, remove it.

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230310083449.23775-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: rtl8723bs: MapCharToHexDigit() is not used</title>
<updated>2023-03-16T08:40:09+00:00</updated>
<author>
<name>Michael Straube</name>
<email>straube.linux@gmail.com</email>
</author>
<published>2023-03-10T08:34:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=78c0fb1ad68ce120efafe86790e4a674c2c12ef4'/>
<id>78c0fb1ad68ce120efafe86790e4a674c2c12ef4</id>
<content type='text'>
The function MapCharToHexDigit() is not used anywhere, remove it.

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230310083449.23775-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The function MapCharToHexDigit() is not used anywhere, remove it.

Signed-off-by: Michael Straube &lt;straube.linux@gmail.com&gt;
Reviewed-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Link: https://lore.kernel.org/r/20230310083449.23775-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: rtl8723bs: hal: Fix codespell-reported spelling mistakes</title>
<updated>2023-01-17T18:27:14+00:00</updated>
<author>
<name>Anup Sharma</name>
<email>anupnewsmail@gmail.com</email>
</author>
<published>2022-12-29T10:59:05+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=6aad66cdb09138557da6324fc628763f41ddf1c3'/>
<id>6aad66cdb09138557da6324fc628763f41ddf1c3</id>
<content type='text'>
They are appear to be spelling mistakes,
Initially identified in a codespell report and never been addressed so far.

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:656: regsiters ==&gt; registers
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:1696: beacause ==&gt; because
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:2092: Checl ==&gt; Check
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:2513: checksume ==&gt; checksum
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:2726: sequense ==&gt; sequence
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:2780: vlaue ==&gt; value
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:3409: equall ==&gt; equal, equally

Signed-off-by: Anup Sharma &lt;anupnewsmail@gmail.com&gt;
Link: https://lore.kernel.org/r/Y61y+flJp9/jEicc@local
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
They are appear to be spelling mistakes,
Initially identified in a codespell report and never been addressed so far.

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:656: regsiters ==&gt; registers
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:1696: beacause ==&gt; because
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:2092: Checl ==&gt; Check
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:2513: checksume ==&gt; checksum
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:2726: sequense ==&gt; sequence
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:2780: vlaue ==&gt; value
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:3409: equall ==&gt; equal, equally

Signed-off-by: Anup Sharma &lt;anupnewsmail@gmail.com&gt;
Link: https://lore.kernel.org/r/Y61y+flJp9/jEicc@local
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: rtl8723bs: replace underutilized struct by array variable</title>
<updated>2022-11-08T15:26:49+00:00</updated>
<author>
<name>Deepak R Varma</name>
<email>drv@mailo.com</email>
</author>
<published>2022-11-05T11:15:52+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=11454ddeb2f68a1c03b90f0c2bba18570f1a3019'/>
<id>11454ddeb2f68a1c03b90f0c2bba18570f1a3019</id>
<content type='text'>
For structure iqk_matrix_regs_setting, only the "Value" member variable
is utilized whereas the other struct members are only declared but not
utilised. Replace the struct declaration and implementation by an
equivalent variable similar to the only used struct member variable.
While in there, update the macro mixed case names to uppercase style.
The resultant code is simpler and is easy to maintain.

Suggested-by: Dan Carpenter &lt;error27@gmail.com&gt;
Signed-off-by: Deepak R Varma &lt;drv@mailo.com&gt;
Link: https://lore.kernel.org/r/Y2ZF6O1KU3zZ6r3C@qemulion
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For structure iqk_matrix_regs_setting, only the "Value" member variable
is utilized whereas the other struct members are only declared but not
utilised. Replace the struct declaration and implementation by an
equivalent variable similar to the only used struct member variable.
While in there, update the macro mixed case names to uppercase style.
The resultant code is simpler and is easy to maintain.

Suggested-by: Dan Carpenter &lt;error27@gmail.com&gt;
Signed-off-by: Deepak R Varma &lt;drv@mailo.com&gt;
Link: https://lore.kernel.org/r/Y2ZF6O1KU3zZ6r3C@qemulion
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
