linux.git/drivers/staging/rtl8712, branch v5.9

Staging: rtl8712: Fixed a coding sytle issue

2020-07-29T12:00:25+00:00

Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.

Signed-off-by: Ankit Baluni 
Link: https://lore.kernel.org/r/20200729074541.1972-1-b18007@students.iitmandi.ac.in
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Use fallthrough pseudo-keyword

2020-07-28T08:18:52+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva 
Link: https://lore.kernel.org/r/20200727185838.GA29595@embeddedor
Signed-off-by: Greg Kroah-Hartman

staging: rtl*/security: Use static const in array declarations

2020-07-17T10:08:44+00:00

Use static const in declarations where appropriate.

Signed-off-by: Joe Perches 
Link: https://lore.kernel.org/r/818bbd25924f0c733a4a39d426fd30392d4eae80.camel@perches.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: handle firmware load failure

2020-07-17T10:08:44+00:00

when firmware fails to load we should not call unregister_netdev()
this patch fixes a race condition between rtl871x_load_fw_cb() and
r871xu_dev_remove() and fixes the bug reported by syzbot

Reported-by: syzbot+80899a8a8efe8968cde7@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=80899a8a8efe8968cde7
Signed-off-by: Rustam Kovhaev 
Cc: stable 
Link: https://lore.kernel.org/r/20200716151324.1036204-1-rkovhaev@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712/: Using comparison to true is error prone

2020-07-10T11:55:11+00:00

clear below issues reported by checkpatch.pl:

CHECK: Using comparison to true is error prone
CHECK: Comparison to NULL should be written "!oldest"

Signed-off-by: John Oldman 
Link: https://lore.kernel.org/r/20200710113113.1648-1-john.oldman@polehill.co.uk
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Use proper format in call to dev_err()

2020-07-10T11:54:45+00:00

In the call to dev_err(), remove the cast of size_t to int
and change the format string accordingly.

As reported by the kernel test robot, the correct
format string for a size_t argument should be %zu.

Reported-by: kernel test robot 
Signed-off-by: Mauro Dreissig 
Link: https://lore.kernel.org/r/20200705143552.9368-6-mukadr@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Remove variable 'raw' from rtl871x_open_fw()

2020-07-10T11:53:59+00:00

Remove useless variable 'raw' from function rtl871x_open_fw()
making the code a bit easier to understand.

Signed-off-by: Mauro Dreissig 
Link: https://lore.kernel.org/r/20200705143552.9368-5-mukadr@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Use ETH_ALEN instead of hardcoded value

2020-07-10T11:53:59+00:00

Use macro ETH_ALEN which defines the number of octets in
an ethernet address.

Signed-off-by: Mauro Dreissig 
Link: https://lore.kernel.org/r/20200705143552.9368-4-mukadr@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Simplify expressions with boolean logic

2020-07-10T11:53:59+00:00

Simplify some expressions by using boolean operations.

Signed-off-by: Mauro Dreissig 
Link: https://lore.kernel.org/r/20200705143552.9368-3-mukadr@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Replace constant 49152 with expression 48 * 1024

2020-07-10T11:53:58+00:00

This way we don't need the comment stating that 49152 equals 48k.

Signed-off-by: Mauro Dreissig 
Link: https://lore.kernel.org/r/20200705143552.9368-2-mukadr@gmail.com
Signed-off-by: Greg Kroah-Hartman