linux.git/drivers/staging/rtl8712, branch v5.12

staging: rtl8712: Fix possible buffer overflow in r8712_sitesurvey_cmd

2021-03-10T08:23:28+00:00

Function r8712_sitesurvey_cmd calls memcpy without checking the length.
A user could control that length and trigger a buffer overflow.
Fix by checking the length is within the maximum allowed size.

Signed-off-by: Lee Gibson 
Link: https://lore.kernel.org/r/20210301132648.420296-1-leegib@gmail.com
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: unterminated string leads to read overflow

2021-03-10T08:23:28+00:00

The memdup_user() function does not necessarily return a NUL terminated
string so this can lead to a read overflow.  Switch from memdup_user()
to strndup_user() to fix this bug.

Fixes: c6dc001f2add ("staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes.")
Cc: stable 
Signed-off-by: Dan Carpenter 
Link: https://lore.kernel.org/r/YDYSR+1rj26NRhvb@mwanda
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Remove multiple blank lines

2021-02-09T17:42:16+00:00

Fix checkpatch.pl CHECK:
CHECK: Please don't use multiple blank lines

Signed-off-by: Aakash Hemadri 
Link: https://lore.kernel.org/r/20210209153709.128676-1-aakashhemadri123@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Switch from strlcpy to strscpy

2021-02-04T16:16:07+00:00

strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
and there is no functional difference when the caller expects truncation
(when not checking the return value). strscpy is relatively better as it
also avoids scanning the whole source string.

This silences the related checkpatch warnings from:
5dbdb2d87c29 ("checkpatch: prefer strscpy to strlcpy")

Signed-off-by: Kumar Kartikeya Dwivedi 
Link: https://lore.kernel.org/r/20210131172838.146706-12-memxor@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging:rtl8712: remove unused enum WIFI_STATUS_CODE

2021-01-31T12:37:52+00:00

Improve readability.

Signed-off-by: Ivan Safonov 
Link: https://lore.kernel.org/r/20210131080912.25264-1-insafonov@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Fix enqueue_reorder_recvframe()

2020-10-01T08:55:17+00:00

The logic of this function was accidentally broken by a checkpatch
inspired cleanup.  I've modified the code to restore the original
behavior and also make checkpatch happy.

Fixes: 98fe05e21a6e ("staging: rtl8712: Remove unnecesary else after return statement.")
Signed-off-by: Dan Carpenter 
Link: https://lore.kernel.org/r/20200929103548.GA493135@mwanda
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: use shorter array initializations

2020-09-22T07:49:59+00:00

Use empty brace syntax to initialize zero valued arrays.
Simplifies and shortens the code a little bit.

Signed-off-by: Michael Straube 
Link: https://lore.kernel.org/r/20200919085032.32453-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: clean up comparsions to NULL

2020-09-22T07:49:59+00:00

Clean up comparsions to NULL Reported by checkpatch.
if (x == NULL) -> if (!x)
if (x != NULL) -> if (x)

Signed-off-by: Michael Straube 
Link: https://lore.kernel.org/r/20200919085032.32453-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: convert tasklets to use new tasklet_setup() API

2020-09-16T11:13:00+00:00

In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Signed-off-by: Romain Perier 
Signed-off-by: Allen Pais 
Link: https://lore.kernel.org/r/20200916061831.57848-1-allen.lkml@gmail.com
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8712: Fixed a coding sytle issue

2020-07-29T12:00:25+00:00

Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.

Signed-off-by: Ankit Baluni 
Link: https://lore.kernel.org/r/20200729074541.1972-1-b18007@students.iitmandi.ac.in
Signed-off-by: Greg Kroah-Hartman