linux.git/drivers/staging/rtl8712, branch v5.1

staging: rtl8712: uninitialized memory in read_bbreg_hdl()

2019-03-21T07:32:57+00:00

Colin King reported a bug in read_bbreg_hdl():

	memcpy(pcmd->rsp, (u8 *)&val, pcmd->rspsz);

The problem is that "val" is uninitialized.

This code is obviously not useful, but so far as I can tell
"pcmd->cmdcode" is never GEN_CMD_CODE(_Read_BBREG) so it's not harmful
either.  For now the easiest fix is to just call r8712_free_cmd_obj()
and return.

Fixes: 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel")
Reported-by: Colin Ian King 
Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Fix indentation issue

2019-02-28T07:45:28+00:00

Fix indentation warning reported by checkpatch

Signed-off-by: Prashanth Kumar KR 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: drop pointless static qualifier in r8712_efuse_pg_packet_write()

2019-01-22T10:32:36+00:00

There is no need to have the 'intrepeat_times' variable static since new
value always be assigned before use it.

Signed-off-by: YueHaibing 
Acked-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712u: Fix suspend and resume callbacks

2019-01-15T15:11:50+00:00

When system resume and the rtl8712u dongle didn't lose its power, it
doesn't work quite right:
[  146.844241] r8712u 2-3:1.0 wlp0s4f1u3: Unable to resume
...
[  154.029573] r8712u 2-3:1.0 wlp0s4f1u3: In r8711_wx_set_scan: bDriverStopped=1

The !netif_running() check in PM callbacks aren't correct because
rtl8712u doesn't support runtime suspend, so the when the PM ops get
called, it's system suspend or system resume, hence we want to "stop
everthing" or "resume everything".

The NULL check on pnetdev is also redundant, the only place pnetdev can
become NULL is the disconnect callback, which is mutually exclusive to
PM callbacks.

This can make rtl8712u starts working after system resume.

Signed-off-by: Kai-Heng Feng 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712u: Remove dummy reset-resume callback

2019-01-15T15:11:50+00:00

An USB wireless dongle uses rtl8712u stops working after system
suspend/resume.

When a USB device lost its power during suspend, the USB core knows the
power was lost and a reset-resume or a re-probe is required. But rtl8712u
provides a dummy reset-resume callback, which gets called and renders
the device dead after resume.

So remove the reset-resume call back, if power was lost during suspend,
let the USB core unbind and probe the device to solve the issue.

Signed-off-by: Kai-Heng Feng 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: clean up various indentation and coding style issues

2019-01-15T15:08:36+00:00

There are several statements that are indented incorrectly so fix these.
Also remove unnecessary { } braces and clean up a comment.

Signed-off-by: Colin Ian King 
Signed-off-by: Greg Kroah-Hartman

Merge 4.20-rc6 into staging-next

2018-12-10T08:23:50+00:00

We want the staging fixes in here as well.

Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Fix possible buffer overrun

2018-12-05T08:56:09+00:00

In commit 8b7a13c3f404 ("staging: r8712u: Fix possible buffer
overrun") we fix a potential off by one by making the limit smaller.
The better fix is to make the buffer larger.  This makes it match up
with the similar code in other drivers.

Fixes: 8b7a13c3f404 ("staging: r8712u: Fix possible buffer overrun")
Signed-off-by: Young Xiao 
Cc: stable 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8712: fix small typo

2018-11-07T12:07:26+00:00

ture->true

Signed-off-by: Yangtao Li 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: fix CamelCase in fw_priv struct

2018-11-07T11:35:10+00:00

Rename fields in fw_priv struct from CamelCase to snake_case.
Reported by checkpatch.

Signed-off-by: Robert Eshleman 
Signed-off-by: Greg Kroah-Hartman