linux.git/drivers/staging/rtl8192u, branch v3.19

Staging: rtl8192u: Use put_unaligned_le16

2014-11-04T00:09:27+00:00

This patch introduces the use of function put_unaligned_le16.

This is done using Coccinelle and semantic patch used is as follows:

@@ identifier tmp; expression ptr; expression y,e; type T; @@

- tmp = cpu_to_le16(y);

  <+... when != tmp
- memcpy(ptr, (T)&tmp, ...);
+ put_unaligned_le16(y,ptr);
  ...+>
? tmp = e

@@ type T; identifier tmp; @@

- T tmp;
...when != tmp

Here, unnecessory comment after change is removed too.
This patch also fixes sparse warnings in file ieeee80211_softmac.c.

Signed-off-by: Vaishali Thakkar 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192u: Fix "space prohibited after that open parenthesis '('" errors

2014-10-29T08:48:43+00:00

Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors

Signed-off-by: Greg Donald 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192u: Fix checkpatch.pl warnings

2014-10-29T08:43:41+00:00

This patch fixes "line over 80 characters" warnings found in the first patch by breaking u4bAcParam's calculation down into a few steps.

Signed-off-by: Koray Gulcu 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192u: Fix sparse warnings of r8182U_core

2014-10-29T08:43:41+00:00

This patch fixes the following endianness warnings found by sparse running with CF=-D__CHECK_ENDIAN__:

drivers/staging/rtl8192u/r8192U_core.c:1794:10: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192u/r8192U_core.c:1794:10:    expected restricted __le16
drivers/staging/rtl8192u/r8192U_core.c:1794:10:    got int
drivers/staging/rtl8192u/r8192U_core.c:1794:13: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192u/r8192U_core.c:1794:13:    expected restricted __le16
drivers/staging/rtl8192u/r8192U_core.c:1794:13:    got int
drivers/staging/rtl8192u/r8192U_core.c:1794:16: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192u/r8192U_core.c:1794:16:    expected restricted __le16
drivers/staging/rtl8192u/r8192U_core.c:1794:16:    got int
drivers/staging/rtl8192u/r8192U_core.c:1794:19: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192u/r8192U_core.c:1794:19:    expected restricted __le16
drivers/staging/rtl8192u/r8192U_core.c:1794:19:    got int
drivers/staging/rtl8192u/r8192U_core.c:1795:10: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192u/r8192U_core.c:1795:10:    expected restricted __le16
drivers/staging/rtl8192u/r8192U_core.c:1795:10:    got int
drivers/staging/rtl8192u/r8192U_core.c:1795:13: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192u/r8192U_core.c:1795:13:    expected restricted __le16
drivers/staging/rtl8192u/r8192U_core.c:1795:13:    got int
drivers/staging/rtl8192u/r8192U_core.c:1795:16: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192u/r8192U_core.c:1795:16:    expected restricted __le16
drivers/staging/rtl8192u/r8192U_core.c:1795:16:    got int
drivers/staging/rtl8192u/r8192U_core.c:1795:19: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8192u/r8192U_core.c:1795:19:    expected restricted __le16
drivers/staging/rtl8192u/r8192U_core.c:1795:19:    got int
drivers/staging/rtl8192u/r8192U_core.c:1838:34: warning: cast from restricted __le16
drivers/staging/rtl8192u/r8192U_core.c:1839:34: warning: cast from restricted __le16
drivers/staging/rtl8192u/r8192U_core.c:1840:34: warning: cast from restricted __le16

Signed-off-by: Koray Gulcu 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8192u: Annotate association types with proper endianness

2014-10-28T07:53:26+00:00

This patch fixes following sparse warning at number of places in
file rtl819x_BAProc.c.

Warning: incorrect type in assignment (different base types)
         expected unsigned short [unsigned] [usertype] tmp
         got restricted __le16 [usertype] 

Here, code before this change is correct. But this change silents
sparse warnings and will not harm code too.

Signed-off-by: Vaishali Thakkar 
Reviewed-by: Arnd Bergmann 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192u: delete successive assignments to the same location

2014-10-28T07:53:26+00:00

Successive assignments to the same location is meaningless and can be
deleted. The Coccinelle semantic patch was used to find cases.

@@
expression e1,e2,e3;
@@

(
 (<+...e1++...+>)=e2;
|
 (<+...e1--...+>)=e2;
|
 (<+...++e1...+>)=e2;
|
 (<+...--e1...+>)=e2;
|
e1=e2;
e1 = <+...e1...+>;
|
*e1=e2;
*e1=e3;
)

Signed-off-by: Jiayi Ye 
Reviewed-by: Josh Triplett 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192u: Remove unnecessary if

2014-10-27T02:33:05+00:00

Remove the if condition, as the code inside the if condition is
commented and does not have any FIXME or TODO comment.

Signed-off-by: Tapasweni Pathak 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192u: Remove unused code

2014-10-20T02:29:29+00:00

Below return statement dm_send_rssi_tofw
function has dead code.

This patch removes dead code from dm_send_rssi_tofw.

This was detected by smatch.

Signed-off-by: Tapasweni Pathak 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192u: Add space after enum definition

2014-10-20T02:29:15+00:00

Fix checkpatch.pl warning:
WARNING:missing space after enum definition

Signed-off-by: Melike Yurtoglu 
Reviewed-by: Josh Triplett 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192u: ieee80211: Indent if statement

2014-10-20T02:29:15+00:00

This patch indents single statement below if statement
in files of rtl8192u: ieee80211.

Signed-off-by: Tapasweni Pathak 
Reviewed-by: Josh Triplett 
Signed-off-by: Greg Kroah-Hartman