linux.git/drivers/staging/rtl8188eu, branch v5.9 Linux kernel source tree staging: r8188eu: replace rtw_netdev_priv define with inline function 2020-08-02T10:47:37+00:00 Ivan Safonov insafonov@gmail.com 2020-08-01T18:02:35+00:00 5df9de5a40b00c965febad655773d6fb9a7961d5 The function guarantees type checking of arguments and return value. Result of rtw_netdev_priv macro can be assigned to pointer with incompatible type without warning. The function allow compiler to perform this check. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Link: https://lore.kernel.org/r/20200801180235.34116-1-insafonov@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The function guarantees type checking of arguments and return value.

Result of rtw_netdev_priv macro can be assigned to pointer
with incompatible type without warning. The function allow compiler
to perform this check.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Link: https://lore.kernel.org/r/20200801180235.34116-1-insafonov@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: rtl8188eu: rtw_mlme: Fix uninitialized variable authmode 2020-07-28T08:18:53+00:00 Dinghao Liu dinghao.liu@zju.edu.cn 2020-07-28T07:21:51+00:00 11536442a3b4e1de6890ea5e805908debb74f94a The variable authmode can be uninitialized. The danger would be if it equals to _WPA_IE_ID_ (0xdd) or _WPA2_IE_ID_ (0x33). We can avoid this by setting it to zero instead. This is the approach that was used in the rtl8723bs driver. Fixes: 7b464c9fa5cc ("staging: r8188eu: Add files for new driver - part 4") Co-developed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20200728072153.9202-1-dinghao.liu@zju.edu.cn Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The variable authmode can be uninitialized. The danger would be if
it equals to _WPA_IE_ID_ (0xdd) or _WPA2_IE_ID_ (0x33). We can avoid
this by setting it to zero instead. This is the approach that was
used in the rtl8723bs driver.

Fixes: 7b464c9fa5cc ("staging: r8188eu: Add files for new driver - part 4")
Co-developed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200728072153.9202-1-dinghao.liu@zju.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: r8188eu: use proper type for second argiment of rtw_(aes|tkip|wep)_(decrypt|encrypt) 2020-07-28T08:05:33+00:00 Ivan Safonov insafonov@gmail.com 2020-07-26T21:02:46+00:00 01713f0d58322f0029f5ac99ce60dd44414b4902 rtw_aes_decrypt, rtw_tkip_decrypt, rtw_wep_decrypt, rtw_aes_encrypt, rtw_tkip_encrypt, rtw_wep_encrypt are takes (u8 *) second argiment and always uses it as (struct recv_frame *) or (struct xmit_frame *). This is causes a lot of unnecessary type casts and complicates refactoring. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Link: https://lore.kernel.org/r/20200726210246.68633-1-insafonov@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
rtw_aes_decrypt, rtw_tkip_decrypt, rtw_wep_decrypt, rtw_aes_encrypt,
rtw_tkip_encrypt, rtw_wep_encrypt are takes (u8 *) second argiment and
always uses it as (struct recv_frame *) or (struct xmit_frame *).
This is causes a lot of unnecessary type casts
and complicates refactoring.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Link: https://lore.kernel.org/r/20200726210246.68633-1-insafonov@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error 2020-07-25T13:27:24+00:00 Anant Thazhemadam anant.thazhemadam@gmail.com 2020-07-25T12:20:38+00:00 d8cc6b5664b40b10bd2896f0bbbfe451a02c8457 Running the checkpatch.pl script on the file for which patch was created, the following error was found to exist. ERROR: space required after that ',' (ctx:VxV) Fixed the above error which was found on line #721 by inserting a blank space at the appropriate position. Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com> Link: https://lore.kernel.org/r/20200725122041.5663-1-anant.thazhemadam@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Running the checkpatch.pl script on the file for which patch was created, the
following error was found to exist.
ERROR: space required after that ',' (ctx:VxV)

Fixed the above error which was found on line #721 by inserting a blank
space at the appropriate position.

Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Link: https://lore.kernel.org/r/20200725122041.5663-1-anant.thazhemadam@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: rtl8188eu: Fix a constant comparison coding style issue 2020-07-23T18:34:34+00:00 Priti Chattopadhyay pritias81@gmail.com 2020-07-23T09:21:55+00:00 b5dbbadb0eb93aaca51d5effeed96b94af150e07 Modify equality comparison involving constants by shifting the constant operand to the right side of the comparison as suggested by scripts/checkpatch.pl Signed-off-by: Priti Chattopadhyay <pritias81@gmail.com> Link: https://lore.kernel.org/r/20200723092150.y34bentngeeci2oc@pritichattopadhyay Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Modify equality comparison involving constants by shifting the constant
operand to the right side of the comparison as suggested by
scripts/checkpatch.pl

Signed-off-by: Priti Chattopadhyay <pritias81@gmail.com>
Link: https://lore.kernel.org/r/20200723092150.y34bentngeeci2oc@pritichattopadhyay
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8188eu: Fix an indent coding style issue 2020-07-23T08:31:46+00:00 Mrinal Pandey mrinalmni@gmail.com 2020-07-22T15:19:00+00:00 032ae2fd3ce12e8aa538165b44dc129c355a1ee1 Only a single tab space is required after the if statement. Fix this issue by running scripts/checkpatch.pl on the file. Signed-off-by: Mrinal Pandey <mrinalmni@gmail.com> Link: https://lore.kernel.org/r/20200722151900.5dcebtavkdi5cc77@mrinalpandey Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Only a single tab space is required after the if statement.
Fix this issue by running scripts/checkpatch.pl on the file.

Signed-off-by: Mrinal Pandey <mrinalmni@gmail.com>
Link: https://lore.kernel.org/r/20200722151900.5dcebtavkdi5cc77@mrinalpandey
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8188eu: cleanup whitespace in declarations 2020-07-23T08:31:45+00:00 Michael Straube straube.linux@gmail.com 2020-07-23T07:52:43+00:00 a176db57611f260d920e34d36bb43460069da1ed Replace tabs with spaces in declarations to cleanup whitespace in rtl8188eu_recv.c. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20200723075243.21924-2-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Replace tabs with spaces in declarations to cleanup whitespace
in rtl8188eu_recv.c.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20200723075243.21924-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8188eu: clear alignment style issues 2020-07-23T08:31:45+00:00 Michael Straube straube.linux@gmail.com 2020-07-23T07:52:42+00:00 869090266ceb60210f69f96fb29fe8ad6b4b850d Clear checkpatch alignment style issues in rtl8188eu_recv.c. CHECK: Alignment should match open parenthesis The file is now checkpatch clean. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20200723075243.21924-1-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Clear checkpatch alignment style issues in rtl8188eu_recv.c.
CHECK: Alignment should match open parenthesis

The file is now checkpatch clean.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20200723075243.21924-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8188eu: add spaces around operators in header files 2020-07-20T08:22:47+00:00 Michael Straube straube.linux@gmail.com 2020-07-19T11:40:45+00:00 315116579f79fafd7eea285e0c608682a649d786 Add spaces around operators in the header files to improve readability and clear checkpatch issues. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20200719114045.13595-1-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Add spaces around operators in the header files to improve readability
and clear checkpatch issues.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20200719114045.13595-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: rtl8188eu: core: Fix coding style issue 2020-07-20T08:22:47+00:00 Anoop S anoop.skumar1507@gmail.com 2020-07-18T10:31:25+00:00 939032fb84eb67a88a0baafbd33f27940e307fbc This fixes the following checkpatch.pl warning WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this function's name, in a string. Signed-off-by: Anoop S <anoop.skumar1507@gmail.com> Link: https://lore.kernel.org/r/20200718103125.62528-1-anoop.skumar1507@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This fixes the following checkpatch.pl warning
WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this function's name, in a string.

Signed-off-by: Anoop S <anoop.skumar1507@gmail.com>
Link: https://lore.kernel.org/r/20200718103125.62528-1-anoop.skumar1507@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>