linux.git/drivers/staging/rtl8188eu, branch v3.19

staging: rtl8188eu: hal: hal_intf.c: Cleaning up functions that are not used anywhere

2014-12-03T00:29:26+00:00

Removes some functions that are not used anywhere.
rtw_hal_interrupt_handler() rtw_hal_sreset_get_wifi_status()

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8188eu: usb_dvobj_init(): A NULL pointer check for usb_host_endpoints makes no sense

2014-12-03T00:29:26+00:00

struct usb_host_interface points to an array of
struct usb_host_endpoints - it makes no sense to do a NULL pointer
check for each pointer.

Signed-off-by: Jes Sorensen 
Acked-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging:drivers:staging:rtl8188eu:hal:rtl8188e_hal_init.c: Added a blank line after declaration

2014-12-03T00:29:26+00:00

This patch fix a checkpatch.pl warning

WARNING:Missing blank line after declaration

Signed-off-by: Anjana Sasindran 
Signed-off-by: Greg Kroah-Hartman

Merge 3.18-rc7 into staging-work.

2014-12-03T00:20:59+00:00

We want those staging fixes in here as well.

Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Add new device ID for DLink GO-USB-N150

2014-11-27T16:55:01+00:00

The DLink GO-USB-N150 with revision B1 uses this driver.

Signed-off-by: Larry Finger 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

rtl8188eu: Fix a typo in rtw_led.*

2014-11-26T23:27:25+00:00

A rather obvious typo in one of the identifier has been found.  This patch
fixes the typo and ensures any lines changed do not exceed 80 characters
as indicated by scripts/checkpatch.pl

Signed-off-by: Krzysztof Konopko 
Signed-off-by: Greg Kroah-Hartman

rtl8188eu: Fix FSF_MAILING_ADDRESS in rtw_led.*

2014-11-26T23:27:25+00:00

rtw_led.* files include Free Software Foundation's mailing address in
the sample GPL notice.  This is not desired and picked when running
scripts/checkpatch.pl.

Signed-off-by: Krzysztof Konopko 
Signed-off-by: Greg Kroah-Hartman

rtl8188eu: Simplify rtw_endofpktfile() in xmit_linux.c

2014-11-26T23:27:25+00:00

scripts/checkpatch.pl reports a coding style problem in xmit_linux.c

  WARNING:BRACES: braces {} are not necessary for single statement blocks
  #61852: FILE: rtl8188eu/os_dep/xmit_linux.c:70:

This patch removes unnecessary braces and simplifies the function to a
single return statement.

Signed-off-by: Krzysztof Konopko 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Fix scheduling while atomic error introduced in commit fadbe0cd

2014-11-26T22:03:48+00:00

In commit fadbe0cd5292851608e2e01b91d9295fa287b9fe entitled "staging:
rtl8188eu:Remove rtw_zmalloc(), wrapper for kzalloc()", the author failed
to note that the original code in the wrapper tested whether the caller
could sleep, and set the flags argument to kzalloc() appropriately.
After the patch, GFP_KERNEL is used unconditionally. Unfortunately, several
of the routines may be entered from an interrupt routine and generate
a BUG splat for every such call. Routine rtw_sitesurvey_cmd() is used in the
example below:

BUG: sleeping function called from invalid context at mm/slub.c:1240
in_atomic(): 1, irqs_disabled(): 0, pid: 756, name: wpa_supplicant
INFO: lockdep is turned off.
CPU: 2 PID: 756 Comm: wpa_supplicant Tainted: G        WC O   3.18.0-rc4+ #34
Hardware name: TOSHIBA TECRA A50-A/TECRA A50-A, BIOS Version 4.20   04/17/2014
ffffc90005557000 ffff880216fafaa8 ffffffff816b0bbf 0000000000000000
ffff8800c3b58000 ffff880216fafac8 ffffffff8107af77 0000000000000001
0000000000000010 ffff880216fafb18 ffffffff811b06ce 0000000000000000
Call Trace:
 [] dump_stack+0x4e/0x71
 [] __might_sleep+0xf7/0x120
 [] kmem_cache_alloc_trace+0x4e/0x1f0
 [] ? rtw_sitesurvey_cmd+0x56/0x2a0 [r8188eu]
 [] rtw_sitesurvey_cmd+0x56/0x2a0 [r8188eu]
 [] rtw_do_join+0x22d/0x370 [r8188eu]
 [] rtw_set_802_11_ssid+0x218/0x3d0 [r8188eu]
 [] rtw_wx_set_essid+0x1e5/0x410 [r8188eu]
 [] ? rtw_wx_get_rate+0x50/0x50 [r8188eu]
 [] ioctl_standard_iw_point+0x151/0x3f0
 [] ioctl_standard_call+0xb2/0xe0
 [] ? rtnl_lock+0x17/0x20
 [] ? iw_handler_get_private+0x70/0x70
 [] ? call_commit_handler+0x40/0x40
 [] wireless_process_ioctl+0x176/0x1c0
 [] wext_handle_ioctl+0x69/0xc0
 [] dev_ioctl+0x309/0x5e0
 [] ? call_rcu+0x17/0x20
 [] sock_ioctl+0x142/0x2e0
 [] do_vfs_ioctl+0x300/0x520
 [] ? __audit_syscall_entry+0xb4/0x110
 [] ? __audit_syscall_entry+0xb4/0x110
 [] ? do_audit_syscall_entry+0x6c/0x70
 [] SyS_ioctl+0x81/0xa0
 [] system_call_fastpath+0x12/0x17

Additional routines that generate this BUG are rtw_joinbss_cmd(),
rtw_dynamic_chk_wk_cmd(), rtw_lps_ctrl_wk_cmd(), rtw_rpt_timer_cfg_cmd(),
rtw_ps_cmd(), report_survey_event(), report_join_res(), survey_timer_hdl(),
and rtw_check_bcn_info().

Signed-off-by: Larry Finger 
Cc: navin patidar 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8188eu: unneeded NULL check

2014-11-07T17:47:29+00:00

before these NULL checks we are already checking it for NULL, and if
it is NULL then we are jumping to the error label and handling
the error before returning.
So we can reach this part of the code only if the variable is known
to be not NULL, and if we already know that it is not NULL, then no
need to check it again.

Signed-off-by: Sudip Mukherjee 
Signed-off-by: Greg Kroah-Hartman