linux.git/drivers/staging/rtl8188eu, branch v3.12

staging: r8188eu: Add new device ID

2013-09-26T23:44:45+00:00

The DLink DWA-125 Rev D1 also uses this driver.

Signed-off-by: Larry Finger 
Reported-by: Sergey Kostanbaev 
Tested-by: Sergey Kostanbaev 
Cc: Sergey Kostanbaev 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Add files for new drive: Cocci spatch "noderef"

2013-09-25T23:53:39+00:00

sizeof when applied to a pointer typed expression gives the size of the
pointer.
Found by coccinelle spatch "misc/noderef.cocci"

Signed-off-by: Thomas Meyer 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Cocci spatch "noderef"

2013-09-25T23:53:39+00:00

sizeof when applied to a pointer typed expression gives the size of the
pointer.
Found by coccinelle spatch "misc/noderef.cocci"

Signed-off-by: Thomas Meyer 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Add files for new drive: Cocci spatch "noderef"

2013-09-25T23:53:38+00:00

sizeof when applied to a pointer typed expression gives the size of the
pointer.
Found by coccinelle spatch "misc/noderef.cocci"

Signed-off-by: Thomas Meyer 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Adjust RX gain

2013-09-17T14:39:28+00:00

In some circumstances, the performance of this driver is highly degraded,
and ifconfig reports large numbers of dropped packets. By increasing the
maximum RX gain from 0x3e to 0x4e, performance is greatly improved.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Fix smatch warning in core/rtw_ieee80211.

2013-09-17T14:39:28+00:00

Smatch shows the following warning:
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:161 rtw_set_ie() info: ignoring unreachable code.

The cause is a module exit tracing statement after a return.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Fix smatch error in core/rtw_mlme_ext.c

2013-09-17T14:39:28+00:00

Smatch reports the following warning:
"drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:8328 mlme_evt_hdl()
	 error: buffer overflow 'wlanevents' 24 <= 24"

  8321          /*  checking if event code is valid */
  8322          if (evt_code >= MAX_C2HEVT) {
                    ^^^^^^^^^^^^^^^^^^^^^^
  8323                  RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("\nEvent Code(%d) mismatch!\n", evt_code));
  8324                  goto _abort_event_;
  8325          }
  8326
  8327          /*  checking if event size match the event parm size */
  8328          if ((wlanevents[evt_code].parmsize != 0) &&
                     ^^^^^^^^^^^^^^^^^^^^
  8329              (wlanevents[evt_code].parmsize != evt_sz)) {
  8330                  RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_,
  8331                           ("\nEvent(%d) Parm Size mismatch (%d vs %d)!\n",
  8332                           evt_code, wlanevents[evt_code].parmsize, evt_sz));
  8333                  goto _abort_event_;
  8334          }

This warning results because the number of items in "enum rtw_c2h_event",
which determines the value of MAX_C2HEVT, is one more than in "struct wlanevents".
Adding an extra dummy event to the latter fixes the problem.

Reported-by: Dan Carpenter 
Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Fix Smatch off-by-one warning in hal/rtl8188e_hal_init.c

2013-09-17T14:39:28+00:00

Smatch reports the following warning:
"drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:2008
Hal_ReadPowerValueFromPROM_8188E()
	 error: buffer overflow 'pwrInfo24G->IndexBW40_Base[rfPath]' 5 <= 5"

drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
  2005                          /* 2.4G default value */
  2006                          for (group = 0; group < MAX_CHNL_GROUP_24G; group++) {
  2007                                  pwrInfo24G->IndexCCK_Base[rfPath][group] =      EEPROM_DEFAULT_24G_INDEX;
  2008                                  pwrInfo24G->IndexBW40_Base[rfPath][group] =     EEPROM_DEFAULT_24G_INDEX;

The reason is that IndexCCK_Base[] has MAX_CHNL_GROUP_24G elements, but
IndexBW40_Base is smaller by 1. Make them both have MAX_CHNL_GROUP_24G
elements.

Reported by: Dan Carpenter 
Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Fix uninitialized variable change_inx

2013-09-17T14:39:27+00:00

drivers/staging/rtl8188eu/core/rtw_wlan_util.c: In function ‘WMMOnAssocRsp’:
drivers/staging/rtl8188eu/core/rtw_wlan_util.c:634: warning: ‘change_inx’ may be used uninitialized in this function

And the compiler is right: change_inx should be initialized to false.

Signed-off-by: Geert Uytterhoeven 
Acked-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging/rtl8188eu: pass channel list by reference instead of copying struct.

2013-09-17T14:39:27+00:00

Signed-off-by: Dave Jones 
Acked-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman