linux.git/drivers/staging/rtl8188eu/include, branch v3.12

staging: r8188eu: Adjust RX gain

2013-09-17T14:39:28+00:00

In some circumstances, the performance of this driver is highly degraded,
and ifconfig reports large numbers of dropped packets. By increasing the
maximum RX gain from 0x3e to 0x4e, performance is greatly improved.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Fix smatch error in core/rtw_mlme_ext.c

2013-09-17T14:39:28+00:00

Smatch reports the following warning:
"drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:8328 mlme_evt_hdl()
	 error: buffer overflow 'wlanevents' 24 <= 24"

  8321          /*  checking if event code is valid */
  8322          if (evt_code >= MAX_C2HEVT) {
                    ^^^^^^^^^^^^^^^^^^^^^^
  8323                  RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("\nEvent Code(%d) mismatch!\n", evt_code));
  8324                  goto _abort_event_;
  8325          }
  8326
  8327          /*  checking if event size match the event parm size */
  8328          if ((wlanevents[evt_code].parmsize != 0) &&
                     ^^^^^^^^^^^^^^^^^^^^
  8329              (wlanevents[evt_code].parmsize != evt_sz)) {
  8330                  RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_,
  8331                           ("\nEvent(%d) Parm Size mismatch (%d vs %d)!\n",
  8332                           evt_code, wlanevents[evt_code].parmsize, evt_sz));
  8333                  goto _abort_event_;
  8334          }

This warning results because the number of items in "enum rtw_c2h_event",
which determines the value of MAX_C2HEVT, is one more than in "struct wlanevents".
Adding an extra dummy event to the latter fixes the problem.

Reported-by: Dan Carpenter 
Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Fix Smatch off-by-one warning in hal/rtl8188e_hal_init.c

2013-09-17T14:39:28+00:00

Smatch reports the following warning:
"drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:2008
Hal_ReadPowerValueFromPROM_8188E()
	 error: buffer overflow 'pwrInfo24G->IndexBW40_Base[rfPath]' 5 <= 5"

drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
  2005                          /* 2.4G default value */
  2006                          for (group = 0; group < MAX_CHNL_GROUP_24G; group++) {
  2007                                  pwrInfo24G->IndexCCK_Base[rfPath][group] =      EEPROM_DEFAULT_24G_INDEX;
  2008                                  pwrInfo24G->IndexBW40_Base[rfPath][group] =     EEPROM_DEFAULT_24G_INDEX;

The reason is that IndexCCK_Base[] has MAX_CHNL_GROUP_24G elements, but
IndexBW40_Base is smaller by 1. Make them both have MAX_CHNL_GROUP_24G
elements.

Reported by: Dan Carpenter 
Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Fix compiler warnings in os_dep/ioctl_linux.c

2013-08-30T18:46:46+00:00

The 0-DAY kernel build testing backend reports the following compiler
warnings not shown on my compiler version/options:

   drivers/staging/rtl8188eu/os_dep/ioctl_linux.c: In function 'rtw_mp_efuse_get':
>> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:5836:65: warning: iteration 16u invokes undefined behavior [-Waggressive-loop-optimizations]
        sprintf(extra, "%s%02X ", extra, pEfuseHal->fakeEfuseInitMap[i+j]);
                                                                    ^
   drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:5830:3: note: containing loop
      for (i = 0; i < EFUSE_MAP_SIZE; i += 16) {
      ^
>> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:6042:69: warning: iteration 16u invokes undefined behavior [-Waggressive-loop-optimizations]
        sprintf(extra, "%s %02X", extra, pEfuseHal->fakeEfuseModifiedMap[i+j]);
                                                                        ^
   drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:6036:3: note: containing loop
      for (i = 0; i < EFUSE_MAP_SIZE; i += 16) {
      ^

The problem is due to improper settings for some of the EFUSE_XXX defines such that
EFUSE_MAP_SIZE was larger than the sizes of the marked arrays. Thanks to
Fengguang Wu for helping me understand the root cause.

Reported-by: Fengguang Wu 
Signed-off-by: Larry Finger 
Cc: Fengguang Wu 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8188eu: Remove duplicate incusion in drv_types.h

2013-08-28T22:17:35+00:00

wlan_bssdef.h was included twice.

Signed-off-by: Sachin Kamat 
Acked-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8188eu: Include version.h in usb_ops.h

2013-08-28T22:17:35+00:00

Include version.h header file as detected by versioncheck.

Signed-off-by: Sachin Kamat 
Acked-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8188eu: Remove version.h inclusion in osdep_service.h

2013-08-28T22:17:35+00:00

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat 
Acked-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Fix build error with random configuration

2013-08-28T00:00:46+00:00

The kbuild test robot reports the following error:

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e4a745f9519ef2bbb9d75212ae1cca7582d76266
commit: b63c05394f3fe9ae547e1fa9df30f1ba0bcdabb4 [7011/7939] staging: r8188eu: Turn on build of new driver
config: x86_64-randconfig-x0-0828 (attached as .config)

All error/warnings:

   drivers/staging/rtl8188eu/core/rtw_p2p.c: In function 'go_add_group_info_attr':
>> drivers/staging/rtl8188eu/core/rtw_p2p.c:70:11: error: 'struct sta_info' has no member named 'is_p2p_device'
      if (psta->is_p2p_device) {

This and the following errors were caused by an incorrect nesting of
conditional compilation directives.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Fix build errors for allyesconfig

2013-08-25T17:21:01+00:00

This driver has some global names that are the same as found in
driver r8712. Fix the allyesconfig build errors by changing the
names of those routines.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: r8188eu: Add files for new driver - part 31

2013-08-22T17:20:31+00:00

This commit adds files include/sta_info.h, include/usb_hal.h,
include/usb_ops.h, include/usb_ops_linux.h, include/usb_osintf.h,
include/usb_vendor_req.h, include/wifi.h, include/wlan_bssdef.h,
and include/xmit_osdep.h.

The commit also deleted include/autoconf.h, which is no longer needed.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman