linux.git/drivers/staging/p9auth, branch v2.6.31

staging: p9auth: prevent some oopses and memory leaks

2009-06-19T18:00:54+00:00

Before all testcases, do:
	mknod /dev/caphash c 253 0
	mknod /dev/capuse c 253 1

This patch does the following:

1. caphash write of > CAP_NODE_SIZE bytes overruns node_ptr->data
	(test: cat /etc/mime.types > /dev/caphash)
2. make sure we don't dereference a NULL cap_devices[0].head
	(test: cat serge@root@abab > /dev/capuse)
3. don't let strlen dereference a NULL target_user etc
	(test: echo ab > /dev/capuse)
4. Don't leak a bunch of memory in cap_write().  Note that
   technically node_ptr is not needed for the capuse write case.
   As a result I have a much more extensive patch splitting up
   cap_write(), but I thought a smaller patch that is easier to test
   and verify would be a better start.  To test:
	cnt=0
	while [ 1 ]; do
		echo /etc/mime.types > /dev/capuse
		if [ $((cnt%25)) -eq 0 ]; then
			head -2 /proc/meminfo
		fi
		cnt=$((cnt+1))
		sleep 0.3
	done
   Without this patch, it MemFree steadily drops.  With the patch,
   it does not.

I have *not* tested this driver (with or without these patches)
with factotum or anything - only using the tests described above.

Signed-off-by: Serge E. Hallyn 
Signed-off-by: Greg Kroah-Hartman

Staging: p9auth: clean up #includes

2009-04-03T21:54:24+00:00

Not all of these files needed to be included, clean up the list.

Cc: Ashwin Ganti 
Signed-off-by: Greg Kroah-Hartman

Staging: p9auth: use kzalloc

2009-04-03T21:54:24+00:00

It's nicer than doing kmalloc/memset.

Also check the return value of all allocations, one was previously not
being checked properly.

Cc: Ashwin Ganti 
Signed-off-by: Greg Kroah-Hartman

Staging: p9auth: fix up sparse warnings

2009-04-03T21:54:23+00:00

Everything needs to be static, as sparse complains and you don't want to
polute the global kernel symbol namespace.  So mark everything as such
and move one function around to prevent a forward declaration from being
needed.

Cc: Ashwin Ganti 
Signed-off-by: Greg Kroah-Hartman

Staging: p9auth: fix up codingstyle issues

2009-04-03T21:54:23+00:00

This fixes up a number of scripts/codingstyle.pl warnings and errors

Cc: Ashwin Ganti 
Signed-off-by: Greg Kroah-Hartman

Staging: p9auth: remove unneeded header file

2009-04-03T21:54:23+00:00

The p9auth.h file is not needed, move the stuff into p9auth.c file and
delete it.

Cc: Ashwin Ganti 
Signed-off-by: Greg Kroah-Hartman

Staging: p9auth: fix dependency/build error

2009-04-03T21:54:23+00:00

Fix p9auth dependency/build failure.  It needs to depend on
CRYPTO.

p9auth.c:(.text+0x107297): undefined reference to `crypto_alloc_base'
p9auth.c:(.text+0x1073d4): undefined reference to `crypto_destroy_tfm'

Signed-off-by: Randy Dunlap 
Cc: Ashwin Ganti 
Signed-off-by: Greg Kroah-Hartman

Staging: p9auth: add to the kernel build

2009-04-03T21:54:23+00:00

This adds the p9auth code to the kernel build

Cc: Ashwin Ganti 
Signed-off-by: Greg Kroah-Hartman

Staging: p9auth: fix credential logic

2009-04-03T21:54:23+00:00

current->uid is no longer allowed in the 2.6.29 kernel, so use
the proper credential api to be able to alter the uid and euid values.

Note, this now builds properly, hopefully still works properly, would be
good for someone to test it out...

Cc: Ashwin Ganti 
Signed-off-by: Greg Kroah-Hartman

Staging: add p9auth driver

2009-04-03T21:54:23+00:00

This is a driver that adds Plan 9 style capability device
implementation.

From: Ashwin Ganti 
Signed-off-by: Greg Kroah-Hartman