linux.git/drivers/staging/most, branch v7.2-rc2

staging: most: video: avoid double free on video register failure

2026-05-21T10:42:38+00:00

comp_register_videodev() allocates a video_device with
video_device_alloc() and releases it if video_register_device() fails.

This can double free the video_device when __video_register_device()
reaches device_register() and that call fails:

  video_register_device()
    -> __video_register_device()
       -> device_register() fails
          -> put_device(&vdev->dev)
             -> v4l2_device_release()
                -> vdev->release(vdev)
                   -> video_device_release(vdev)

  comp_register_videodev()
    -> video_device_release(mdev->vdev)

Use video_device_release_empty() while registering the device so that
registration failure paths do not free mdev->vdev through vdev->release().
comp_register_videodev() then releases mdev->vdev exactly once on failure.
Restore video_device_release() after successful registration so the
registered device keeps its normal lifetime handling.

This issue was found by a static analysis tool I am developing.

Fixes: eab231c0398a ("staging: most: v4l2-aim: remove unnecessary label err_vbi_dev")
Signed-off-by: Guangshuo Li 
Link: https://patch.msgid.link/20260517111218.945796-1-lgs201920130244@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: net: replace pr_err with netdev_err

2026-05-11T07:58:02+00:00

Replace remaining pr_err() calls with netdev_err() where a net device
is available to provide better context in error messages.

Lines in skb_to_mep() are left as pr_err() since no net device
context is available there.

Signed-off-by: Maha Maryam Javaid 
Link: https://patch.msgid.link/20260508060438.20156-1-mahamaryamjavaid@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: remove filename from comment blocks

2026-05-04T14:17:58+00:00

Remove redundant filename references from top-of-file
comment blocks across dim2 source files to resolve
checkpatch.pl warnings.

The filename is already implied by the file path and
including it in comments can become outdated.

No functional changes.

Signed-off-by: Shyam Sunder Reddy Padira 
Link: https://patch.msgid.link/20260503104447.64657-1-shyamsunderreddypadira@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: video: remove filename from the top-of-file comment

2026-05-04T14:17:21+00:00

Remove the filename reference from top-of-file comment,
to resolve checkpatch.pl warning. The filename can become
outdated if the file is renamed.

No functional change.

Signed-off-by: Shyam Sunder Reddy Padira 
Link: https://patch.msgid.link/20260427175636.4605-1-shyamsunderreddypadira@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: video: remove redundant cleanup in comp_exit()

2026-04-27T11:01:51+00:00

most_deregister_component() already calls disconnect_channel() for
every linked channel via bus_for_each_dev() in core.c, which invokes
comp_disconnect_channel() to remove each entry from the video_devices
list and tear down the V4L2 device.

The manual cleanup loop in comp_exit() duplicates this work and is
guarded by a stale comment claiming that "mostcore currently doesn't
call disconnect_channel() for linked channels" — but the core has
since been fixed to do exactly that.

Remove the redundant manual cleanup loop, the outdated comment, and
the BUG_ON() assertion that checked for a condition that can no longer
occur.

Signed-off-by: Gabriel Rondon 
Link: https://patch.msgid.link/20260412222318.65045-1-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: net: remove filename from top-of-file comment

2026-04-27T11:01:51+00:00

Remove the filename reference from the
top-of-file comment block, to resolve a
checkpatch.pl warning. The filename comment is
not useful and can become outdated if the file is
renamed.

No functional changes.

Signed-off-by: Shyam Sunder Reddy Padira 
Link: https://patch.msgid.link/20260411095255.4890-1-shyamsunderreddypadira@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most/net: remove dead code from skb_to_mamac() and skb_to_mep()

2026-04-27T11:01:51+00:00

The overflow checks in skb_to_mamac() and skb_to_mep() are always false:

  mdp_len = (skb->len - ETH_HLEN) + MDP_HDR_LEN = skb->len + 2
  mep_len = skb->len + MEP_HDR_LEN = skb->len + 8

Remove these checks to clean up the code.

Signed-off-by: Hadi Chokr 
Link: https://patch.msgid.link/20260401125711.80822-1-hadichokr@icloud.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: remove unnecessary NULL check in try_start_dim_transfer()

2026-04-27T11:01:51+00:00

Remove the !hdm_ch check. Although hdm_ch is a function parameter,
it is already dereferenced on the preceding line to initialize
head (head = &hdm_ch->pending_list), so a NULL check after that
point is dead code.

Reported-by: Dan Carpenter 
Closes: https://lore.kernel.org/all/acwjEHyEYg0V3OyC@stanley.mountain
Signed-off-by: Gabriel Rondon 
Link: https://patch.msgid.link/20260401101038.24304-1-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: remove unnecessary NULL check in service_done_flag()

2026-04-27T11:01:51+00:00

Remove the !hdm_ch check. hdm_ch is derived from dev->hch + ch_idx
(pointer arithmetic on a struct member), so it can never be NULL.
Keep only the !hdm_ch->is_initialized check.

Reported-by: Dan Carpenter 
Closes: https://lore.kernel.org/all/acuoL4DRi0pmsQY1@stanley.mountain
Signed-off-by: Gabriel Rondon 
Link: https://patch.msgid.link/20260331164443.47682-1-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: replace BUG_ON() in poison_channel()

2026-03-31T08:46:39+00:00

Replace BUG_ON() range check on ch_idx with a return of -EINVAL.

BUG_ON() is deprecated as it crashes the entire kernel on assertion
failure (see Documentation/process/deprecated.rst).

Signed-off-by: Gabriel Rondon 
Link: https://patch.msgid.link/20260330182255.75241-6-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman