linux.git/drivers/staging/most, branch v5.1-rc2

staging: most: cdev: add missing check for cdev_add failure

2019-02-04T11:36:14+00:00

Currently the call to cdev_add is missing a check for failure. Fix this by
checking for failure and exiting via a new error path that ensures the
allocated comp_channel struct is kfree'd.

Detected by CoverityScan, CID#1462359 ("Unchecked return value")

Fixes: 9bc79bbcd0c5 ("Staging: most: add MOST driver's aim-cdev module")
Signed-off-by: Colin Ian King 
Signed-off-by: Greg Kroah-Hartman

staging: prefix header search paths with $(srctree)/

2019-02-04T11:30:27+00:00

Currently, the Kbuild core manipulates header search paths in a crazy
way [1].

To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
the search paths in the srctree. Some Makefiles are already written in
that way, but not all. The goal of this work is to make the notation
consistent, and finally get rid of the gross hacks.

Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
("kbuild: do not drop -I without parameter").

[1]: https://patchwork.kernel.org/patch/9632347/

Signed-off-by: Masahiro Yamada 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: replace snprintf with strscpy

2018-12-19T07:28:22+00:00

Using snprintf without a format specifier is potentially risky if
the string device_name contains format specifiers. Replace this with
the safer and more efficient strscpy.

Cleans up clang warning:
drivers/staging/most/sound/sound.c:673:41: warning: format string is not
a string literal (potentially insecure) [-Wformat-security]

Signed-off-by: Colin Ian King 
Signed-off-by: Greg Kroah-Hartman

staging: most: Documentation: add information to driver_usage file

2018-12-17T15:10:20+00:00

This patch updates driver_usage.txt file to reflect the latest changes
that this patch set introduces.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: remove channel number from ALSA card's long name

2018-12-17T15:10:20+00:00

Adding the channel number to the name of the sound card is wrong,
as the card does not represent a single streaming channel of the
MOST device.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: use static name for ALSA card

2018-12-17T15:10:20+00:00

This patch uses a static name for the sound card's short name and
long name. Having the card names configurable doesn't make sense
anymore, as the card represents the same physical hardware.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: rename variable

2018-12-17T15:10:20+00:00

Since the channels of a MOST device are now being represented as
individual PCM devices of one sound card, the variable card_name is not
suitable anymore to describe them. Therefore, this patch renames the
variable to device_name.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: correct label name

2018-12-17T15:10:20+00:00

This patch fixes the lable name that is used to jump to error
handling section of function audio_probe_channel() in case
something went wrong.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-17T15:10:20+00:00

This patch avoids that a sound card is created and registered with ALSA
every time a channel is being linked. Instead the channels are hooked on
the same card, which is registered not until the final link has been added
to the component. The string provided by user space that used to be the
card name becomes the PCM device name. The user space API to add a link is
being expanded by a "create" flag to trigger the registration.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: most: use format specifier "%s" in snprintf

2018-11-09T12:34:12+00:00

Passing string ch_data_type[i].name as the format specifier is
potentially hazardous because it could (although very unlikely to)
have a format specifier embedded in it causing issues when parsing
the non-existent arguments to these.  Follow best practice by using
the "%s" format string for the string.

Cleans up clang warning:
format string is not a string literal (potentially insecure) [-Wformat-security]

Fixes: e7f2b70fd3a9 ("staging: most: replace multiple if..else with table lookup")
Signed-off-by: Colin Ian King 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman