linux.git/drivers/staging/most/usb, branch v5.8

staging: most: usb: init return value in default path of switch/case expression

2020-05-29T10:35:59+00:00

This patch avoids returning an uninitialized value in the default
path of the switch expression.

Signed-off-by: Christian Gromm 
Reported-by: Dan Carpenter 
Link: https://lore.kernel.org/r/1590669703-20004-1-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman

staging: most: usb: use function sysfs_streq

2020-05-27T10:26:13+00:00

This patch replaces function strcmp() with sysfs_streq() to compare
strings provided via sysfs.

Signed-off-by: Christian Gromm 
Reported-by: Dan Carpenter 
Link: https://lore.kernel.org/r/1590570387-27069-11-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman

staging: most: usb: add missing put_device calls

2020-05-27T10:26:13+00:00

This patch adds the missing put_device() function calls to
properly free allocated resources and maintain reference counts.

Signed-off-by: Christian Gromm 
Reported-by: Dan Carpenter 
Link: https://lore.kernel.org/r/1590570387-27069-10-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman

staging: most: usb: use correct error codes

2020-05-27T10:26:13+00:00

This patch uses the -EINVAL return code where -EFAULT is wrongly being
used.

Signed-off-by: Christian Gromm 
Reported-by: Dan Carpenter 
Link: https://lore.kernel.org/r/1590570387-27069-9-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman

staging: most: usb: replace code to calculate array index

2020-05-27T10:26:12+00:00

This patch removes the expression that makes use of a priori knowledge
about channel numbers to calculate an array index.
The expression 'peer = 1 - channel' utilizes the fact that an USB interface
that operates on the asynchronous data of the Network only has two
endpoints. Hence, channel being 0 or 1. The replacement is more simple and
less confusing when reading the code.

Signed-off-by: Christian Gromm 
Reported-by: Dan Carpenter 
Link: https://lore.kernel.org/r/1590570387-27069-8-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman

staging: most: usb: don't use error path to exit function on success

2020-05-27T10:26:12+00:00

This patch makes it transparent whether the function is exiting
with an error or successful.

Signed-off-by: Christian Gromm 
Reported-by: Dan Carpenter 
Link: https://lore.kernel.org/r/1590570387-27069-7-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman

staging: most: usb: move allocation of URB out of critical section

2020-05-27T10:24:46+00:00

This patch puts the call to usb_alloc_urb() before the critical
section starts that is protected with the io_mutex lock. This is
to make the section as short as possible and to use the regular
GFP_KERNEL flag.

Signed-off-by: Christian Gromm 
Reported-by: Dan Carpenter 
Link: https://lore.kernel.org/r/1590570387-27069-6-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman

staging: most: usb: return 0 instead of variable

2020-05-27T10:24:46+00:00

This patch returns 0 instead of variable in case of invalid parameter
has been passed to function to increase readability.

Signed-off-by: Christian Gromm 
Reported-by: Dan Carpenter 
Link: https://lore.kernel.org/r/1590570387-27069-5-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman

staging: most: usb: change return value of function drci_rd_reg

2020-05-27T10:24:46+00:00

This patch makes function drci_rd_reg return 0 in case of success
and a negative number else. As no caller is evaluating the number
of bytes transferred by function usb_control_msg this information is
being omitted.

Signed-off-by: Christian Gromm 
Reported-by: Dan Carpenter 
Link: https://lore.kernel.org/r/1590570387-27069-4-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman

staging: most: usb: don't use expressions that might fail in a declaration

2020-05-27T10:24:45+00:00

This patch moves function calls that can fail out of the declararion block
of a function body. This is done to enhance readability.

Signed-off-by: Christian Gromm 
Reported-by: Dan Carpenter 
Link: https://lore.kernel.org/r/1590570387-27069-3-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman