linux.git/drivers/staging/mei, branch v3.3

staging/mei: add watchdog device registration wrappers

2011-12-22T21:46:16+00:00

add mei_watchdog_register/unregister wrappers for
cleaner  encapsulation

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

staging/mei: code style - cleanup blanks

2011-12-14T00:22:18+00:00

1. Remove redundant blanks
2. Straighten code lines that don't go over 80 characters

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

staging/mei: remove outdated comment about setting iamthif_mtu

2011-12-14T00:22:18+00:00

iamthif_mtu doesn't have default value anymore it
is always supplied by the ME firmware

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

staging: mei: updating mei driver documentation

2011-12-08T23:00:45+00:00

The following changes were made in the document:

1. Update URLs to working links
2. remove old information about module parameters
3. Add IOCTL information.
4. cleanups and fix spelling
5. driver changed from character device to misc character device

Signed-off-by: Oren Weil 
Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

staging/mei: fix failure for multiple mei clients connection

2011-12-08T23:00:44+00:00

The irq handler processes queued mei clients connect requests, which were
not transferred to the device in ioctl context due to unavailability
of the write buffer.

The handler may transfer the connection request only if there is
no other ongoing  requests for the same mei id.
This condition was implemented inversely which depending on
the write buffer availability lead to seemingly random
failures during connection attempts.

Cc: Oren Weil 
Signed-off-by: Natalia Ovsyanikov 
Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

staging/mei: Don't check if loop cursor is null

2011-12-08T23:00:44+00:00

list_for_each_entry_safe(pos, next, &head, list)
	if (pos) {
		....
	}

This check isn't needed.  The list cursor in a list_for_each()
loop is always a valid pointer

Cc: Oren Weil 
Reported-by: Dan Carpenter 
Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

staging/mei: don't check if list is empty before looping

2011-11-27T21:46:18+00:00

1. No need to check if a list is empty before list_for_each_ looping as
this is already checked by loop stopping conditional.

The side effect is reduced indentation depth
from:
	if (!list_empty)
		list_for_each()
to:
	list_for_each()

2. drop cb_ prefix from cl_pos, cl_next variables used in list_for_each
loops. The code is more compact and readable

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

staging/mei: remove status member of mei_io_list

2011-11-27T21:46:17+00:00

status was never writen

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

staging/mei: remove BUG_ON for testing of the response buffer size overflow

2011-11-27T21:46:17+00:00

We can remove BUG_ON in mei_irq_thread_read_client_message()
as the testing for response buffer size overflow has already
graceful handling in place.

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

staging/mei: fix check for allocating host client id

2011-11-27T00:05:14+00:00

MEI_CLIENTS_MAX is 255 and host_client_id is u8 therefore
for check to work we need to first assign the return value
of find_first_zero_bit to unsigned long variable

Fix warning

drivers/staging/mei/main.c: In function mei_open
drivers/staging/mei/main.c:260:2: warning: comparison is always false due to limited range of data type

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman