linux.git/drivers/staging/media, branch v5.19

media: hantro: Enable HOLD_CAPTURE_BUF for H.264

2022-05-17T08:11:19+00:00

This is needed to optimize field decoding. Each field will be
decoded into the same capture buffer. To be able to queue multiple
buffers, we need to be able to ask the driver to hold the capture
buffer.

Signed-off-by: Nicolas Dufresne 
Reviewed-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: hantro: Add H.264 field decoding support

2022-05-17T08:10:46+00:00

This adds the required code to support field decoding. While most of
the code is derived from Rockchip and VSI reference code, the
reduction of the reference list to 16 entries was found by
trial and errors. The list consists of all the references with the
opposite field parity.

The strategy is to deduplicate the reference picture that points
to the same storage (same index). The choice of opposite parity has
been made to keep the other field of the current field pair in the
list. This method may not be robust if a field was lost.

[hverkuil: fix typos in the comment before deduplicate_reflist()]
[hverkuil: document new cur_poc field]

Signed-off-by: Jonas Karlman 
Signed-off-by: Nicolas Dufresne 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: hantro: h264: Make dpb entry management more robust

2022-05-17T08:09:48+00:00

The driver maintains stable slot locations for reference pictures. This
change makes the code more robust by using the reference_ts as key and
by marking all entries invalid right from the start.

Signed-off-by: Jonas Karlman 
Signed-off-by: Nicolas Dufresne 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: hantro: Stop using H.264 parameter pic_num

2022-05-17T08:09:10+00:00

The hardware expects FrameNumWrap or long_term_frame_idx. Picture
numbers are per field, and are mostly used during the memory
management process, which is done in userland. This fixes two
ITU conformance tests:

  - MR6_BT_B
  - MR8_BT_B

Signed-off-by: Nicolas Dufresne 
Reviewed-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: rkvdec: Enable capture buffer holding for H264

2022-05-17T08:08:52+00:00

In order to support interlaced video decoding, the driver must
allow holding the capture buffer so that the second field can
be decoded into it.

Signed-off-by: Nicolas Dufresne 
Reviewed-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: rkvdec-h264: Add field decoding support

2022-05-17T08:07:49+00:00

This makes use of the new feature in the reference builder to program
up to 32 references when doing field decoding. It also signals the
parity (top or bottom) of the field to the hardware.

Signed-off-by: Nicolas Dufresne 
Reviewed-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: rkvdec: Ensure decoded resolution fit coded resolution

2022-05-17T08:07:08+00:00

Ensure decoded CAPTURE buffer resolution is larger or equal to the coded
OUTPUT buffer resolution.

Signed-off-by: Jonas Karlman 
Signed-off-by: Nicolas Dufresne 
Reviewed-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: rkvdec: h264: Fix reference frame_num wrap for second field

2022-05-17T08:06:49+00:00

When decoding the second field in a complementary field pair the second
field is sharing the same frame_num with the first field.

Currently the frame_num for the first field is wrapped when it matches the
field being decoded, this caused issues decoding the second field in a
complementary field pair.

Fix this by using inclusive comparison: 'less than or equal'.

Signed-off-by: Jonas Karlman 
Signed-off-by: Nicolas Dufresne 
Reviewed-by: Ezequiel Garcia 
Reviewed-by: Sebastian Fricke 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: rkvdec: h264: Validate and use pic width and height in mbs

2022-05-17T08:06:31+00:00

The width and height in macroblocks is currently configured based on OUTPUT
buffer resolution, this works for frame pictures but can cause issues for
field pictures.

When frame_mbs_only_flag is 0 the height in mbs should be height of
the field instead of height of frame.

Validate pic_width_in_mbs_minus1 and pic_height_in_map_units_minus1
against OUTPUT buffer resolution and use these values to configure HW.
The validation is happening in both try_ctrt() and start() since it is
otherwise possible to trick the driver during initialization by changing
the OUTPUT format after having set a valid control.

[hverkuil: when -> When (first word in a comment block)]

Signed-off-by: Jonas Karlman 
Signed-off-by: Nicolas Dufresne 
Reviewed-by: Ezequiel Garcia 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: rkvdec: Move H264 SPS validation in rkvdec-h264

2022-05-17T08:06:08+00:00

No functional change, this moves H264 specific validation into the H264
specific code. This is in preparation of improving this validation and
reusing it when VIDIOC_STREAMON is called.

Signed-off-by: Nicolas Dufresne 
Reviewed-by: Ezequiel Garcia 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab