linux.git/drivers/staging/media/lirc, branch v4.15

[media] media: lirc_dev: merge struct irctl into struct lirc_dev

2017-10-04T17:53:07+00:00

The use of two separate structs (lirc_dev aka lirc_driver and irctl) makes
it much harder to follow the proper lifetime of the various structs and
necessitates hacks such as keeping a copy of struct lirc_dev inside
struct irctl.

Merging the two structs means that lirc_dev can properly manage the
lifetime of the resulting struct and simplifies the code at the same time.

[mchehab@s-opensource.com: fix merge conflict]
Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: lirc_zilog: use a dynamically allocated lirc_dev

2017-10-04T17:24:17+00:00

lirc_zilog currently embeds a struct lirc_dev in its own struct IR,
but subsequent patches will make the lifetime of struct lirc_dev
dynamic (i.e.  it will be free():d once lirc_dev is sure there are
no users of the struct).

Therefore, change lirc_zilog to use a pointer to a dynamically
allocated struct lirc_dev.

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: lirc_zilog: add a pointer to the parent device to struct IR

2017-10-04T17:23:22+00:00

lirc_zilog stashes a pointer to the parent device in struct lirc_dev
and uses it for logging. It makes more sense to let lirc_zilog keep
track of that pointer in its own struct (this is in preparation for
subsequent patches which will remodel struct lirc_dev).

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: rename struct lirc_driver to struct lirc_dev

2017-10-04T17:13:08+00:00

This is in preparation for the later patches which do away with
struct irctl entirely.

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: lirc_dev: make chunk_size and buffer_size mandatory

2017-10-04T16:53:32+00:00

Make setting chunk_size and buffer_size mandatory for drivers which
expect lirc_dev to allocate the lirc_buffer (i.e. ir-lirc-codec) and
don't set them in lirc-zilog (which creates its own buffer).

Also remove an unnecessary copy of chunk_size in struct irctl (the
same information is already available from struct lirc_buffer).

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: lirc_dev: make better use of file->private_data

2017-10-04T16:52:12+00:00

By making better use of file->private_data in lirc_dev we can avoid
digging around in the irctls[] array, thereby simplifying the code.

External drivers need to use lirc_get_pdata() instead of mucking around
in file->private_data.

The newly introduced lirc_init_pdata() function isn't very elegant, but
it's a stopgap measure which can be removed once lirc_zilog is converted
to rc-core.

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: lirc_dev: remove support for manually specifying minor number

2017-10-04T16:50:42+00:00

All users of lirc_register_driver() uses dynamic minor allocation,
therefore we can remove the ability to explicitly request a given number.

This changes the function prototype of lirc_unregister_driver() to also
take a struct lirc_driver pointer as the sole argument.

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: lirc_zilog: driver only sends LIRCCODE

2017-08-20T13:51:01+00:00

This driver cannot send pulse, it only accepts driver-dependent codes.

Cc:  # v3.2
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

media: lirc_zilog: Clean up lirc zilog error codes

2017-08-20T13:47:28+00:00

According the coding style guidelines, the ENOSYS error code must be
returned in case of a non existent system call. This code has been
replaced with the ENOTTY error code indicating a missing functionality.

Signed-off-by: Yves Lemée 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] staging: remove todo and replace with lirc_zilog todo

2017-06-06T12:18:08+00:00

The lirc_zilog driver is the last remaining lirc driver, so the existing
todo is no longer relevant.

Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab