linux.git/drivers/staging/media/atomisp, branch v5.17

media: atomisp: Do not define input_system_cfg2400_t twice

2022-01-10T14:54:13+00:00

When CONFIG_VIDEO_ATOMISP_ISP2401 is disabled, clang warns:

./drivers/staging/media/atomisp//pci/isp2400_input_system_local.h:32:40:
error: redefinition of typedef 'input_system_cfg2400_t' is a C11 feature
[-Werror,-Wtypedef-redefinition]
typedef struct input_system_cfg2400_s           input_system_cfg2400_t;
                                                ^
./drivers/staging/media/atomisp//pci/input_system_local.h:22:40: note:
previous definition is here
typedef struct input_system_cfg2400_s           input_system_cfg2400_t;
                                                ^
1 error generated.

input_system_cfg2400_t's typedef was copied from
isp2400_input_system_local.h to input_system_local.h, rather than moved.
Remove the one in isp2400_input_system_local.h so that there is no more
warning, which can break the build under -Werror.

Link: https://github.com/ClangBuiltLinux/linux/issues/1557

Link: https://lore.kernel.org/linux-media/20211227164243.2329724-1-nathan@kernel.org
Fixes: 4005ecee616a ("media: atomisp: shift some structs from input_system_local")
Reported-by: kernel test robot 
Signed-off-by: Nathan Chancellor 
Signed-off-by: Mauro Carvalho Chehab

media: atomisp: fix "variable dereferenced before check 'asd'"

2021-12-07T10:29:57+00:00

There are two occurrences where the variable 'asd' is dereferenced
before check. Fix this issue by using the variable after the check.

Link: https://lore.kernel.org/linux-media/20211122074122.GA6581@kili/

Link: https://lore.kernel.org/linux-media/20211201141904.47231-1-kitakar@gmail.com
Reported-by: Dan Carpenter 
Signed-off-by: Tsuchiya Yuto 
Signed-off-by: Mauro Carvalho Chehab

media: atomisp: make array idx_map static const

2021-12-07T10:29:56+00:00

Don't populate the array idx_map on the stack but instead make it
static const. Also makes the object code smaller by 16 bytes.

Link: https://lore.kernel.org/linux-media/20211129230626.549090-1-colin.i.king@gmail.com
Signed-off-by: Colin Ian King 
Signed-off-by: Mauro Carvalho Chehab

media: atomisp: cleanup qbuf logic

2021-11-17T19:40:19+00:00

The logic there is meant to be used by newer firmwares.
clean it up, in order to make compatible with the chosen
firmware version.

Signed-off-by: Mauro Carvalho Chehab

media: atomisp: add YUVPP at __atomisp_get_pipe() logic

2021-11-17T19:38:39+00:00

Aligns it which the Intel Aero firmware.

Signed-off-by: Mauro Carvalho Chehab

media: atomisp: frame.c: drop a now-unused function

2021-11-17T19:38:03+00:00

ia_css_frame_find_crop_resolution() is not used anymore.

So, remove it.

Signed-off-by: Mauro Carvalho Chehab

media: atomisp: pipe_binarydesc: drop logic incompatible with firmware

2021-11-17T19:37:29+00:00

As we're using this firmware for ISP2401:
	https://github.com/intel-aero/meta-intel-aero-base/blob/master/recipes-kernel/linux/linux-yocto/shisp_2401a0_v21.bin

Revert some changes that are not compatible with it, making
the code close to the Intel Aero one.

Signed-off-by: Mauro Carvalho Chehab

media: atomisp: binary.c: drop logic incompatible with firmware

2021-11-17T19:36:42+00:00

As we're using this firmware for ISP2401:
	https://github.com/intel-aero/meta-intel-aero-base/blob/master/recipes-kernel/linux/linux-yocto/shisp_2401a0_v21.bin

It makes no sense to try to select a non-existing binary
inside the firmware. So, revert it to reflect the Intel Aero
device driver.

Signed-off-by: Mauro Carvalho Chehab

media: atomisp: simplify binary.c

2021-11-17T19:36:08+00:00

Signed-off-by: Mauro Carvalho Chehab

media: atomisp: get rid of set pipe version custom ctrl

2021-11-17T19:35:46+00:00

It doesn't make sense to have a control for that. Besides that,
the Intel Aero implementation doesn't have, which means that
even the custom control is not used in practice, at least
outside Android.

So, get rid of it.

Signed-off-by: Mauro Carvalho Chehab