linux.git/drivers/staging/media/atomisp, branch v5.13

media: atomisp: fix a typo

2021-04-06T08:26:54+00:00

s/Sysytem/System/

Signed-off-by: Bhaskar Chowdhury 
Acked-by: Randy Dunlap 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: atomisp: remove duplicate include in sh_css

2021-03-23T16:24:42+00:00

'ia_css_isys.h' included in 'sh_css.c' is duplicated.
It is also included in the 30th line.

Link: https://lore.kernel.org/linux-media/20210306121104.218696-1-zhang.yunkai@zte.com.cn
Signed-off-by: Zhang Yunkai 
Signed-off-by: Mauro Carvalho Chehab

media: staging: atomisp: reduce kernel stack usage

2021-03-23T15:55:52+00:00

The atomisp_set_fmt() function has multiple copies of the large
v4l2_format structure on its stack, resulting in a warning about
excessive stack usage in some rare randconfig builds.

drivers/staging/media/atomisp/pci/atomisp_cmd.c:5600:5: error: stack frame size of 1084 bytes in function 'atomisp_set_fmt' [-Werror,-Wframe-larger-than=]

Of this structure, only three members in the 'fmt.pix' member are
used, so simplify it by using the smaller v4l2_pix_format structure
directly. This reduces the stack usage to 612 bytes, and it could
be reduced further by only storing the three members that are used.

Link: https://lore.kernel.org/linux-media/20210226140524.3478346-1-arnd@kernel.org
Signed-off-by: Arnd Bergmann 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Mauro Carvalho Chehab

media: staging: media/atomisp: don't compile unused code

2021-03-23T15:49:25+00:00

currently the functions defined in ibuf_ctrl_rmgr.c file are only
used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected
so dont't compile it when not needed, also fixes some sparse warnings

Link: https://lore.kernel.org/linux-media/YDEZu3oniT/vUMMY@karthik-strix-linux.karthek.com
Signed-off-by: karthik alapati 
Signed-off-by: Mauro Carvalho Chehab

media: atomisp: do not free kmalloc memory by vfree

2021-03-23T15:47:50+00:00

fw_minibuffer[i].buffer is allocated by kmalloc in sh_css_load_blob_info
and by vmalloc in setup_binary. So use kvfree to decide which of those
allocators to use for freeing.

Also remove the useless cast.

Link: https://lore.kernel.org/linux-media/20210219101216.28406-1-jslaby@suse.cz
Signed-off-by: Jiri Slaby 
Signed-off-by: Mauro Carvalho Chehab

media: atomisp: auto-select VIDEO_V4L2_SUBDEV_API

2021-03-23T08:01:09+00:00

VIDEO_ATOMISP depends on VIDEO_V4L2_SUBDEV_API, if VIDEO_V4L2_SUBDEV_API
 is not selected, it will cause compilation error

drivers/staging/media/atomisp/pci/atomisp_cmd.c:6079:42: error:
 ‘struct v4l2_subdev_fh’ has no member named ‘pad’ atomisp_subdev_set_ffmt
(&asd->subdev, fh.pad, V4L2_SUBDEV_FORMAT_ACTIVE,

add auto select VIDEO_V4L2_SUBDEV_API if VIDEO_ATOMISP is selected

Link: https://lore.kernel.org/linux-media/20210210033830.961086-1-ztong0001@gmail.com
Signed-off-by: Tong Zhang 
Signed-off-by: Mauro Carvalho Chehab

media: atomisp: remove redundant NULL check

2021-03-23T07:52:51+00:00

Fix below warnings reported by coccicheck:
./drivers/staging/media/atomisp/pci/atomisp_cmd.c:4269:2-8: WARNING:
NULL check before some freeing functions is not needed.
./drivers/staging/media/atomisp/pci/atomisp_cmd.c:4626:2-8: WARNING:
NULL check before some freeing functions is not needed.

Link: https://lore.kernel.org/linux-media/1611220312-89384-3-git-send-email-abaci-bugfix@linux.alibaba.com
Reported-by: Abaci Robot 
Signed-off-by: Yang Li 
Signed-off-by: Mauro Carvalho Chehab

media: atomisp: remove redundant NULL check

2021-03-23T07:52:07+00:00

Fix below warnings reported by coccicheck:
./drivers/staging/media/atomisp/pci/sh_css_params.c:1575:2-8: WARNING:
NULL check before some freeing functions is not needed.
./drivers/staging/media/atomisp/pci/sh_css_params.c:3006:2-8: WARNING:
NULL check before some freeing functions is not needed.

Link: https://lore.kernel.org/linux-media/1611217731-56866-1-git-send-email-abaci-bugfix@linux.alibaba.com
Reported-by: Abaci Robot 
Signed-off-by: Yang Li 
Reviewed-by: Robert Foss 
Signed-off-by: Mauro Carvalho Chehab

media: atomisp: fix Wvisiblity warning

2021-03-23T07:44:08+00:00

Some randconfig builds include ia_css_firmware.h without first
including linux/device.h:

In file included from atomisp/pci/mmu/sh_mmu_mrfld.c:23:
In file included from atomisp/pci/atomisp_compat.h:22:
In file included from atomisp/pci/atomisp_compat_css20.h:24:
In file included from atomisp/pci/ia_css.h:28:
In file included from atomisp/pci/ia_css_control.h:25:
drivers/staging/media/atomisp//pci/ia_css_firmware.h:52:29: error: declaration of 'struct device' will not be visible outside of this function [-Werror,-Wvisibility]

Add a forward declaration to avoid the warning.

Link: https://lore.kernel.org/linux-media/20210108082337.2305938-1-arnd@kernel.org
Signed-off-by: Arnd Bergmann 
Signed-off-by: Mauro Carvalho Chehab

media: atomisp: ov2722: remove unnecessary debug print

2021-03-23T07:41:42+00:00

checkpatch.pl emits the following warning:

WARNING: Prefer using '"%s...", __func__' to using 'ov2722_remove', this function's name, in a string
+	dev_dbg(&client->dev, "ov2722_remove...\n");

This is just a "trace" call and therefore should be removed entirely;
ftrace should be used instead.

Link: https://lore.kernel.org/linux-media/20210106181158.2270-1-fil.kolev@gmail.com
Signed-off-by: Filip Kolev 
Signed-off-by: Mauro Carvalho Chehab