linux.git/drivers/staging/line6, branch v3.0 Linux kernel source tree drivers/staging/line6/driver.c: Drop unneeded put functions. 2011-05-17T20:31:32+00:00 Julia Lawall julia@diku.dk 2011-05-16T12:24:57+00:00 c5cbebf87f49dfb4f4ccdf86f6c24b4912a3061f This seems to be the result of patches ab366c1a and 1027f476 crossing each other. Patch ab366c1a adds calls to usb_put_intf and usb_put_dev at the end of the function line6_probe, in the error handling code, while patch 1027f476 moves the calls to the corresponding get function from the beginning to the end of line6_probe, making the calls to put in the error handling code unnecessary. // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
This seems to be the result of patches ab366c1a and 1027f476 crossing each
other.  Patch ab366c1a adds calls to usb_put_intf and usb_put_dev at the
end of the function line6_probe, in the error handling code, while patch
1027f476 moves the calls to the corresponding get function from the
beginning to the end of line6_probe, making the calls to put in the error
handling code unnecessary.

// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
staging: line6: Remove NULL check before kfree 2011-03-14T18:57:33+00:00 Ilia Mirkin imirkin@alum.mit.edu 2011-03-13T05:29:02+00:00 43c04d42c3c5a23e2aff330d4d361c733118df80 This patch was generated by the following semantic patch: // <smpl> @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; // </smpl> Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);

@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
staging/line6: Fix sparse warning 'Using plain integer as NULL pointer' 2010-12-08T22:31:01+00:00 Peter Huewe peterhuewe@gmx.de 2010-12-07T22:38:02+00:00 597a1e7cccc9a5a0c47629267ac4b23bf8654578 This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0s with NULL. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
This patch fixes the warning generated by sparse: "Using plain integer
as NULL pointer" by replacing the offending 0s with NULL.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: line6: fix up my fixup for some sysfs attribute permissions 2010-11-18T19:27:20+00:00 Greg Kroah-Hartman gregkh@suse.de 2010-11-18T19:21:04+00:00 a3a972a053010bfd61c13cfa4ce688d4eebd9a19 They should be writable by root, not readable. Doh, stupid me with the wrong flags. Reported-by: Jonathan Cameron <jic23@cam.ac.uk> Cc: Markus Grabner <grabner@icg.tugraz.at> Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
They should be writable by root, not readable.
Doh, stupid me with the wrong flags.

Reported-by: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: line6: fix up some sysfs attribute permissions 2010-11-16T19:23:33+00:00 Greg Kroah-Hartman gregkh@suse.de 2010-11-16T19:23:33+00:00 2018845b6a169f75341f8e68ad1089cb6697cf24 They should not be writable by any user Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: Markus Grabner <grabner@icg.tugraz.at> Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
They should not be writable by any user

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: line6: Makefile: replace the use of <module>-objs with <module>-y 2010-10-08T14:23:47+00:00 Tracey Dent tdent48227@gmail.com 2010-10-08T00:01:36+00:00 1954cbf0bfb22176119e0460098cd59f2b8e645d Changed <module>-objs to <module>-y in Makefile. Signed-off-by: Tracey Dent <tdent48227@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: line6: minor coding style cleanups 2010-09-21T23:58:00+00:00 Greg Kroah-Hartman gregkh@suse.de 2010-09-21T23:58:00+00:00 027360c5644b59d99db30e3515a8ec72350207b9 This fixes up all of the remaining coding style issues that make any sense to make in the line6 driver. Cc: Markus Grabner <grabner@icg.tugraz.at> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
This fixes up all of the remaining coding style issues that
make any sense to make in the line6 driver.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
staging: line6: remove unneeded EXPORT_SYMBOL() usage 2010-09-21T23:18:13+00:00 Greg Kroah-Hartman gregkh@suse.de 2010-09-21T23:18:13+00:00 79be7254ebd2fb6d5f91b4b8e5d12cfe4fd7ecd7 These symbols don't need to be exported as nothing uses them, so don't. Cc: Markus Grabner <grabner@icg.tugraz.at> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
These symbols don't need to be exported as nothing uses them, so don't.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: line6: workaround for null pointer bug 2010-09-21T00:04:35+00:00 Markus Grabner grabner@icg.tugraz.at 2010-09-17T21:33:25+00:00 c7fcf25525b3cd6559f882837bfa76d04a80f8a6 Signed-off-by: Markus Grabner <grabner@icg.tugraz.at> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Signed-off-by: Markus Grabner <grabner@icg.tugraz.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: line6: another upstream sync 2010-08-31T22:28:16+00:00 Markus Grabner grabner@icg.tugraz.at 2010-08-22T23:08:25+00:00 e1a164d7a3e05aae15eb603ee8f1b77446480a3b Everything should be in sync now. Signed-off-by: Markus Grabner <grabner@icg.tugraz.at> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Everything should be in sync now.

Signed-off-by: Markus Grabner <grabner@icg.tugraz.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>