linux.git/drivers/staging/line6/driver.c, branch v3.13

Staging: line6: Fix Sparse warning of restricted __le16 degrades to integer

2013-10-28T03:43:46+00:00

This patch fixes the following sparse warning in driver.c-
warning: restricted __le16 degrades to integer

Signed-off-by: Rashika Kheria 
Signed-off-by: Greg Kroah-Hartman

Staging: line6: replacing -EINVAL with retval in driver.c

2013-10-19T21:51:06+00:00

drivers/staging/line6/driver.c:208 line6_send_raw_message_async_part()
info: why not propagate 'retval' from usb_submit_urb() instead of (-22)?

Signed-off-by: Ashvini Varatharaj 
Reviewed-by: Josh Triplett 
Signed-off-by: Greg Kroah-Hartman

staging: line6: use default sysfs attribute macros

2013-08-24T17:36:49+00:00

Move to use the DEVICE_ATTR_RW/RO macros, making it easier to audit the
sysfs file permissions, and get rid of the "empty" callback for
read-only files, saving lines of code.

Cc: Stefan Hajnoczi 
Cc: Laurent Navet 
Cc: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

staging: Remove unnecessary OOM messages

2013-02-11T18:10:33+00:00

alloc failures already get standardized OOM
messages and a dump_stack.

For the affected mallocs around these OOM messages:

Converted kzallocs with multiplies to kcalloc.
Converted kmallocs with multiplies to kmalloc_array.
Converted a kmalloc/strlen/strncpy to kstrdup.
Moved a spin_lock below a removed OOM message and
removed a now unnecessary spin_unlock.
Neatened alignment and whitespace.

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

staging: line6: drop CONFIG_LINE6_USB_DUMP_PCM

2013-01-20T23:56:59+00:00

The CONFIG_LINE6_USB_DUMP_PCM config option prints a hexdump of PCM
audio data as URBs are sent and received.  The usbmon feature should be
used instead of manually dumping PCM URBs.  There are a few advantages
to using usbmon:

 * Can be turned on/off at runtime
 * Provides full USB-level traffic
 * tcpdump and wireshark support for powerful analysis
 * No driver-specific code is required

This is the last user of line6_write_hexdump() so we drop it too.

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: rename MidiBuffer to avoid CamelCase

2013-01-12T00:40:50+00:00

Fix checkpatch.pl warnings related to MidiBuffer:

  WARNING: Avoid CamelCase: 
  #947: FILE: staging/line6/driver.c:363:
  +       struct MidiBuffer *mb = &line6->line6midi->midibuf_in;

Rename MidiBuffer to midi_buffer.

Note that "midibuf" would be another good name but sound/oss/midibuf.c
already uses it for a different concept.  Avoid possible confusion by
using "midi_buffer" instead.

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: wrap comment to 80 chars in driver.c

2013-01-12T00:40:50+00:00

Fix the following checkpatch.pl warning:

  WARNING: line over 80 characters
  #1107: FILE: staging/line6/driver.c:523:
  +       /* Wait for data length. We'll get a couple of 0xff until length arrives. */

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: delete an unused function

2013-01-07T22:00:35+00:00

line6_send_sysex_message_async() isn't called from anywhere.

Signed-off-by: Dan Carpenter 
Reviewed-by: Stefan Hajnoczi 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

staging: line6: Use kmemdup rather than duplicating its implementation

2013-01-07T22:00:35+00:00

staging: line6: driver.c
 The semantic patch that makes this output is available
 in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Laurent Navet 
Signed-off-by: Greg Kroah-Hartman

staging: line6: drop MIDI parameter sysfs attrs

2012-11-27T00:13:50+00:00

Both pod.c and variax.c expose the device's MIDI parameters as sysfs
attrs.  Knowledge of MIDI constants should be in userspace, not in the
driver.  Drop the sysfs attrs and let userspace interpret parameters it
cares about instead.

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman