linux.git/drivers/staging/keucr, branch v3.13 Linux kernel source tree Staging: keucr: fix quoted string split across lines 2013-10-07T05:07:30+00:00 Ebru Akagunduz ebru.akagunduz@gmail.com 2013-10-05T14:11:39+00:00 4910071518a07edc6ba6015c5879f16fa3c8d34d Fix checkpatch.pl issues quoted string split across lines in usb.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fix checkpatch.pl issues quoted string split across lines in usb.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: keucr: be explicit to the sysfs file permissions 2013-08-24T17:33:07+00:00 Greg Kroah-Hartman gregkh@linuxfoundation.org 2013-08-24T17:33:07+00:00 00009615c3fbd49d38771ad07cc9c9d96e05e9cb Use the DEVICE_ATTR_RW() macro to be clearer as to the permissions for the sysfs file, making it easier to audit the code. Cc: Al Cho <acho@novell.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Use the DEVICE_ATTR_RW() macro to be clearer as to the permissions for
the sysfs file, making it easier to audit the code.

Cc: Al Cho <acho@novell.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: keucr: removed unnecessary variables and comments 2013-06-17T21:46:18+00:00 Laura Lawniczak laura.lawniczak@googlemail.com 2013-06-09T21:11:30+00:00 9acd5b654dc33cf6ecf3965bf46b47901919fd43 blen and bn were only used in commented code fragments. since comments should be informative and not for storing old code, both, commented code and variables, were removed. Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
blen and bn were only used in commented code fragments.
since comments should be informative and not for storing old
code, both, commented code and variables, were removed.

Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com>
Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
keucr: fix some alignment- and whitespace-problems 2013-06-06T18:48:50+00:00 Johannes Schilling of82ecuq@cip.cs.fau.de 2013-06-06T16:10:50+00:00 0ea8a165ab300699ffa3b68721e4837173508eb3 resolves checkpatch errors and warnings regarding whitespace around operators, line lengths and indentation. Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
resolves checkpatch errors and warnings regarding whitespace around
operators, line lengths and indentation.

Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com>
Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
keucr: moved function to other file 2013-06-06T18:48:50+00:00 Laura Lawniczak laura.lawniczak@googlemail.com 2013-06-06T16:10:49+00:00 eecb3c07e7cce24c35de97e5f895874a8a2e9126 Function usb_stor_print_cmd was declared in init.c but only used in transport.c. So it was reasonable to move it there and declare it static Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Function usb_stor_print_cmd was declared in init.c but only used
in transport.c. So it was reasonable to move it there and declare
it static

Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
keucr: more readable and friendly error messages 2013-06-06T18:48:50+00:00 Laura Lawniczak laura.lawniczak@googlemail.com 2013-06-06T16:10:48+00:00 6fbb90bf285e2d6fdfe6b4de244e1e13803dd7b7 Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com>
Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
keucr: migrate printk to dev_dbg/info/warn/err 2013-06-06T18:48:50+00:00 Laura Lawniczak laura.lawniczak@googlemail.com 2013-06-06T16:10:47+00:00 29b31420f62277140f510b96a6356fa334029007 as per suggestion of checkpatch.pl; this resolves warnings like "Prefer netdev_info .. then dev_info .. to printk". Changed signature of function usb_stor_print_cmd in init.c to enable usage of dev_err Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
as per suggestion of checkpatch.pl; this resolves warnings like "Prefer
netdev_info .. then dev_info .. to printk".
Changed signature of function usb_stor_print_cmd in init.c to enable
usage of dev_err

Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com>
Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
keucr: use more specific max_t(int, .. 2013-06-06T18:48:49+00:00 Johannes Schilling of82ecuq@cip.cs.fau.de 2013-06-06T16:10:46+00:00 3fb91d1128ff8a211f0a2b4dec9ad34d33ce6316 as advised by checkpatch, changed generic max(..) to max_t(int, .. Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
as advised by checkpatch, changed generic max(..) to max_t(int, ..

Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com>
Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
keucr: remove some unneccesary typedefs 2013-06-06T18:48:49+00:00 Johannes Schilling of82ecuq@cip.cs.fau.de 2013-06-06T16:10:45+00:00 8be88040000705e6f26cc3f59b26fdd0efc7eae6 resolves checkpatch.pl warning "do not add new typedefs" and renames allcaps structures. Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
resolves checkpatch.pl warning "do not add new typedefs" and renames allcaps
structures.

Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com>
Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: keucr: remove needless check before usb_free_coherent() 2013-05-30T11:46:26+00:00 Wei Yongjun yongjun_wei@trendmicro.com.cn 2013-05-23T09:28:34+00:00 aba12e3fccc79b8553a28a696e20859e3bfb1519 usb_free_coherent() is safe with NULL addr and this check is not required. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
usb_free_coherent() is safe with NULL addr and this check is
not required.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>