This fixes the checkpatch.pl warning: WARNING: macros should not use a trailing semicolon Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com> Acked-by: Daniel Baluta <daniel.baluta@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This fixes the checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com> Acked-by: Daniel Baluta <daniel.baluta@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
All what these 'drivers' do is expose a single (non standard ABI) sysfs attribute that when written to does a direct pass-through to spi_write(). This is rather ugly and does not justify the existence of a driver as the same can easily done by using the spidev interface. The drivers will eventually be rewritten as proper IIO ABI compliant drivers which do have the proper abstraction layers between userspace and the device. But in the meantime these driver do not add any extra value and just clutter up the staging area. So just remove them. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This patch introduces the use of devm_iio_device_register and does away with the unregister in the remove function. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This patch introduces the use of devm_iio_device_register and does away with the unregister in the remove function. The remove function is no longer required and is completely removed. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
'val' is unsigned and cannot be negative. Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Cc: Michael Hennerich <hennerich@blackfin.uclinux.org> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Fix some little style issues in drivers/staging/iio/frequency/ad9832.c . This is my latest task of the eudyptula challenge (third attempt!) Signed-off-by: Federico Di Pierro <nierro92@gmail.com> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
checkpath.pl was complaining about value_mask: ERROR: Macros with complex values should be enclosed in parenthesis I fixed this by simply removing it since it's not used (as well as another macro). Got rid of the un-necessary error_ret label as well. Signed-off-by: Guillaume Morin <guillaume@morinfr.org> Reported-by: Michael Welling <mwelling@ieee.org> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Fixes the following warnings from sparse: drivers/staging/iio/frequency/ad9834.c:45:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9834.c:45:26: expected unsigned short [unsigned] [short] <noident> drivers/staging/iio/frequency/ad9834.c:45:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9834.c:47:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9834.c:47:26: expected unsigned short [unsigned] [short] <noident> drivers/staging/iio/frequency/ad9834.c:47:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9834.c:59:18: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9834.c:59:18: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9834.c:59:18: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9834.c:100:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9834.c:100:26: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9834.c:100:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9834.c:108:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9834.c:108:26: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9834.c:108:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9834.c:122:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9834.c:122:26: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9834.c:122:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9834.c:131:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9834.c:131:26: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9834.c:131:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9834.c:194:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9834.c:194:26: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9834.c:194:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9834.c:387:18: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9834.c:387:18: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9834.c:387:18: got restricted __be16 [usertype] <noident> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Fixes the following warnings from sparse: drivers/staging/iio/frequency/ad9832.c:43:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9832.c:43:26: expected unsigned short [unsigned] [short] <noident> drivers/staging/iio/frequency/ad9832.c:43:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9832.c:46:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9832.c:46:26: expected unsigned short [unsigned] [short] <noident> drivers/staging/iio/frequency/ad9832.c:46:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9832.c:49:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9832.c:49:26: expected unsigned short [unsigned] [short] <noident> drivers/staging/iio/frequency/ad9832.c:49:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9832.c:52:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9832.c:52:26: expected unsigned short [unsigned] [short] <noident> drivers/staging/iio/frequency/ad9832.c:52:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9832.c:65:27: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9832.c:65:27: expected unsigned short [unsigned] [short] <noident> drivers/staging/iio/frequency/ad9832.c:65:27: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9832.c:68:27: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9832.c:68:27: expected unsigned short [unsigned] [short] <noident> drivers/staging/iio/frequency/ad9832.c:68:27: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9832.c:107:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9832.c:107:26: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9832.c:107:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9832.c:120:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9832.c:120:26: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9832.c:120:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9832.c:133:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9832.c:133:26: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9832.c:133:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9832.c:144:26: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9832.c:144:26: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9832.c:144:26: got restricted __be16 [usertype] <noident> drivers/staging/iio/frequency/ad9832.c:277:18: warning: incorrect type in assignment (different base types) drivers/staging/iio/frequency/ad9832.c:277:18: expected unsigned short [unsigned] data drivers/staging/iio/frequency/ad9832.c:277:18: got restricted __be16 [usertype] <noident> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>