linux.git/drivers/staging/gs_fpgaboot, branch v3.19 Linux kernel source tree staging: gs_fpgaboot: fix a compiler warning with make W=2 2014-10-29T09:39:55+00:00 Devendra Naga devendranaga4@gmail.com 2014-10-24T20:31:56+00:00 84e9cd6b5c42d021cc0a2dac7d6e49e9d9dfa037 The below warning is fixed: drivers/staging/gs_fpgaboot/gs_fpgaboot.c: In function ‘gs_load_image’: drivers/staging/gs_fpgaboot/gs_fpgaboot.c:196:58: warning: declaration of ‘file’ shadows a global declaration [-Wshadow] drivers/staging/gs_fpgaboot/gs_fpgaboot.c:45:14: warning: shadowed declaration is here [-Wshadow] by renaming file function argument of gs_load_image with fw_file. Signed-off-by: Devendra Naga <devendranaga4@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The below warning is fixed:

drivers/staging/gs_fpgaboot/gs_fpgaboot.c: In function ‘gs_load_image’:
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:196:58: warning: declaration of ‘file’ shadows a global declaration [-Wshadow]
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:45:14: warning: shadowed declaration is here [-Wshadow]

by renaming file function argument of gs_load_image with fw_file.

Signed-off-by: Devendra Naga <devendranaga4@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: gs_fpgpaboot: fix compiler warning with make W=1 2014-10-29T09:39:55+00:00 Devendra Naga devendranaga4@gmail.com 2014-10-24T20:31:55+00:00 a5841ff372c3c79c266ef383e7faee8206f0f757 the following compiler warning has been fixed: drivers/staging/gs_fpgaboot/gs_fpgaboot.c: In function ‘gs_read_bitstream’: drivers/staging/gs_fpgaboot/gs_fpgaboot.c:160:6: warning: variable ‘size’ set but not used [-Wunused-but-set-variable] CC drivers/staging/gs_fpgaboot/io.o LD drivers/staging/gs_fpgaboot/gs_fpga.o LD drivers/staging/gs_fpgaboot/built-in.o by removing the size variable. Signed-off-by: Devendra Naga <devendranaga4@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
the following compiler warning has been fixed:

drivers/staging/gs_fpgaboot/gs_fpgaboot.c: In function ‘gs_read_bitstream’:
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:160:6: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]
  CC      drivers/staging/gs_fpgaboot/io.o
  LD      drivers/staging/gs_fpgaboot/gs_fpga.o
  LD      drivers/staging/gs_fpgaboot/built-in.o

by removing the size variable.

Signed-off-by: Devendra Naga <devendranaga4@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: gs_fpgaboot: cleanup in gs_fpgaboot_init function 2014-10-29T09:39:55+00:00 Devendra Naga devendranaga4@gmail.com 2014-10-24T20:31:54+00:00 92bf93f1260402f17552f91599474bb9ead2a1b2 the error path is cleanup to return the correct (function call return value) error code. Signed-off-by: Devendra Naga <devendranaga4@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
the error path is cleanup to return the correct (function call return value)
error code.

Signed-off-by: Devendra Naga <devendranaga4@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: gs_fpgaboot: Fix "out of memory" error handling 2014-10-20T02:30:13+00:00 Dzmitry Sledneu dzmitry.sledneu@gmail.com 2014-10-09T07:22:43+00:00 02c2d43c2615ddc5d6e25f071b0f8d39ebc2d35d Fix "out of memory" error handling Signed-off-by: Dzmitry Sledneu <dzmitry.sledneu@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fix "out of memory" error handling

Signed-off-by: Dzmitry Sledneu <dzmitry.sledneu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: gs_fpgaboot: Use print_hex_dump_bytes instead of pr_info 2014-10-20T02:29:26+00:00 Joe Perches joe@perches.com 2014-10-07T15:53:20+00:00 6232876b723bb7954dd23405963155d8fb8dd654 Use print_hex_dump_bytes instead of pr_info Signed-off-by: Dzmitry Sledneu <dzmitry.sledneu@gmail.com> Reviewed-by: Insop Song <insop.song@gainspeed.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Use print_hex_dump_bytes instead of pr_info

Signed-off-by: Dzmitry Sledneu <dzmitry.sledneu@gmail.com>
Reviewed-by: Insop Song <insop.song@gainspeed.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: gs_fpgaboot: remove unnecessary 'out of memory' message 2014-10-20T02:29:12+00:00 Ebru Akagunduz ebru.akagunduz@gmail.com 2014-10-03T10:23:00+00:00 44396c7bce449eb6bcb862c6336f5da9ff44c867 This patch fixes "Possible unnecessary 'out of memory' message" checkpatch.pl warning in gs_fpgaboot.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch fixes "Possible unnecessary 'out of memory' message"
checkpatch.pl warning in gs_fpgaboot.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: gs_fpgaboot Fix trailing whitespace. 2014-09-20T00:42:15+00:00 Aybuke Ozdemir aybuke.147@gmail.com 2014-09-17T13:10:36+00:00 05fd349b1750d456423538e69c3c1d4d8a10f1c8 Fix checkpatch.pl issues with trailing whitespace in README. Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fix checkpatch.pl issues with trailing
whitespace in README.

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: gs_fpgaboot: remove checks for CONFIG_B4860G100 2014-09-08T21:00:07+00:00 Paul Bolle pebolle@tiscali.nl 2014-09-05T11:28:01+00:00 06a3fab941da48d04fb9c00a5422a6e9740578e8 There are two checks for CONFIG_B4860G100 in this driver. But there's no Kconfig symbol B4860G100. These checks will always evaluate to false. Remove them and the code they hide. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
There are two checks for CONFIG_B4860G100 in this driver. But there's no
Kconfig symbol B4860G100. These checks will always evaluate to false.
Remove them and the code they hide.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: gs_fpgaboot: remove unnecessary return statements 2014-09-07T04:50:30+00:00 Michał Bartoszkiewicz mbartoszkiewicz@gmail.com 2014-09-04T20:05:36+00:00 ba660d25b59a68dbc44634a9844705c86ee6a893 This fixes "void function return statements are not generally useful" warnings from checkpatch.pl. Signed-off-by: Michał Bartoszkiewicz <mbartoszkiewicz@gmail.com> Reviewed-by: Insop Song <insop.song@gainspeed.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This fixes "void function return statements are not generally useful"
warnings from checkpatch.pl.

Signed-off-by: Michał Bartoszkiewicz <mbartoszkiewicz@gmail.com>
Reviewed-by: Insop Song <insop.song@gainspeed.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: gs_fpgaboot: Fixed code style issues 2014-05-15T20:56:10+00:00 Rocco Folino lordzen87@gmail.com 2014-04-02T22:47:46+00:00 5535c4dd475ff936d36ad4d3f85d8be74f30245f Fixed missing a blank line after declarations warning Signed-off-by: Rocco Folino <lordzen87@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fixed missing a blank line after declarations warning

Signed-off-by: Rocco Folino <lordzen87@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>