linux.git/drivers/staging/greybus, branch v4.9

staging: greybus: arche-platform: fix device reference leak

2016-11-07T10:45:42+00:00

Make sure to drop the device reference taken by of_find_device_by_node()
before returning from arche_platform_change_state().

Note that this code is expected to be removed, but let's fix up the leak
nonetheless.

Fixes: 886aba558b9e ("greybus: arche-platform: Export fn to allow...")
Signed-off-by: Johan Hovold 
Acked-by: Viresh Kumar 
Reviewed-by: Vaibhav Hiremath 
Signed-off-by: Greg Kroah-Hartman

greybus: fix a leak on error in gb_module_create()

2016-10-24T13:51:00+00:00

We should release ->interfaces[0] as well.

Fixes: b15d97d77017 ("greybus: core: add module abstraction")
Signed-off-by: Dan Carpenter 
Acked-by: Viresh Kumar 
Acked-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

greybus: es2: fix error return code in ap_probe()

2016-10-24T13:51:00+00:00

Fix to return a negative error code from the es2_arpc_in_enable() error
handling case instead of 0, as done elsewhere in this function.

Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for APBridgeA RPC")
Signed-off-by: Wei Yongjun 
Acked-by: Viresh Kumar 
Reviewed-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

greybus: arche-platform: Add missing of_node_put() in arche_platform_change_state()

2016-10-24T13:51:00+00:00

This node pointer is returned by of_find_compatible_node() with
refcount incremented in this function. of_node_put() on it before
exitting this function.

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun 
Acked-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

Staging: greybus: uart: Use gbphy_dev->dev instead of bundle->dev

2016-10-17T07:14:55+00:00

Some of the print messages are using the incorrect device pointer, fix
them.

Signed-off-by: Viresh Kumar 
Acked-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

2016-10-17T07:14:55+00:00

Some of the print messages are using the incorrect device pointer, fix
them.

Signed-off-by: Viresh Kumar 
Acked-by: Johan Hovold 
Reviewed-by: Rui Miguel Silva 
Signed-off-by: Greg Kroah-Hartman

staging: greybus: light: check the correct value of delay_on

2016-10-02T13:49:26+00:00

When checking the value of delay_on to set the channel as active, it was
checked the pointer and not the value, as it should be.

Fixes: cc43368a3c ("greybus: lights: Control runtime pm suspend/resume on AP side")

Signed-off-by: Rui Miguel Silva 
Signed-off-by: Greg Kroah-Hartman

staging: greybus: light: check delay_{on|off} before use

2016-10-02T13:49:26+00:00

Even though we trust leds core that the pointers should be valid, we are
safer to check delay_{on|off} before use.

Also, this avoid a smatch warning:
drivers/staging/greybus/light.c:484 gb_blink_set()
warn: variable dereferenced before check 'delay_on' (see line 476)

Signed-off-by: Rui Miguel Silva 
Signed-off-by: Greg Kroah-Hartman

staging: greybus: light: fix attributes allocation

2016-10-02T13:49:26+00:00

Fix allocation of attributes with the correct size, this also fix smatch
warning:

drivers/staging/greybus/light.c:293 channel_attr_groups_set()
warn: double check that we're allocating correct size: 8 vs 16

Signed-off-by: Rui Miguel Silva 
Signed-off-by: Greg Kroah-Hartman

staging: greybus: sdio: fix cmd_flags check for none response

2016-10-02T13:49:25+00:00

When checking for command flags field if response is not available we
really need to compare it with the right define and not bitwise AND it.

smatch warn:
        drivers/staging/greybus/sdio.c:481 gb_sdio_command()
        warn: bitwise AND condition is false here

Reported-by: Dan Carpenter 
Signed-off-by: Rui Miguel Silva 
Signed-off-by: Greg Kroah-Hartman