linux.git/drivers/staging/ft1000, branch v3.19

staging: ft1000 : replace attribute ((packed) with packed

2014-12-03T00:48:10+00:00

Replace two instances of __attribute ((__packed__) with __packed macro
to address the warning found by the checkpatch.pl tool.

Signed-off-by: Geoff Darst 
Signed-off-by: Greg Kroah-Hartman

staging:ft1000_pcmcia:Added a blank line after declaration

2014-12-03T00:38:22+00:00

This patch fix the checkpatch.pl warning

WARNING: Missing a blank line after declaration

Signed-off-by: Anjana Sasindran 
Signed-off-by: Greg Kroah-Hartman

staging: ft1000: Logging message neatening

2014-11-04T00:36:35+00:00

Use a more common logging style.

o Convert DEBUG macros to pr_debug
o Add pr_fmt
o Remove embedded function names from pr_debug
o Convert printks to pr_
o Coalesce formats and align arguments
o Add missing terminating newlines

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

staging: ft1000: Whitespace neatening

2014-11-04T00:35:32+00:00

Use normal kernel style, indentation and alignment.

git diff -w shows no difference

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

Staging: ft1000: ft1000_hw.c: Removed some checkpatch errors and warnings.

2014-10-30T20:25:08+00:00

ERROR: space prohibited after that '&' (ctx:WxW)
ERROR: "foo * bar" should be "foo *bar"
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: Surya Seetharaman 
Signed-off-by: Greg Kroah-Hartman

staging: ft1000: ft1000-usb: Remove useless cast on void pointer

2014-10-30T20:06:04+00:00

void pointers do not need to be cast to other pointer types.

The semantic patch used to find this:

@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Build tested it.

Signed-off-by: Tapasweni Pathak 
Signed-off-by: Greg Kroah-Hartman

staging: ft1000: ft1000-pcmcia: Remove useless cast on void pointer

2014-10-30T20:06:03+00:00

void pointers do not need to be cast to other pointer types.

The semantic patch used to find this:

@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Build tested it.

Signed-off-by: Tapasweni Pathak 
Signed-off-by: Greg Kroah-Hartman

Staging: ft1000: ft1000-pcmcia: Fix whitespace issues

2014-10-29T09:40:54+00:00

This patch fixes the following errors and warnings
identified by checkpatch.pl:

WARNING: please, no spaces at the start of a line
814: FILE: ft1000_hw.c:814:
    tempword = ft1000_read_reg(dev, FT1000_REG_DOORBELL);$

WARNING: please, no spaces at the start of a line
815: FILE: ft1000_hw.c:815:
    i=0;$

ERROR: spaces required around that '=' (ctx:VxV)
815: FILE: ft1000_hw.c:815:
    i=0;

WARNING: please, no spaces at the start of a line
816: FILE: ft1000_hw.c:816:
    while (tempword & FT1000_DB_DPRAM_TX) {$

ERROR: code indent should use tabs where possible
817: FILE: ft1000_hw.c:817:
        mdelay(10);$

WARNING: please, no spaces at the start of a line
817: FILE: ft1000_hw.c:817:
        mdelay(10);$

ERROR: code indent should use tabs where possible
818: FILE: ft1000_hw.c:818:
        i++;$

WARNING: please, no spaces at the start of a line
818: FILE: ft1000_hw.c:818:
        i++;$

ERROR: code indent should use tabs where possible
819: FILE: ft1000_hw.c:819:
        if (i==10) {$

WARNING: please, no spaces at the start of a line
819: FILE: ft1000_hw.c:819:
        if (i==10) {$

WARNING: suspect code indent for conditional statements (8, 12)
819: FILE: ft1000_hw.c:819:
        if (i==10) {
            spin_unlock_irqrestore(&info->dpram_lock, flags);

ERROR: spaces required around that '==' (ctx:VxV)
819: FILE: ft1000_hw.c:819:
        if (i==10) {

ERROR: code indent should use tabs where possible
820: FILE: ft1000_hw.c:820:
            spin_unlock_irqrestore(&info->dpram_lock, flags);$

WARNING: please, no spaces at the start of a line
820: FILE: ft1000_hw.c:820:
            spin_unlock_irqrestore(&info->dpram_lock, flags);$

ERROR: code indent should use tabs where possible
821: FILE: ft1000_hw.c:821:
            return;$

WARNING: please, no spaces at the start of a line
821: FILE: ft1000_hw.c:821:
            return;$

ERROR: code indent should use tabs where possible
822: FILE: ft1000_hw.c:822:
        }$

WARNING: please, no spaces at the start of a line
822: FILE: ft1000_hw.c:822:
        }$

ERROR: code indent should use tabs where possible
823: FILE: ft1000_hw.c:823:
        tempword = ft1000_read_reg(dev, FT1000_REG_DOORBELL);$

WARNING: please, no spaces at the start of a line
823: FILE: ft1000_hw.c:823:
        tempword = ft1000_read_reg(dev, FT1000_REG_DOORBELL);$

WARNING: please, no spaces at the start of a line
824: FILE: ft1000_hw.c:824:
    }$

Signed-off-by: Nicky Chorley 
Signed-off-by: Greg Kroah-Hartman

staging: ft1000: do not initialise statics to 0 or NULL

2014-10-29T09:27:46+00:00

Remove following checkpatch.pl error from ft1000/ft1000-usb/ft1000_debug.c
ERROR: do not initialise statics to 0 or NULL

Signed-off-by: Chen Weixiang 
Signed-off-by: Greg Kroah-Hartman

staging: ft1000: Remove curly braces for single statement blocks

2014-10-28T08:53:09+00:00

This patch removes curly braces for single statement
blocks using following coccinelle script:

@@
expression e1;
@@

- if (e1) {
+ if (e1)
        return ...;
- }

Signed-off-by: Ebru Akagunduz 
Acked-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman