linux.git/drivers/staging/dream, branch v2.6.32

Staging: dream: introduce missing kfree

2009-09-15T19:02:34+00:00

Error handling code following a kmalloc or kzalloc should free the
allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// 
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// 

Signed-off-by: Julia Lawall

staging: Make some structures static

2009-09-15T19:02:24+00:00

This was done using a semantic patch (http://coccinelle.lip6.fr/) that
checks that the declaration is not inside a function definition, that the
defined variable is not exported using EXPORTED_SYMBOL, etc, and that the
defined variable does not occur in any other file.  If these conditions
hold, static is added before the declaration.

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

Staging: dream: Synaptics touchscreen: check that smbus is available

2009-09-15T19:02:05+00:00

Check that SMBUS APIs are available in touchscreen driver.

Signed-off-by: Pavel Machek 
Signed-off-by: Greg Kroah-Hartman

Staging: dream: add support for input on GPIO pins

2009-09-15T19:02:05+00:00

Support for input devices connected to GPIO pins. This adds support
for HTC Dream's keyboard and its trackball. Generic support already
exists for keyboard on GPIO, but this one is more advanced because it
can detect shadow key presses (and actually works with Dream :-).

(It also contains Kconfig/Makefile changes, including some that were
missing from previous commit. Sorry.)

Signed-off-by: Pavel Machek 
Signed-off-by: Greg Kroah-Hartman

Staging: dream, fix buf overflow

2009-09-15T19:02:04+00:00

In vfe_send_msg_no_payload there is a wrong struct vfe_message allocation.
It allocates only sizeof(pointer to vfe_message) for a whole structure.
Add a dereference to the sizeof to allocate sizeof(vfe_message).

Signed-off-by: Jiri Slaby 
Acked-by: Pavel Machek 
Signed-off-by: Greg Kroah-Hartman

Staging: dream: synaptics touchscreen for dream: documentation

2009-09-15T19:02:04+00:00

This adds pointer to hardware documentation, and adds code comment
from Arve.

Signed-off-by: Pavel Machek 
Signed-off-by: Greg Kroah-Hartman

Staging: HTC Dream: touchscreen: more cleanups

2009-09-15T19:02:04+00:00

This separates coefficient computation into separate function, so that
main probe does not have 1001 variables, and is of a more reasonable
size.

Signed-off-by: Pavel Machek 
Cc: Arve Hjønnevåg 
Signed-off-by: Greg Kroah-Hartman

Staging: HTC Dream: Cleanup Dream touchscreen driver

2009-09-15T19:02:04+00:00

This is first part of touchscreen cleanups. I did not remove
earlysuspend functionality for now (to help Google merge the changes).

I mainly introduced helpers to reduce code duplication, and split huge
functions into smaller ones.

Signed-off-by: Pavel Machek 
Cc: Arve Hjønnevåg 
Signed-off-by: Greg Kroah-Hartman

Staging: HTC Dream: touchscreen driver for staging

2009-09-15T19:02:04+00:00

This adds support for synaptic touchscreen, used in HTC dream
cellphone.

This is original version from Arve, fixed only to compile; I do have
cleaner version, but I broken something inside, and this will preserve
authorship better. I originally tried to push the driver directly to
input/touchscreen, but the driver has some issues with interrupt
handling that are more difficult to fix than I expected at first.

Signed-off-by: Arve Hjønnevåg 
Signed-off-by: Pavel Machek

Staging: htc: Dream: limit Kconfig for only MSM platforms

2009-09-15T19:02:04+00:00

Limit SMD communication glue to MSM platform. It is closely tied to
MSM architecture.

Signed-off-by: Pavel Machek 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Greg Kroah-Hartman