linux.git/drivers/staging/dgap/dgap.h, branch v4.1

staging: dgap: Avoid name collision

2015-03-07T01:06:30+00:00

Building for ARM64 leads to the following build warning:

In file included from drivers/staging/dgap/dgap.c:66:0:
drivers/staging/dgap/dgap.h:124:0: warning: "PCI_IO_SIZE" redefined
 #define PCI_IO_SIZE  0x00200000
 ^
In file included from ./arch/arm64/include/asm/page.h:66:0,
                 from include/linux/mm_types.h:15,
                 from include/linux/sched.h:27,
                 from ./arch/arm64/include/asm/compat.h:25,
                 from ./arch/arm64/include/asm/stat.h:23,
                 from include/linux/stat.h:5,
                 from include/linux/module.h:10,
                 from drivers/staging/dgap/dgap.c:47:
./arch/arm64/include/asm/memory.h:39:0: note: this is the location of the previous definition
 #define PCI_IO_SIZE  SZ_16M
 ^

Use PCI_IO_SIZE_DGAP to avoid the name collision.

Reported-by: Olof's autobuilder 
Signed-off-by: Fabio Estevam 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove useless variables for saving tty's major

2014-11-07T17:30:22+00:00

The board_t has a tty_struct(serial_driver and print_driver)
that has a major number. When major number is compared in
dgap_tty_open(), just use brd->serial_driver{print_driver}->major.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove unused 'runwait' variable

2014-09-24T06:39:24+00:00

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

2014-09-19T23:53:57+00:00

Using schedule_timeout_interruptible() is exactly same as
setting a status of current process and calling  schedule_timeout().

Removes dgap_ms_sleep(), because this function is used
only when closing tty channel on dgap_tty_close().
And also removes ch_close_delay that is always set to 250
on dgap_tty_init().

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove useless a variable within board_t

2014-08-30T21:04:58+00:00

The use_interrupts is used only in dagp_request_irq() for checking
a value from user config file. It doesn't need in board_t struct.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: Simplify to set a module type

2014-08-16T19:23:06+00:00

It is same manner with setting a board type.
After allocating a type of "MNODE", get a token value
set to "module.type".

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: Simplify to set a concentrator type

2014-08-16T19:23:06+00:00

It is same manner with setting a board type.
For example of config file for concentrator,
    "conc ccon" or
    "conc epcon"

After allocating a type of "CNODE" then set a type of concentrator.
So remove cases in swith statement, just get a token from string
and set to "conc.type". And also it doesn't need to "conc.v_type".

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: Simplify set a board type from configration file

2014-08-16T19:23:06+00:00

Board types need to separate normal command like IO, MEM and so on.
And the board type will come after "board" string in config file normally.
(If it is not, dgap_gettok returns an error with zero)
After that, set a variable of a number which is matched with specific
a board number to "board.type". The dgap_gettok() returns that number so
just set to "board.type" and also "v_type" can be removed.

In case of boards of PCI type are set variables to zero. These can
be removed because "p" as cnode get memory from kzalloc so already
set to zero.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove useless variable

2014-08-16T19:23:05+00:00

dgap_major_serial_registered and dgap_major_transparent_print_registered
could be checked whether a board is initialized.
But it doesn't need to check that variables becasue dgap module
isn't calling the dgap_cleanup_tty() without initializing
for a board completely.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove unused waitqueues

2014-07-09T19:02:16+00:00

dgap_dl_wait and kme_wait are not used in dgap.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman