linux.git/drivers/staging/cxt1e1/linux.c, branch v3.14

staging/cxt1e1/linux.c: Correct arbitrary memory write in c4_ioctl()

2014-03-05T00:20:01+00:00

The function c4_ioctl() writes data from user in ifr->ifr_data
to the kernel struct data arg, without any iolen bounds checking.
This can lead to a arbitrary write outside of the struct data arg.
Corrected by adding bounds-checking of iolen before the copy_from_user().

Signed-off-by: Salva Peiró 
Signed-off-by: Greg Kroah-Hartman

Drivers: Staging: cxt1e1: use __dev_get_name instead of dev_get_name to find interfaces

2014-01-15T02:50:46+00:00

The following call chain denotes that both do_reset() and do_del_chan()
are protected under rtnl_lock. If we use __dev_get_by_name() instead of
dev_get_by_name() to find interface handlers in them, this would help
us avoid to change interface reference counter.

dev_ioctl()
  rtnl_lock()
  dev_ifsioc()
    c4_ioctl()
      do_reset()
      do_del_chan()
  rtnl_unlock()

Signed-off-by: Ying Xue 
Signed-off-by: David S. Miller

staging: cxt1e1: linux.c: Return negative error codes

2013-10-01T01:48:41+00:00

Return negative error codes as is followed in the rest of the
kernel.

Signed-off-by: Sachin Kamat 
Signed-off-by: Greg Kroah-Hartman

staging: cxt1e1: linux.c: Use NULL instead of 0

2013-10-01T01:48:40+00:00

Pointers should be assigned NULL instead of 0.

Signed-off-by: Sachin Kamat 
Signed-off-by: Greg Kroah-Hartman

staging: cxt1e1: Remove #define SBE_INCLUDE_SYMBOLS

2013-08-12T22:20:25+00:00

Removed the unneeded SBE_INCLUDE_SYMBOLS #define, and the associated STATIC
#define, and replaced all occurances of STATIC with 'static'.  This was in
response to sparse warnings of the form "symbol 'XYZ' was not declared. Should
it be static?".

Removed a function prototype (musycc_init_port) as adding the 'static'
declaration produced a new gcc warning. (musycc_init_port is only declared if
SBE_WAN256T3_ENABLE is set)

Signed-off-by: Shaun Laing 
Signed-off-by: Greg Kroah-Hartman

Staging/cxt1e1:Fixing foo * bar should be foo *bar

2013-05-22T22:28:30+00:00

This patch fixes the variable naming  error foo * bar should be foo *bar.

Signed-off-by: Dulshani Gunawardhana 
Signed-off-by: Greg Kroah-Hartman

staging: cxt1e1: buffer overflow in do_del_chan()

2013-01-25T19:21:26+00:00

If we don't restrict "cp.channum" to 3 digits then the sprintf() will
overflow.  I've added a check and changed the sprintf() to snprintf().

Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: cxt1e1: solve coding style problem

2012-09-04T21:27:42+00:00

remove the spaces and replace with tabs at the beginning of a line
and also remove space between function call and its open paranthesis

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging: cxt1e1: use kernel's way of returning error codes

2012-09-04T21:27:41+00:00

The error codes the kernel functions return are -ve numbers, convert this
function to follow the other kernel functions

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging: Add module.h to more drivers implicitly using it.

2011-10-31T23:32:10+00:00

This 2nd batch of implicit module.h users only appeared when we
removed the unnecessary module.h from include/linux/miscdevice.h
[The 1st batch is already present in Greg's staging tree.]

Signed-off-by: Paul Gortmaker