linux.git/drivers/staging/cxt1e1/linux.c, branch v3.0 Linux kernel source tree staging: Fix some incorrect use of positive error codes. 2011-01-21T20:35:50+00:00 Ralph Loader suckfish@ihug.co.nz 2011-01-21T06:27:53+00:00 3ec6080e2e5be05e6f7fbbe5ab20b0eab84e166b Use -E... instead of just E... in a few places where negative error codes are expected by a functions callers. These were found by grepping with coccinelle & then inspecting by hand to determine which were bugs. The staging/cxt1e1 driver appears to intentionally use positive E... error codes in some places, and negative -E... error codes in others, making it hard to know which is intended where - very likely I missed some problems in that driver. Signed-off-by: Ralph Loader <suckfish@ihug.co.nz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Use -E... instead of just E... in a few places where negative error
codes are expected by a functions callers.  These were found by grepping
with coccinelle & then inspecting by hand to determine which were bugs.

The staging/cxt1e1 driver appears to intentionally use positive E...
error codes in some places, and negative -E... error codes in others,
making it hard to know which is intended where - very likely I missed
some problems in that driver.

Signed-off-by: Ralph Loader <suckfish@ihug.co.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: cxt1e1: rename global log_level variable 2010-12-10T18:46:30+00:00 Greg Kroah-Hartman gregkh@suse.de 2010-12-10T18:46:30+00:00 b8b739941eb57ec4c5fc87a73e7e7b554cf395fb The driver should not have such a generic global variable name. Reported-by: Zimny Lech <napohybelskurwysynom2010@gmail.com> Cc: Bob Beers <bob.beers@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
The driver should not have such a generic global variable name.

Reported-by: Zimny Lech <napohybelskurwysynom2010@gmail.com>
Cc: Bob Beers <bob.beers@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: cxt1e1: multiple definition of max_mtu fix 2010-10-19T17:12:14+00:00 Bob Beers bob.beers@gmail.com 2010-10-16T22:06:36+00:00 c694ed85eab4e7966cd83fca509ce27494e3e296 eliminate multiple definition of max_mtu by renaming with cxt1e1_ prefix, similarly rename max_mru Signed-off-by: Bob Beers <bbeers@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
eliminate multiple definition of max_mtu by renaming
 with cxt1e1_ prefix, similarly rename max_mru

Signed-off-by: Bob Beers <bbeers@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: cxt1e1: remove code guarded by GENERIC_HDLC_VERSION 2010-06-18T22:20:59+00:00 Jiri Kosina jkosina@suse.cz 2010-05-26T14:20:41+00:00 9c770f3b881c5066ff014968473ffbbafee82247 Current linux kernel has GENERIC_HDLC_VERSION equal to 4, no need to have dead code in-kernel which was there for ancient kernel versions. Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Current linux kernel has GENERIC_HDLC_VERSION equal to 4, no need to
have dead code in-kernel which was there for ancient kernel versions.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: cxt1e1: remove all code dependent on LINUX_VERSION_CODE 2010-06-18T22:16:21+00:00 Jiri Kosina jkosina@suse.cz 2010-05-26T11:39:04+00:00 5749df14aef6d3fd7146f17e4f0c61526a53766e Remove all code which is dead for in-kernel driver due to being ifdefed by LINUX_VERSION_CODE. While at it, also remove surrounding code which is commented out, or '#if 1' nops. Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Remove all code which is dead for in-kernel driver due to being
ifdefed by LINUX_VERSION_CODE.

While at it, also remove surrounding code which is commented out,
or '#if 1' nops.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: staging/cxt1e1: Convert bare printks to pr_<level> 2010-05-11T18:36:04+00:00 Joe Perches joe@perches.com 2010-05-03T19:33:16+00:00 694a98073f83ce1c14e3c0bba182bfeba5c44f01 Added #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt A few line splits for long arguments A couple of embedded function names converted to "%s", __func__ Removed some uses of THIS_MODULE->name Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Added #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
A few line splits for long arguments
A couple of embedded function names converted to "%s", __func__
Removed some uses of THIS_MODULE->name

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: cxt1e1: fix cxt1e1 module names 2010-05-11T18:36:02+00:00 Joe Perches joe@perches.com 2010-05-03T18:02:44+00:00 e6e4d05d4d440f1989f696baa146263957593345 On Mon, 2010-05-03 at 10:09 -0700, Randy Dunlap wrote: > Lots of cxt1e1 source code uses THIS_MODULE->name, which won't build > when CONFIG_MODULES is not enabled, so use KBUILD_MODNAME instead. Perhaps a conversion to pr_<level> is better? Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
On Mon, 2010-05-03 at 10:09 -0700, Randy Dunlap wrote:
> Lots of cxt1e1 source code uses THIS_MODULE->name, which won't build
> when CONFIG_MODULES is not enabled, so use KBUILD_MODNAME instead.

Perhaps a conversion to pr_<level> is better?

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: cxt1e1: use netdev_priv to fix build 2010-05-11T18:35:57+00:00 Randy Dunlap randy.dunlap@oracle.com 2010-04-30T17:07:12+00:00 d87d909a45b7b6bf411559e85d386ef0a2f4bbae Fix cxt1e1 build error: drivers/staging/cxt1e1/linux.c:1195: error: 'struct net_device' has no member named 'priv' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Acked-by: Bob Beers <bob.beers@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Fix cxt1e1 build error:
drivers/staging/cxt1e1/linux.c:1195: error: 'struct net_device' has no member named 'priv'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Bob Beers <bob.beers@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
staging: Add driver to support wanPMC-CxT1E1 card. 2010-05-11T18:35:31+00:00 Bob Beers bob.beers@gmail.com 2010-03-04T13:40:46+00:00 50ee11fe383255db8e5c3307319d470015616f27 Obviously still needs serious attention, but it compiles. Original author: Rick Dobbs Add driver to support wanPMC-CxT1E1 card. This card provides 1-4 ports of T1E1 in PMC form factor. Note, Rick doesn't want his email showing up as the "From:" author, but has given his blessing to have the code included in the kernel tree. Signed-off-by: Bob Beers <bob.beers@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Obviously still needs serious attention, but it compiles.

Original author: Rick Dobbs

Add driver to support wanPMC-CxT1E1 card.

This card provides 1-4 ports of T1E1 in PMC form factor.

Note, Rick doesn't want his email showing up as the "From:" author, but
has given his blessing to have the code included in the kernel tree.

Signed-off-by: Bob Beers <bob.beers@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>