linux.git/drivers/staging/crystalhd, branch v3.10

staging: crystalhd: remove use of __devexit

2012-11-21T23:05:12+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Signed-off-by: Greg Kroah-Hartman

staging: crystalhd: remove use of __devinit

2012-11-21T23:05:01+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Signed-off-by: Greg Kroah-Hartman

staging: crystalhd: remove use of __devexit_p

2012-11-21T23:04:58+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton 
Signed-off-by: Greg Kroah-Hartman

staging: crystalhd: fix a style warning

2012-10-22T20:35:37+00:00

we dont need braces around a single statement blocks

style WARNINGS:
drivers/staging/crystalhd/crystalhd_cmds.c:311: WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

drivers/staging/crystalhd/crystalhd_lnx.c: adjust inconsistent IS_ERR and PTR_ERR

2012-09-04T21:22:48+00:00

Change the call to PTR_ERR to access the value just tested by IS_ERR.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
expression e,e1;
@@

(
if (IS_ERR(e)) { ... PTR_ERR(e) ... }
|
if (IS_ERR(e=e1)) { ... PTR_ERR(e) ... }
|
*if (IS_ERR(e))
 { ...
*  PTR_ERR(e1)
   ... }
)
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

staging/crystalhd: unregister chardev when class_create fails in chd_dec_init_chdev

2012-08-14T02:15:49+00:00

we missed a unregiser_chrdev if the class_create and subsequent function calls / checks fail

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging/crystalhd: assign PTR_ERR at fail cases to rc in chd_dec_init_chdev

2012-08-14T02:15:49+00:00

the rc assignment to PTR_ERR at fail cases of class_create and device_create are missed out,
return proper error rather than returning -ENODEV.

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

Remove all #inclusions of asm/system.h

2012-03-28T17:30:03+00:00

Remove all #inclusions of asm/system.h preparatory to splitting and killing
it.  Performed with the following command:

perl -p -i -e 's!^#\s*include\s*.*\n!!' `grep -Irl '^#\s*include\s*' *`

Signed-off-by: David Howells

Add #includes needed to permit the removal of asm/system.h

2012-03-28T17:30:03+00:00

asm/system.h is a cause of circular dependency problems because it contains
commonly used primitive stuff like barrier definitions and uncommonly used
stuff like switch_to() that might require MMU definitions.

asm/system.h has been disintegrated by this point on all arches into the
following common segments:

 (1) asm/barrier.h

     Moved memory barrier definitions here.

 (2) asm/cmpxchg.h

     Moved xchg() and cmpxchg() here.  #included in asm/atomic.h.

 (3) asm/bug.h

     Moved die() and similar here.

 (4) asm/exec.h

     Moved arch_align_stack() here.

 (5) asm/elf.h

     Moved AT_VECTOR_SIZE_ARCH here.

 (6) asm/switch_to.h

     Moved switch_to() here.

Signed-off-by: David Howells

staging: crystalhd: Fix typo in crystalhd_hw.c

2012-03-08T17:57:38+00:00

Correct spelling "interal" to "internal" in
drivers/staging/crystalhd/crystalhd_hw.c

Signed-off-by: Masanari Iida 
Signed-off-by: Greg Kroah-Hartman