linux.git/drivers/staging/comedi/proc.c, branch v4.11

Staging: comedi: proc: Warn if unable to create proc entry

2017-01-03T14:30:21+00:00

The proc entry is not essential for the comedi system as
evident by the support for !CONFIG_PROC_FS. So for failure
to create, just warn and continue loading.

Signed-off-by: Cheah Kok Cheong 
Reviewed-by: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

Staging: comedi: proc: Add module owner

2017-01-03T14:30:21+00:00

Since this is a loadable kernel module, add module ownership
to follow LKM semantics.

Signed-off-by: Cheah Kok Cheong 
Reviewed-by: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

Staging: comedi: proc: Add __init prefix

2017-01-03T14:30:21+00:00

Add __init prefix so that symbol will be discarded after
module loading.

Signed-off-by: Cheah Kok Cheong 
Reviewed-by: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

Staging: comedi: proc: Change file permission to read only

2017-01-03T14:30:21+00:00

As there's no write operation, change to read only.
Was inadvertantly switched to 0644 in commit 1f817b86d5e6
("comedi: Don't use create_proc_read_entry()").

Signed-off-by: Cheah Kok Cheong 
Reviewed-by: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

Staging: comedi: proc: title block update

2014-03-19T04:41:04+00:00

Follow up patch for "STAGING: comedi: style and checkpatch fixes".
Removes the file name in the comment block per suggestions.

Signed-off-by: Michael Welling 
Signed-off-by: Greg Kroah-Hartman

STAGING: comedi: style and checkpatch fixes

2014-03-18T20:04:19+00:00

Updates block comment per Documentation/CodingStyle.
Also updated due to checkpatch warnings about qouted string
after Lindent modified the spacing slightly.

Signed-off-by: Michael Welling 
Signed-off-by: Greg Kroah-Hartman

staging: comedi: use refcount while reading /proc/comedi

2013-11-12T00:16:44+00:00

In the seq_file 'show' handler for "/proc/comedi" - `comedi_read()` in
"comedi/proc.c",  call `comedi_dev_get_from_minor()` instead of
`comedi_dev_from_minor()` to increment the reference counter for the
`struct comedi_device` while it is being examined.  Call
`comedi_dev_put()` to decrement the reference afterwards.  Also acquire
the `attach_lock` rwsem while checking whether the device is attached.

Signed-off-by: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

staging: comedi: use a mutex when accessing driver list

2013-07-23T21:22:29+00:00

Low-level comedi drivers registered with the comedi core by
`comedi_driver_register()` are linked together into a simple linked list
headed by the `comedi_drivers` variable and chained by the `next` member
of `struct comedi_driver`.  A driver is removed from the list by
`comedi_driver_unregister()`.  The driver list is iterated through by
`comedi_device_attach()` when the `COMEDI_DEVCONFIG` ioctl is used to
attach a "legacy" device to a driver, and is also iterated through by
`comedi_read()` in "proc.c" when reading "/proc/comedi".

There is currently no protection against items being added or removed
from the list while it is being iterated.  Add a mutex
`comedi_drivers_list_lock` to be locked while adding or removing an item
on the list, or when iterating through the list.

`comedi_driver_unregister()` also checks for and detaches any devices
using the driver.  This is currently done before unlinking the driver
from the list, but it makes more sense to unlink the driver from the
list first to prevent `comedi_device_attach()` attempting to use it, so
move the unlinking part to the start of the function.  Also, in
`comedi_device_attach()` hold on to the mutex until we've finished
attempting to attach the device to avoid it interfering with the
detachment in `comedi_driver_unregister()`.

Signed-off-by: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

staging: comedi: remove FSF address from boilerplate text

2013-05-13T21:34:22+00:00

Addresses change...

Remove the paragraph with the FSF address from all the comedi source
files.

Also, remove the paragraph about the finding the complete GPL in the
COPYING file since it's unnecessary.

Signed-off-by: H Hartley Sweeten 
Cc: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

staging: single_open() leaks

2013-05-05T04:15:43+00:00

Cc: stable@vger.kernel.org
Signed-off-by: Al Viro