linux.git/drivers/staging/ccree, branch v4.16 Linux kernel source tree staging: ccree: Fix missing blank line after declaration 2018-01-25T12:11:33+00:00 Kamal Heib kamalheib1@gmail.com 2018-01-24T22:01:30+00:00 1f43fb6d29279c29c994587e4b73ef0b9240daf7 Fix the following warning found by checkpatch.pl WARNING: Missing a blank line after declarations + struct cc_cipher_handle *blkcipher_handle = drvdata->blkcipher_handle; + if (blkcipher_handle) { Signed-off-by: Kamal Heib <kamalheib1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fix the following warning found by checkpatch.pl

WARNING: Missing a blank line after declarations
+	struct cc_cipher_handle *blkcipher_handle = drvdata->blkcipher_handle;
+	if (blkcipher_handle) {

Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: fix memory leaks in cc_ivgen_init 2018-01-15T14:50:35+00:00 Colin Ian King colin.king@canonical.com 2018-01-12T16:10:18+00:00 bd12b21ec3a20818db229aea67526f3ed6bc096d The current error exit path in function cc_ivgen_init via label 'out' free's resources from the drvdata->ivgen_handle context. However, drvdata->ivgen_handle has not been assigned to the context ivgen_ctx at this point, so the resources are not freed. Fix this by setting drvdata->ivgen_handle to ivgen_ctx as early as possible so that the clean up error exit return path can free the resources. Detected by CoveritScan, CID#1463795 ("Resource leak") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The current error exit path in function cc_ivgen_init via label
'out' free's resources from the drvdata->ivgen_handle context.
However, drvdata->ivgen_handle has not been assigned to the
context ivgen_ctx at this point, so the resources are not freed.
Fix this by setting drvdata->ivgen_handle to ivgen_ctx as early
as possible so that the clean up error exit return path can free
the resources.

Detected by CoveritScan, CID#1463795 ("Resource leak")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: remove redundant dev_err call in init_cc_resources() 2018-01-15T14:50:35+00:00 Wei Yongjun weiyongjun1@huawei.com 2018-01-11T11:14:57+00:00 14812d5f7165f5c961c68c3c9410416c501b94d3 There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: don't break lines unnecessarily 2018-01-15T14:50:35+00:00 Dan Carpenter dan.carpenter@oracle.com 2018-01-11T10:10:11+00:00 4d6142760309686cf8c83f03e2aea0e60edfd555 These lines are less than 80 characters so we don't need to break them up into chunks. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
These lines are less than 80 characters so we don't need to break them
up into chunks.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: dma mask is type u64 2018-01-09T15:02:18+00:00 Gilad Ben-Yossef gilad@benyossef.com 2018-01-09T10:24:33+00:00 f24d41169af2c71e461bda74af8fb36349621b59 The dma mask var was defined as dma_addr_t but should be u64. This showed as a sparse warning when building for 32 bit. Fix it by changing type to u64 and drop the cast. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The dma mask var was defined as dma_addr_t but should be
u64. This showed as a sparse warning when building for 32 bit.
Fix it by changing type to u64 and drop the cast.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: make stub function static inline 2018-01-09T15:02:18+00:00 Gilad Ben-Yossef gilad@benyossef.com 2018-01-09T10:24:32+00:00 5d5583d0e22279d1a8fe1372ec0d02da5f289116 The debugfs interface defines stub function if debugfs is not enabled, which were missing the 'static inline' qualifiers causing sparse warnings. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The debugfs interface defines stub function if debugfs is not
enabled, which were missing the 'static inline' qualifiers causing
sparse warnings.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: add missing include 2018-01-09T15:02:18+00:00 Gilad Ben-Yossef gilad@benyossef.com 2018-01-09T10:24:31+00:00 65073e6ea9632c1e38153565517d0324c0a06513 Add the missing include of include file with function declarations. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Add the missing include of include file with function declarations.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: remove unneeded includes 2018-01-09T15:01:35+00:00 Gilad Ben-Yossef gilad@benyossef.com 2018-01-09T10:24:30+00:00 6daa971b57f4fe878228ae90eeb2ded18738548b Remove include files not needed for compilation. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Remove include files not needed for compilation.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: use a consistent file naming convention 2018-01-09T15:00:07+00:00 Gilad Ben-Yossef gilad@benyossef.com 2018-01-09T10:24:29+00:00 e7660d2d4714a146a80553e9355b40c467d60183 The ccree driver source files were using an inconsistent naming convention stemming from what the company was called when they were added. Move to a single consistent naming convention for better code readability. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The ccree driver source files were using an inconsistent
naming convention stemming from what the company was called
when they were added.

Move to a single consistent naming convention for better
code readability.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: update TODO 2018-01-08T15:29:39+00:00 Gilad Ben-Yossef gilad@benyossef.com 2018-01-07T12:14:37+00:00 3c464ca5b86326cf9be6fa5025ba41eac8a75615 Update TODO to reflect work done Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Update TODO to reflect work done

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>