linux.git/drivers/staging/ccree, branch v4.14 Linux kernel source tree staging: ccree: save ciphertext for CTS IV 2017-08-23T23:22:35+00:00 Gilad Ben-Yossef gilad@benyossef.com 2017-08-23T09:12:05+00:00 737aed947f9b5bd749a2684e13572ee99a1b8bae The crypto API requires saving the last blocks of ciphertext in req->info for use as IV for CTS mode. The ccree driver was not doing this. This patch fixes that. The bug was manifested with cts(cbc(aes)) mode in tcrypt tests. Fixes: 302ef8ebb4b2 ("Add CryptoCell skcipher support") Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The crypto API requires saving the last blocks of ciphertext
in req->info for use as IV for CTS mode. The ccree driver
was not doing this. This patch fixes that.

The bug was manifested with cts(cbc(aes)) mode in tcrypt tests.

Fixes: 302ef8ebb4b2 ("Add CryptoCell skcipher support")
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: constify dev_pm_ops structures. 2017-08-16T22:10:42+00:00 Arvind Yadav arvind.yadav.cs@gmail.com 2017-08-08T09:23:59+00:00 22d82cb952f3c949078c6df4b0a5ea719b18cadc dev_pm_ops are not supposed to change at runtime. All functions working with dev_pm_ops provided by <linux/device.h> work with const dev_pm_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
dev_pm_ops are not supposed to change at runtime. All functions
working with dev_pm_ops provided by <linux/device.h> work with const
dev_pm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: Use sizeof(variable) in memory allocs 2017-08-16T22:10:42+00:00 Simon Sandström simon@nikanor.nu 2017-07-30T20:29:02+00:00 8bf48512916a3fce7201f7d469d304a7824a87d4 Fixes 9 checkpatch.pl warnings of type "Prefer kmalloc(sizeof(variable)...) over kmalloc(sizeof(type)...)" in staging/ccree. Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fixes 9 checkpatch.pl warnings of type
"Prefer kmalloc(sizeof(variable)...) over kmalloc(sizeof(type)...)"
in staging/ccree.

Signed-off-by: Simon Sandström <simon@nikanor.nu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: Fix unnecessary NULL check before kfree'ing it 2017-07-28T04:55:24+00:00 Suniel Mahesh sunil.m@techveda.org 2017-07-20T13:37:07+00:00 a7b1ba23556215952099274a0f008643de832f70 kfree(NULL) is safe and their is no need for a NULL check. Pointed out by checkpatch. Signed-off-by: Suniel Mahesh <sunil.m@techveda.org> Acked-by: Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
kfree(NULL) is safe and their is no need for a NULL check. Pointed out
by checkpatch.

Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: remove func name from log messages 2017-07-28T04:54:06+00:00 Gilad Ben-Yossef gilad@benyossef.com 2017-07-27T10:43:17+00:00 4a457c1710ab6cf9885b93a9aa93e8718abaca45 The SSI_LOG macros already add __func__ to log messages, so remove log message that add them a second time in the log message itself. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The SSI_LOG macros already add __func__ to log messages, so remove
log message that add them a second time in the log message itself.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: Fix alignment issues in ssi_request_mgr.c 2017-07-28T04:53:22+00:00 Simon Sandström simon@nikanor.nu 2017-07-18T20:03:57+00:00 28471424d1ce1b0fecbe788b1e283f52992b91ef Fixes checkpatch.pl alignment warnings. Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fixes checkpatch.pl alignment warnings.

Signed-off-by: Simon Sandström <simon@nikanor.nu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: Fix alignment issues in ssi_ivgen.c 2017-07-28T04:53:22+00:00 Simon Sandström simon@nikanor.nu 2017-07-18T20:03:56+00:00 e7ced775dc5620d90a9396bb434ce3f972a8c2be Fixes checkpatch.pl alignment warnings. Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fixes checkpatch.pl alignment warnings.

Signed-off-by: Simon Sandström <simon@nikanor.nu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: Fix alignment issues in ssi_cipher.c 2017-07-28T04:53:21+00:00 Simon Sandström simon@nikanor.nu 2017-07-18T20:03:55+00:00 32fabb034fdec213b087cdab1c7605f577ba5c60 Fixes checkpatch.pl alignment warnings. Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fixes checkpatch.pl alignment warnings.

Signed-off-by: Simon Sandström <simon@nikanor.nu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: Fix alignment issues in ssi_buffer_mgr.c 2017-07-28T04:53:21+00:00 Simon Sandström simon@nikanor.nu 2017-07-18T20:03:54+00:00 4ff66c46b04ccd207c1f7ffd8393743261fe8fd6 Fixes checkpatch.pl alignment warnings. Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fixes checkpatch.pl alignment warnings.

Signed-off-by: Simon Sandström <simon@nikanor.nu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ccree: Fix alignment issues in ssi_hash.c 2017-07-28T04:53:21+00:00 Simon Sandström simon@nikanor.nu 2017-07-18T20:03:53+00:00 3151c1df14e685dd2c27de7bec02b29029cfc837 Fixes checkpatch.pl alignment warnings. Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fixes checkpatch.pl alignment warnings.

Signed-off-by: Simon Sandström <simon@nikanor.nu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>