linux.git/drivers/staging/bcm, branch v3.0 Linux kernel source tree Fix common misspellings 2011-03-31T14:26:23+00:00 Lucas De Marchi lucas.demarchi@profusion.mobi 2011-03-31T01:57:33+00:00 25985edcedea6396277003854657b5f3cb31a628 Fixes generated by 'codespell' and manually reviewed. Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi> 
Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
staging: bcm: Remove NULL check before kfree 2011-03-14T18:57:30+00:00 Ilia Mirkin imirkin@alum.mit.edu 2011-03-13T05:28:55+00:00 23c32986870b4abb5b426d3399a4cbd43948e37c This patch was generated by the following semantic patch: // <smpl> @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; // </smpl> Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);

@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
staging: bcm: optimize kmalloc to kzalloc 2011-03-09T23:54:31+00:00 Alexander Beregalov a.beregalov@gmail.com 2011-03-09T00:53:34+00:00 f4a0e6b1354cd0bec6aca405883cc45662511f03 Use kzalloc rather than kmalloc followed by memset with 0. Found by coccinelle. Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Use kzalloc rather than kmalloc followed by memset with 0.
Found by coccinelle.

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: bcm: Bcmnet: fixed checkpatch script reported issues 2011-03-09T23:54:30+00:00 Vinay Sawal vinaysawal@gmail.com 2011-03-09T21:47:35+00:00 00b6fb2e31ac668795857c9609adc11e7964ed5a Fixed all issues reported by checkpatch script on this file. Signed-off-by: Vinay Sawal <vinaysawal@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Fixed all issues reported by checkpatch script on this file.

Signed-off-by: Vinay Sawal <vinaysawal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers:staging:bcm:CmHost.c Remove one to many n's in a word. 2011-03-01T03:00:29+00:00 Justin P. Mattock justinmattock@gmail.com 2011-02-27T04:34:02+00:00 a0fe6029bce5ca2f1e7bcc8e248be1b3d2a2f6f4 The Patch below removes one to many "n's" in a word.. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> CC: Greg Kroah-Hartman <gregkh@suse.de> CC: Stephen Hemminger <shemminger@vyatta.com> CC: devel@driverdev.osuosl.org Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
The Patch below removes one to many "n's" in a word..

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
CC: Greg Kroah-Hartman <gregkh@suse.de>
CC: Stephen Hemminger <shemminger@vyatta.com>
CC: devel@driverdev.osuosl.org
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: bcm: Bcmchar: Fix some checkpatch errors 2011-02-18T21:21:56+00:00 Javier Martinez Canillas martinez.javier@gmail.com 2011-02-12T03:38:25+00:00 78acd58746b513c062b3dafd5b563401bc9e9d47 Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: bcm: Bcmchar: Fix style issues on bcm_char_read() 2011-02-18T21:21:56+00:00 Javier Martinez Canillas martinez.javier@gmail.com 2011-02-12T03:38:24+00:00 7227ba06479f981f5cf9977a7eeb3a20d30dc501 Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: bcm: Bcmchar: Fix style issues on bcm_char_release() 2011-02-18T21:21:55+00:00 Javier Martinez Canillas martinez.javier@gmail.com 2011-02-12T03:38:23+00:00 a7d3976edc32e6041f9d68c79ba64a17d5ec5095 Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: bcm: Bcmchar: Fix style issues on bcm_char_open() 2011-02-18T21:21:55+00:00 Javier Martinez Canillas martinez.javier@gmail.com 2011-02-12T03:38:22+00:00 1e1233234edeacabbcaab9d086474224ba5af015 Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Staging: bcm: Check correct user provided length and fix error code returned 2011-02-04T21:01:02+00:00 Javier Martinez Canillas martinez.javier@gmail.com 2011-01-25T00:46:18+00:00 00719fab9f6eb90b9e427d1096ad540d51878661 bcm driver copies a buffer length provided by userpace without checking it. RxCntrlMsgBitMask is of type unsigned long so only makes sense to copy sizeof(unsigned long) bytes. Also, copy_from_user() returns the number of bytes that could not be copied. The driver is returning that value as error code instead of -EFAULT. This patch solves both issues. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Cc: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
bcm driver copies a buffer length provided by userpace without checking it.

RxCntrlMsgBitMask is of type unsigned long so only makes sense to copy
sizeof(unsigned long) bytes.

Also, copy_from_user() returns the number of bytes that could not be copied.
The driver is returning that value as error code instead of -EFAULT.

This patch solves both issues.

Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>