<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux.git/drivers/staging/bcm/nvm.c, branch v3.2</title>
<subtitle>Linux kernel source tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/'/>
<entry>
<title>drivers/staging/bcm/nvm.c: add missing kfree</title>
<updated>2011-08-23T22:20:53+00:00</updated>
<author>
<name>Julia Lawall</name>
<email>julia@diku.dk</email>
</author>
<published>2011-08-08T11:17:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=e5969d55743c49dfca24e165a534cf5f2638e86b'/>
<id>e5969d55743c49dfca24e165a534cf5f2638e86b</id>
<content type='text'>
Buff is only used as a temporary buffer within the function, so it should
be freed before leaving the function in an error case.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// &lt;smpl&gt;
@exists@
local idexpression x;
statement S,S1;
expression E;
identifier fl;
expression *ptr != NULL;
@@

x = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
&lt;... when != x
     when != if (...) { &lt;+...kfree(x)...+&gt; }
     when any
     when != true x == NULL
x-&gt;fl
...&gt;
(
if (x == NULL) S1
|
if (...) { ... when != x
               when forall
(
 return \(0\|&lt;+...x...+&gt;\|ptr\);
|
* return ...;
)
}
)
// &lt;/smpl&gt;

Signed-off-by: Julia Lawall &lt;julia@diku.dk&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Buff is only used as a temporary buffer within the function, so it should
be freed before leaving the function in an error case.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// &lt;smpl&gt;
@exists@
local idexpression x;
statement S,S1;
expression E;
identifier fl;
expression *ptr != NULL;
@@

x = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
&lt;... when != x
     when != if (...) { &lt;+...kfree(x)...+&gt; }
     when any
     when != true x == NULL
x-&gt;fl
...&gt;
(
if (x == NULL) S1
|
if (...) { ... when != x
               when forall
(
 return \(0\|&lt;+...x...+&gt;\|ptr\);
|
* return ...;
)
}
)
// &lt;/smpl&gt;

Signed-off-by: Julia Lawall &lt;julia@diku.dk&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix common misspellings</title>
<updated>2011-03-31T14:26:23+00:00</updated>
<author>
<name>Lucas De Marchi</name>
<email>lucas.demarchi@profusion.mobi</email>
</author>
<published>2011-03-31T01:57:33+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=25985edcedea6396277003854657b5f3cb31a628'/>
<id>25985edcedea6396277003854657b5f3cb31a628</id>
<content type='text'>
Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi &lt;lucas.demarchi@profusion.mobi&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi &lt;lucas.demarchi@profusion.mobi&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>beceem: change startup messages</title>
<updated>2010-11-01T18:06:24+00:00</updated>
<author>
<name>Stephen Hemminger</name>
<email>stephen.hemminger@vyatta.com</email>
</author>
<published>2010-11-01T18:06:24+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=4ea4f7a0d3d7a9961bf77f0860df8dd4a213b8a3'/>
<id>4ea4f7a0d3d7a9961bf77f0860df8dd4a213b8a3</id>
<content type='text'>
Change the regsister/unregister routines to generate better
messages, and control arrival of new frames when USB device is
unplugged.

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change the regsister/unregister routines to generate better
messages, and control arrival of new frames when USB device is
unplugged.

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>beceem: make local functions static</title>
<updated>2010-11-01T16:37:05+00:00</updated>
<author>
<name>Stephen Hemminger</name>
<email>stephen.hemminger@vyatta.com</email>
</author>
<published>2010-11-01T16:24:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=9dd47ee7dd535649a2c32d509631c7a3d793f2e1'/>
<id>9dd47ee7dd535649a2c32d509631c7a3d793f2e1</id>
<content type='text'>
Use namespace tool from kernel scripts to identify dead code and
functions that should be static.

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use namespace tool from kernel scripts to identify dead code and
functions that should be static.

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>beceem: remove dead code</title>
<updated>2010-11-01T13:54:43+00:00</updated>
<author>
<name>Stephen Hemminger</name>
<email>stephen.hemminger@vyatta.com</email>
</author>
<published>2010-11-01T04:03:03+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=3644c1a2f12b15e1c8bfb9ebfaacbd177011a72d'/>
<id>3644c1a2f12b15e1c8bfb9ebfaacbd177011a72d</id>
<content type='text'>
Remove commented out with '#if 0'

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove commented out with '#if 0'

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>beceem: remove OS wrapper library</title>
<updated>2010-11-01T13:35:21+00:00</updated>
<author>
<name>Stephen Hemminger</name>
<email>stephen.hemminger@vyatta.com</email>
</author>
<published>2010-11-01T13:35:21+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=082e889b475c46e71be6e779f15ab095f888e03f'/>
<id>082e889b475c46e71be6e779f15ab095f888e03f</id>
<content type='text'>
Use native kernel functions for kmalloc/kfree directly

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use native kernel functions for kmalloc/kfree directly

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>beceem: remove ifdef's</title>
<updated>2010-10-30T03:43:28+00:00</updated>
<author>
<name>Stephen Hemminger</name>
<email>stephen.hemminger@vyatta.com</email>
</author>
<published>2010-10-29T14:51:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=91d29ee1a82fedcd7d1bbf24007b31a49c47e90a'/>
<id>91d29ee1a82fedcd7d1bbf24007b31a49c47e90a</id>
<content type='text'>
There were a lot of ifdef's for driver options which have no
configuration options.  Choose the current value and remove the
ifdef.

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There were a lot of ifdef's for driver options which have no
configuration options.  Choose the current value and remove the
ifdef.

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging/bcm: add sparse annotations</title>
<updated>2010-10-05T15:50:15+00:00</updated>
<author>
<name>Arnd Bergmann</name>
<email>arnd@arndb.de</email>
</author>
<published>2010-09-30T08:24:12+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=44a17eff844d92421c8b568c84df29735e1e45f9'/>
<id>44a17eff844d92421c8b568c84df29735e1e45f9</id>
<content type='text'>
This marks up the code where sparse complains in most cases.
Most of the changes are in the ioctl handling code, which
gets __user annotations, finding one unchecked user access.

The rest is mostly about marking functions static when they
are only used in one file.

Signed-off-by: Arnd Bergmann &lt;arnd@arndb.de&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This marks up the code where sparse complains in most cases.
Most of the changes are in the ioctl handling code, which
gets __user annotations, finding one unchecked user access.

The rest is mostly about marking functions static when they
are only used in one file.

Signed-off-by: Arnd Bergmann &lt;arnd@arndb.de&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>staging: Beeceem USB Wimax driver</title>
<updated>2010-09-09T04:15:06+00:00</updated>
<author>
<name>Stephen Hemminger</name>
<email>stephen.hemminger@vyatta.com</email>
</author>
<published>2010-09-08T21:46:36+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=f8942e07a3db9d82e8fb11d3d494876b8bae9ff9'/>
<id>f8942e07a3db9d82e8fb11d3d494876b8bae9ff9</id>
<content type='text'>
The Sprint 4G network uses a Wimax dongle with Beecem
chipset. The driver is typical of out of tree drivers, but
maybe useful for people, and the hardware is readily available.

Here is a staging ready version (i.e warts and all)

0. Started with Rel_5.2.7.3P1_USB from Sprint4GDeveloperPack-1.1
1. Consolidated files in staging
2. Remove Dos cr/lf
3. Remove unnecessary ioctl from usbbcm_fops

Applied patches that were in the developer pack, surprising
there were ones for 2.6.35 already.

This is compile tested only, see TODO for what still needs
to be done.

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The Sprint 4G network uses a Wimax dongle with Beecem
chipset. The driver is typical of out of tree drivers, but
maybe useful for people, and the hardware is readily available.

Here is a staging ready version (i.e warts and all)

0. Started with Rel_5.2.7.3P1_USB from Sprint4GDeveloperPack-1.1
1. Consolidated files in staging
2. Remove Dos cr/lf
3. Remove unnecessary ioctl from usbbcm_fops

Applied patches that were in the developer pack, surprising
there were ones for 2.6.35 already.

This is compile tested only, see TODO for what still needs
to be done.

Signed-off-by: Stephen Hemminger &lt;shemminger@vyatta.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
</pre>
</div>
</content>
</entry>
</feed>
