linux.git/drivers/staging/bcm/InterfaceDld.c, branch v3.14

staging: bcm: line over 80 characters in InterfaceDld.c

2013-12-19T00:24:17+00:00

Fixed all the line over 80 characters warning found by
checkpatch.pl script.

Signed-off-by: Gokulnath A 
Signed-off-by: Greg Kroah-Hartman

staging:bcm: Removed developer debug prints in InterfaceDld.c

2013-12-19T00:24:17+00:00

Removed the developer debug prints BCM_DEBUG_PRINT()
as per the TODO list, also removed braces for the
if-statement to match coding style

Signed-off-by: Gokulnath A 
Signed-off-by: Greg Kroah-Hartman

staging: bcm: Remove unnecessary pointer casting

2013-10-30T00:03:40+00:00

Some void pointers can be assigned to other
pointer variables in functions without casting.

Signed-off-by: Lisa Nguyen 
Signed-off-by: Greg Kroah-Hartman

staging: bcm: Replace FALSE with false

2013-10-28T21:13:46+00:00

Replace user-defined type FALSE with C defined false keyword.

Signed-off-by: Lisa Nguyen 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: potential forever loop verifying firmware

2013-03-11T16:15:32+00:00

There is an ioctl() to write data to the firmware.  After the data
is written, it reads the databack from the firmware and compares
against what the user wanted to write and prints an error message
if it doesn't match.

The problem is that verify process has a forever loop if the
firmware size is not a multiple of 4.  I've fixed it by replacing
the bcm compare function with memcmp().

I have chopped out some debugging code in the process.

Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Remove typedef for _TARGET_PARAMS and call directly.

2013-01-07T18:54:01+00:00

This patch removes typedef for _TARGET_PARAMS, and changes
the name of the struct to bcm_target_params. In addition,
any calls to struct "stTargetParams, TARGET_PARAMS,
*PTARGET_PARAMS, STARGETPARAMS,  or *PSTARGETPARAMS are
changed to call directly.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Remove typedef for _S_INTERFACE_ADAPTER and call directly.

2012-11-02T18:36:46+00:00

This patch removes typedef for
_S_INTERFACE_ADAPTER, changes the
name of the struct to bcm_interface_adapter.
In addition, any calls to typedefs
S_INTERFACE_ADAPTER, or *PS_INTERFACE_ADAPTER
are changed to call the struct directly.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Remove typedef for _MINI_ADAPTER and call directly.

2012-06-05T04:09:22+00:00

This patch removes typedef for _MINI_ADAPTER, changes the
name of the struct from _MINI_ADAPTER to bcm_mini_adapter.
In addition, any calls to the following typedefs
"MINI_ADAPTER, *PMINI_ADAPTER" are changed to call
the struct directly.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Remove typedef for FirmwareInfo and call directly.

2012-06-05T04:06:35+00:00

This patch removes typedef for FirmwareInfo,
changes the name from Firmwareinfo to
bcm_firmware_info. In addition, any calls to
the following typedefs "PFIRMWARE_INFO,
FIRMWARE_INFO" are changed to call the struct
directly.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Fix information leak in ioctl: IOCTL_BCM_REGISTER_READ_PRIVATE, IOCTL_BCM_EEPROM_REGISTER_READ

2011-11-27T01:11:58+00:00

This patch fixes an information leak in ioctl
IOCTL_BCM_REGISTER_READ_PRIVATE and
IOCTL_BCM_EEPROM_REGISTER_READ when determining
the number of bytes to copy to user space.  Function,
usb_control_msg, returns the correct number of
bytes from the hardware.  Instead of using
this value, we were using a value derived from
user space. In this case, this value could be more
than the hardware allocated.  Therefore, this
patch copies the proper number of bytes from
the hardware, and uses this value as the maximum
number of bytes for user space.

Signed-off-by: Kevin McKinney 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman