linux.git/drivers/staging/axis-fifo, branch v5.1

staging: axis-fifo: add CONFIG_OF dependency

2019-03-18T06:57:58+00:00

When building without CONFIG_OF, the compiler loses track of the flow
control in axis_fifo_probe(), and thinks that many variables are used
without an initialization even though we actually leave the function
before the first use:

drivers/staging/axis-fifo/axis-fifo.c: In function 'axis_fifo_probe':
drivers/staging/axis-fifo/axis-fifo.c:900:5: error: 'rxd_tdata_width' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  if (rxd_tdata_width != 32) {
     ^
drivers/staging/axis-fifo/axis-fifo.c:907:5: error: 'txd_tdata_width' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  if (txd_tdata_width != 32) {
     ^
drivers/staging/axis-fifo/axis-fifo.c:914:5: error: 'has_tdest' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  if (has_tdest) {
     ^
drivers/staging/axis-fifo/axis-fifo.c:919:5: error: 'has_tid' may be used uninitialized in this function [-Werror=maybe-uninitialized]

When CONFIG_OF is set, this does not happen, and since the driver cannot
work without it, just add that option as a Kconfig dependency.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Greg Kroah-Hartman

staging: axis-fifo: Split line to stay in 80 characters.

2018-11-20T09:59:30+00:00

The line is split up to stay in 80 characters-

Signed-off-by: Cristian Sicilia 
Signed-off-by: Greg Kroah-Hartman

staging: axis-fifo: remove duplicated include from axis-fifo.c

2018-10-09T13:13:23+00:00

Remove duplicated include.

Signed-off-by: YueHaibing 
Signed-off-by: Greg Kroah-Hartman

staging: axis-fifo: Remove parentheses in axis-fifo.c

2018-10-09T12:57:33+00:00

staging: axis-fifo: remove parentheses in axis-fifo.c

Remove parentheses from the end of line and conform to
the coding style guidelines. Reported by checkpatch.

Add an extra space to the function arguments to fix
indentation.

Signed-off-by: Ioannis Valasakis 
Signed-off-by: Greg Kroah-Hartman

staging: axis-fifo: add error handling of class_create()

2018-10-02T22:18:36+00:00

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Greg Kroah-Hartman

staging: fix platform_no_drv_owner.cocci warnings

2018-07-29T12:40:41+00:00

drivers/staging/axis-fifo/axis-fifo.c:1081:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 4a965c5f89de ("staging: add driver for Xilinx AXI-Stream FIFO v4.1 IP core")
CC: Jacob Feder 
Signed-off-by: kbuild test robot 
Signed-off-by: Greg Kroah-Hartman

staging: axis-fifo: fix return value check in axis_fifo_probe()

2018-07-28T07:26:31+00:00

In case of error, the function device_create() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Fixes: 4a965c5f89de ("staging: add driver for Xilinx AXI-Stream FIFO v4.1 IP core")
Signed-off-by: Wei Yongjun 
Signed-off-by: Greg Kroah-Hartman

staging: add driver for Xilinx AXI-Stream FIFO v4.1 IP core

2018-07-24T12:14:13+00:00

This IP core has read and write AXI-Stream FIFOs, the contents of which can
be accessed from the AXI4 memory-mapped interface. This is useful for
transferring data from a processor into the FPGA fabric. The driver creates
a character device that can be read/written to with standard
open/read/write/close.

See Xilinx PG080 document for IP details.

https://www.xilinx.com/support/documentation/ip_documentation/axi_fifo_mm_s/v4_1/pg080-axi-fifo-mm-s.pdf

The driver currently supports only store-forward mode with a 32-bit
AXI4 Lite interface. DOES NOT support:
        - cut-through mode
        - AXI4 (non-lite)

Signed-off-by: Jacob Feder 
Signed-off-by: Greg Kroah-Hartman