linux.git/drivers/ssb/main.c, branch v5.14

ssb: remove unreachable code

2021-06-15T10:11:34+00:00

The return value of ssb_bus_unregister can only be 0 or -1, so this
condition if (err == -EBUSY) will not hold, so delete it.

Signed-off-by: Tian Tao 
Acked-by: Michael Büsch 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/1621306352-3632-1-git-send-email-tiantao6@hisilicon.com

ssb: Remove redundant assignment to err

2021-06-15T10:10:16+00:00

Variable 'err' is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Clean up the following clang-analyzer warning:

drivers/ssb/main.c:1306:3: warning: Value stored to 'err' is never read
[clang-analyzer-deadcode.DeadStores]
drivers/ssb/main.c:1312:3: warning: Value stored to 'err' is never read
[clang-analyzer-deadcode.DeadStores]

Reported-by: Abaci Robot 
Signed-off-by: Yang Li 
Acked-by: Michael Büsch 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/1619693230-108804-1-git-send-email-yang.lee@linux.alibaba.com

ssb: Fix indentation of comment

2021-06-15T10:09:55+00:00

Shifted the closing */ to the next line
This is done to maintain code uniformity.

Acked-by: Michael Büsch 
Signed-off-by: Shubhankar Kuranagatti 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210428162907.bn5q3oh3sji6wlh4@kewl-virtual-machine

ssb: Remove SSB_WARN_ON, SSB_BUG_ON and SSB_DEBUG

2018-08-09T15:47:47+00:00

Use the standard WARN_ON instead.
If a small kernel is desired, WARN_ON can be disabled globally.

Also remove SSB_DEBUG. Besides WARN_ON it only adds a tiny debug check.
Include this check unconditionally.

Signed-off-by: Michael Buesch 
Signed-off-by: Kalle Valo

ssb: Remove home-grown printk wrappers

2018-08-09T15:45:50+00:00

Replace the ssb printk wrappers by standard print helpers.
Also remove SSB_SILENT. Nobody should use it anyway.

Originally submitted by Joe Perches .
Modified to add dev_... based printks.

Signed-off-by: Michael Buesch 
Tested-by: Michael Buesch 
Cc: Joe Perches 
Signed-off-by: Kalle Valo

ssb: use put_device() if device_register fail

2018-03-13T16:48:29+00:00

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.

Signed-off-by: Arvind Yadav 
Signed-off-by: Kalle Valo

ssb: return boolean instead of integer in ssb_dma_translation_special_bit

2018-02-27T16:14:11+00:00

Return statements in functions returning bool should use
true/false instead of 1/0.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Kalle Valo

ssb: Delete an error message for a failed memory allocation in ssb_devices_register()

2017-05-24T13:46:51+00:00

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring 
Acked-by: Michael Büsch 
Signed-off-by: Kalle Valo

ssb: mark ssb_bus_register as __maybe_unused

2016-01-19T19:25:57+00:00

The SoC variant of the ssb code is now optional like the other
ones, which means we can build the framwork without any
front-end, but that results in a warning:

drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used [-Wunused-function]

This annotates the ssb_bus_register function as __maybe_unused to
shut up the warning. A configuration like this will not work on
any hardware of course, but we still want this to silently build
without warnings if the configuration is allowed in the first
place.

Signed-off-by: Arnd Bergmann 
Fixes: 845da6e58e19 ("ssb: add Kconfig entry for compiling SoC related code")
Acked-by: Michael Buesch 
Signed-off-by: Kalle Valo

ssb: pick SoC invariants code from MIPS BCM47xx arch

2015-12-16T14:36:25+00:00

There is code in ssb fetching "invariants" that is basically a set of
board specific data. Every host requires its own implementation of
reading function. In ssb we have support for PCI, PCMCIA & SDIO.
For some (historical?) reason code reading "invariants" for SoC was
placed in arch code and provided by a callback. This is not needed
nowadays, so lets move that into ssb. This way we keep all "invariants"
functions in a single module making code cleaner.

Signed-off-by: Rafał Miłecki 
Signed-off-by: Kalle Valo