linux.git/drivers/soc/apple/rtkit.c, branch v6.16

soc: apple: rtkit: Cut syslog messages after the first '\0'

2025-02-28T21:36:45+00:00

Certain messages from DCP contain NUL bytes in the random data after the
NUL terminated syslog message. Since the syslog message ends with '\n'
this results in a dev_info() message terminated with two newlines and an
empty printed line in the kernel log.

Signed-off-by: Janne Grunau 
Reviewed-by: Alyssa Rosenzweig 
Link: https://lore.kernel.org/r/20250226-apple-soc-misc-v2-4-c3ec37f9021b@svenpeter.dev
Signed-off-by: Sven Peter

soc: apple: rtkit: Use high prio work queue

2025-02-28T21:36:45+00:00

rtkit messages as communication with the DCP firmware for framebuffer
swaps or input events are time critical so use WQ_HIGHPRI to prevent
user space CPU load to increase latency.
With kwin_wayland 6's explicit sync mode user space load was able to
delay the IOMFB rtkit communication enough to miss vsync for surface
swaps. Minimal test scenario is constantly resizing a glxgears
Xwayland window.

Signed-off-by: Janne Grunau 
Reviewed-by: Alyssa Rosenzweig 
Link: https://lore.kernel.org/r/20250226-apple-soc-misc-v2-3-c3ec37f9021b@svenpeter.dev
Signed-off-by: Sven Peter

soc: apple: rtkit: Implement OSLog buffers properly

2025-02-28T21:36:45+00:00

Apparently nobody can figure out where the old logic came from, but it
seems like it has never been actually used on any supported firmware to
this day. OSLog buffers were apparently never requested.

But starting with 13.3, we actually need this implemented properly for
MTP (and later AOP) to work, so let's actually do that.

Signed-off-by: Hector Martin 
Reviewed-by: Alyssa Rosenzweig 
Link: https://lore.kernel.org/r/20250226-apple-soc-misc-v2-2-c3ec37f9021b@svenpeter.dev
Signed-off-by: Sven Peter

soc: apple: rtkit: Add and use PWR_STATE_INIT instead of _ON

2025-02-28T21:36:45+00:00

This state is needed to wake the dcp IOP after m1n1 shut it down
and works for all other co-processors as well.

Signed-off-by: Janne Grunau 
Reviewed-by: Alyssa Rosenzweig 
Link: https://lore.kernel.org/r/20250226-apple-soc-misc-v2-1-c3ec37f9021b@svenpeter.dev
Signed-off-by: Sven Peter

soc: apple: rtkit: Fix use-after-free in apple_rtkit_crashlog_rx()

2025-02-18T17:01:20+00:00

This code calls kfree(bfr); and then passes "bfr" to rtk->ops->crashed()
which is a use after free.  The ->crashed function pointer is implemented
by apple_nvme_rtkit_crashed() and it doesn't use the "bfr" pointer so
this doesn't cause a problem.  But it still looks sketchy as can be.

Fix this by moving kfree() after the last usage of bfr.

Fixes: bf8b4e49777d ("soc: apple: rtkit: Pass the crashlog to the crashed() callback")
Signed-off-by: Harshit Mogalapalli 
Reviewed-by: Eric Curtin 
Link: https://lore.kernel.org/r/20250212085853.1357906-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Sven Peter

soc: apple: rtkit: Pass the crashlog to the crashed() callback

2025-02-18T16:59:11+00:00

Client drivers might want a copy of the crashlog to stash into a
devcoredump blob. Since device memory management can be very variable,
the actual devcoredump implementation is left to client drivers. Pass
the raw crashlog buffer to the client callback so it can use it if
desired.

Signed-off-by: Asahi Lina 
Reviewed-by: Jens Axboe 
Link: https://lore.kernel.org/r/20250202-rtkit-crashdump-v1-1-9d38615b4e12@asahilina.net
Signed-off-by: Sven Peter

soc: apple: rtkit: Check & log more failures

2025-02-18T15:32:44+00:00

Check and log the following failures:

* regular messages
* management messages
* failed buffer requests

This helps debugging.

Signed-off-by: Asahi Lina 
Signed-off-by: Alyssa Rosenzweig 
Reviewed-by: Neal Gompa 
Link: https://lore.kernel.org/r/20250211-rtkit-more-logging-v1-1-93334e9c1c77@rosenzweig.io
Signed-off-by: Sven Peter

soc: apple: rtkit: Port to the internal mailbox driver

2023-11-23T10:10:17+00:00

Now that we have a mailbox driver in drivers/soc/apple, port the RTKit
code to it. This mostly just entails replacing calls through the mailbox
subsystem with direct calls into the driver.

Acked-by: Eric Curtin 
Acked-by: Neal Gompa 
Acked-by: Alyssa Rosenzweig 
Signed-off-by: Hector Martin

soc: apple: rtkit: Get rid of apple_rtkit_send_message_wait

2023-11-23T10:09:24+00:00

It is fundamentally broken and has no users. Just remove it.

Acked-by: Eric Curtin 
Acked-by: Neal Gompa 
Acked-by: Alyssa Rosenzweig 
Signed-off-by: Hector Martin

soc: apple: rtkit: Crop syslog messages

2023-03-28T10:59:34+00:00

Crop trailing whitespace, null, and newline characters in syslog
messages received from coprocessors. Notably DCP sends its messages
including a trailing newline, so prior to this change we would end up
cluttering the kernel log by repeated newlines at the end of messages.

Signed-off-by: Martin Povišer 
Reviewed-by: Hector Martin 
Signed-off-by: Hector Martin